From 8a069859ea51b74825232dede293834418f2f527 Mon Sep 17 00:00:00 2001 From: Dan Jones Date: Mon, 28 Oct 2024 11:50:18 -0500 Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20Rename=20constancts=20to?= =?UTF-8?q?=20not=20be=20uppercase?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app_test.go | 12 ++++++------ config/config_test.go | 4 ++-- config/env.go | 18 +++++++++--------- config/env_test.go | 22 +++++++++++----------- 4 files changed, 28 insertions(+), 28 deletions(-) diff --git a/app_test.go b/app_test.go index 426985e..3475516 100644 --- a/app_test.go +++ b/app_test.go @@ -22,7 +22,7 @@ func TestDefaultEnvironment(t *testing.T) { a, er := NewApp("0.0.0", c, testmocks.GetStore()) assert.NoError(t, er) if assert.NotNil(t, a) { - assert.Equal(t, config.DEV, a.Environment()) + assert.Equal(t, config.Dev, a.Environment()) } } @@ -31,11 +31,11 @@ func TestGivenEnvironment(t *testing.T) { given config.Env exp config.Env }{ - {config.DEV, config.DEV}, - {config.PROD, config.PROD}, - {config.QA, config.QA}, - {config.Env("foo"), config.DEV}, - {config.Env("✨"), config.DEV}, + {config.Dev, config.Dev}, + {config.Prod, config.Prod}, + {config.Qa, config.Qa}, + {config.Env("foo"), config.Dev}, + {config.Env("✨"), config.Dev}, } for _, c := range cases { diff --git a/config/config_test.go b/config/config_test.go index 2586018..12c0e4c 100644 --- a/config/config_test.go +++ b/config/config_test.go @@ -8,12 +8,12 @@ import ( func TestEnvDefaultsToDev(t *testing.T) { c := Config{} - assert.Equal(t, DEV, c.Environment()) + assert.Equal(t, Dev, c.Environment()) } func TestInvalidEnvReturnsDev(t *testing.T) { c := Config{Env: Env("foobar")} - assert.Equal(t, DEV, c.Environment()) + assert.Equal(t, Dev, c.Environment()) } func TestValidEnvReturnsCorrect(t *testing.T) { diff --git a/config/env.go b/config/env.go index 99f8aa0..b38e4fd 100644 --- a/config/env.go +++ b/config/env.go @@ -3,24 +3,24 @@ package config type Env string const ( - DEV Env = "dev" - PROD Env = "prod" - QA Env = "qa" - TEST Env = "test" + Dev Env = "dev" + Prod Env = "prod" + Qa Env = "qa" + Test Env = "test" ) var Envs = [...]Env{ - DEV, - PROD, - QA, - TEST, + Dev, + Prod, + Qa, + Test, } func ValidEnvOrDev(e Env) Env { if ValidEnv(e) { return e } - return DEV + return Dev } func ValidEnv(env Env) bool { diff --git a/config/env_test.go b/config/env_test.go index 2084c0a..680a79b 100644 --- a/config/env_test.go +++ b/config/env_test.go @@ -21,10 +21,10 @@ func TestValidEnv(t *testing.T) { e Env exp bool }{ - {DEV, true}, - {PROD, true}, - {QA, true}, - {TEST, true}, + {Dev, true}, + {Prod, true}, + {Qa, true}, + {Test, true}, {Env("foobar"), false}, {Env(""), false}, {Env("✨"), false}, @@ -42,13 +42,13 @@ func TestValidEnvOrDev(t *testing.T) { give Env exp Env }{ - {DEV, DEV}, - {PROD, PROD}, - {QA, QA}, - {TEST, TEST}, - {Env("foobar"), DEV}, - {Env(""), DEV}, - {Env("✨"), DEV}, + {Dev, Dev}, + {Prod, Prod}, + {Qa, Qa}, + {Test, Test}, + {Env("foobar"), Dev}, + {Env(""), Dev}, + {Env("✨"), Dev}, } for _, c := range cases {