Merge pull request #530 from PHP-FFMpeg/jens1o-patch-1
fix documentation and add a todo comment
This commit is contained in:
		
				commit
				
					
						233742db0a
					
				
			
		
					 1 changed files with 2 additions and 1 deletions
				
			
		|  | @ -72,7 +72,7 @@ class Concat extends AbstractMediaType | |||
|     /** | ||||
|      * Saves the concatenated video in the given array, considering that the sources videos are all encoded with the same codec. | ||||
|      * | ||||
|      * @param array   $outputPathfile | ||||
|      * @param string  $outputPathfile | ||||
|      * @param string  $streamCopy | ||||
|      * | ||||
|      * @return Concat | ||||
|  | @ -144,6 +144,7 @@ class Concat extends AbstractMediaType | |||
|             $this->driver->command($commands); | ||||
|         } catch (ExecutionFailureException $e) { | ||||
|             $this->cleanupTemporaryFile($outputPathfile); | ||||
|             // TODO@v1: paste this line into an `finally` block.
 | ||||
|             $this->cleanupTemporaryFile($sourcesFile); | ||||
|             throw new RuntimeException('Unable to save concatenated video', $e->getCode(), $e); | ||||
|         } | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue