From d13fa59759624460722610a5e67d763b5f2fcfdf Mon Sep 17 00:00:00 2001 From: Ivan Ganev Date: Tue, 7 Nov 2017 11:07:33 +0200 Subject: [PATCH] updated color setter validation to throw InvalidArgumentException instead of silently unsetting values --- src/FFMpeg/Media/Waveform.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/FFMpeg/Media/Waveform.php b/src/FFMpeg/Media/Waveform.php index 8db0af1..975f542 100644 --- a/src/FFMpeg/Media/Waveform.php +++ b/src/FFMpeg/Media/Waveform.php @@ -12,6 +12,7 @@ namespace FFMpeg\Media; use Alchemy\BinaryDriver\Exception\ExecutionFailureException; +use FFMpeg\Exception\InvalidArgumentException; use FFMpeg\Filters\Waveform\WaveformFilterInterface; use FFMpeg\Filters\Waveform\WaveformFilters; use FFMpeg\Driver\FFMpegDriver; @@ -89,7 +90,9 @@ class Waveform extends AbstractMediaType if (!preg_match('/^#(?:[0-9a-fA-F]{6})$/', $value)) { //invalid color - unset($colors[$row]); + //unset($colors[$row]); + + throw new InvalidArgumentException("The provided color '$value' is invalid"); } }