From fc55cf51d84078621dee8a8b34357db944574453 Mon Sep 17 00:00:00 2001 From: Jens Hausdorf Date: Thu, 10 May 2018 14:29:24 +0200 Subject: [PATCH] fix documentation and add a todo comment fixes #529 --- src/FFMpeg/Media/Concat.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/FFMpeg/Media/Concat.php b/src/FFMpeg/Media/Concat.php index 9671a9a..97f5e1e 100644 --- a/src/FFMpeg/Media/Concat.php +++ b/src/FFMpeg/Media/Concat.php @@ -72,7 +72,7 @@ class Concat extends AbstractMediaType /** * Saves the concatenated video in the given array, considering that the sources videos are all encoded with the same codec. * - * @param array $outputPathfile + * @param string $outputPathfile * @param string $streamCopy * * @return Concat @@ -144,6 +144,7 @@ class Concat extends AbstractMediaType $this->driver->command($commands); } catch (ExecutionFailureException $e) { $this->cleanupTemporaryFile($outputPathfile); + // TODO@v1: paste this line into an `finally` block. $this->cleanupTemporaryFile($sourcesFile); throw new RuntimeException('Unable to save concatenated video', $e->getCode(), $e); }