Add Makefile targets for go vet and go fix, use named struct fields in tests, apply go fix improvements

This commit is contained in:
Dan Jones 2026-03-01 07:59:31 -06:00
commit 30a5786adf
7 changed files with 34 additions and 28 deletions

View file

@ -17,7 +17,7 @@ func TestJsonName(t *testing.T) {
func TestJsonMeta(t *testing.T) {
f, _ := New("json")
m := models.Meta{"foo", 42}
m := models.Meta{Key: "foo", Value: 42}
exp := `{"foo":42}`
o, err := f.Meta(m)
be.Err(t, err, nil)
@ -27,7 +27,7 @@ func TestJsonMeta(t *testing.T) {
func TestJsonEntry(t *testing.T) {
when := time.Now()
f, _ := New("json")
m := models.Meta{"foo", 42}
m := models.Meta{Key: "foo", Value: 42}
e := models.Entry{
Title: "Homer",
Date: when,
@ -42,13 +42,13 @@ func TestJsonEntry(t *testing.T) {
func TestJsonLog(t *testing.T) {
when := time.Now()
f, _ := New("json")
m := models.Meta{"foo", 42}
m := models.Meta{Key: "foo", Value: 42}
e := models.Entry{
Title: "Homer",
Date: when,
Fields: []models.Meta{m},
}
l := models.Log{"stuff", []models.Entry{e}}
l := models.Log{Name: "stuff", Entries: []models.Entry{e}}
exp := fmt.Sprintf(`{"%s":[{"title":"%s","date":"%s","foo":42}]}`, l.Name, e.Title, when.Format(time.RFC3339))
o, err := f.Log(l)
be.Err(t, err, nil)
@ -65,7 +65,7 @@ func TestJsonNoLogs(t *testing.T) {
func TestJsonErr(t *testing.T) {
f, _ := New("json")
o, err := f.Meta(models.Meta{"foo", make(chan bool)})
o, err := f.Meta(models.Meta{Key: "foo", Value: make(chan bool)})
var exp []byte
be.Err(t, err)
be.Equal(t, o, exp)
@ -73,7 +73,7 @@ func TestJsonErr(t *testing.T) {
func TestJsonPretty(t *testing.T) {
f := Json{true}
o, err := f.Meta(models.Meta{"foo", 42})
o, err := f.Meta(models.Meta{Key: "foo", Value: 42})
exp := `{
"foo": 42
}`