🔀 Merge branch 'feature/form-more' into develop

This commit is contained in:
Dan Jones 2024-03-10 20:35:30 -05:00
commit e67f159ce7
7 changed files with 214 additions and 3 deletions

View file

@ -4,6 +4,7 @@ import "codeberg.org/danjones000/my-log/models"
type Formatter interface { type Formatter interface {
Name() string Name() string
Logs([]models.Log) (out []byte, err error)
Log(models.Log) (out []byte, err error) Log(models.Log) (out []byte, err error)
Entry(models.Entry) (out []byte, err error) Entry(models.Entry) (out []byte, err error)
Meta(models.Meta) (out []byte, err error) Meta(models.Meta) (out []byte, err error)

77
formatters/json.go Normal file
View file

@ -0,0 +1,77 @@
package formatters
import (
"bytes"
"encoding/json"
"time"
"codeberg.org/danjones000/my-log/config"
"codeberg.org/danjones000/my-log/models"
)
func newJson(ff config.Formatters) (Formatter, error) {
return &Json{ff.Json().PrettyPrint}, nil
}
type Json struct {
prettPrint bool
}
func (js *Json) Name() string {
return "json"
}
func (js *Json) marshal(v any) (o []byte, err error) {
o, err = json.Marshal(v)
if err != nil {
return
}
if js.prettPrint {
buff := &bytes.Buffer{}
err = json.Indent(buff, o, "", "\t")
if err == nil {
o = buff.Bytes()
}
}
return
}
func (js *Json) Meta(m models.Meta) ([]byte, error) {
o := map[string]any{m.Key: m.Value}
return js.marshal(o)
}
func (js *Json) entryMap(e models.Entry) map[string]any {
o := map[string]any{
"title": e.Title,
"date": e.Date.Format(time.RFC3339),
}
for _, m := range e.Fields {
o[m.Key] = m.Value
}
return o
}
func (js *Json) Entry(e models.Entry) ([]byte, error) {
return js.marshal(js.entryMap(e))
}
func (js *Json) Log(l models.Log) ([]byte, error) {
return js.Logs([]models.Log{l})
}
func (js *Json) Logs(logs []models.Log) (out []byte, err error) {
if len(logs) == 0 {
return
}
o := map[string][]map[string]any{}
for _, l := range logs {
es := []map[string]any{}
for _, e := range l.Entries {
es = append(es, js.entryMap(e))
}
o[l.Name] = es
}
return js.marshal(o)
}

81
formatters/json_test.go Normal file
View file

@ -0,0 +1,81 @@
package formatters
import (
"fmt"
"testing"
"time"
"codeberg.org/danjones000/my-log/models"
"github.com/stretchr/testify/assert"
)
func TestJsonName(t *testing.T) {
f, _ := New("json")
assert.Equal(t, "json", f.Name())
}
func TestJsonMeta(t *testing.T) {
f, _ := New("json")
m := models.Meta{"foo", 42}
exp := `{"foo":42}`
o, err := f.Meta(m)
assert.NoError(t, err)
assert.JSONEq(t, exp, string(o))
}
func TestJsonEntry(t *testing.T) {
when := time.Now()
f, _ := New("json")
m := models.Meta{"foo", 42}
e := models.Entry{
Title: "Homer",
Date: when,
Fields: []models.Meta{m},
}
exp := fmt.Sprintf(`{"title":"%s","date":"%s","foo":42}`, e.Title, when.Format(time.RFC3339))
o, err := f.Entry(e)
assert.NoError(t, err)
assert.JSONEq(t, exp, string(o))
}
func TestJsonLog(t *testing.T) {
when := time.Now()
f, _ := New("json")
m := models.Meta{"foo", 42}
e := models.Entry{
Title: "Homer",
Date: when,
Fields: []models.Meta{m},
}
l := models.Log{"stuff", []models.Entry{e}}
exp := fmt.Sprintf(`{"%s":[{"title":"%s","date":"%s","foo":42}]}`, l.Name, e.Title, when.Format(time.RFC3339))
o, err := f.Log(l)
assert.NoError(t, err)
assert.JSONEq(t, exp, string(o))
}
func TestJsonNoLogs(t *testing.T) {
f, _ := New("json")
o, err := f.Logs([]models.Log{})
var exp []byte
assert.NoError(t, err)
assert.Equal(t, exp, o)
}
func TestJsonErr(t *testing.T) {
f, _ := New("json")
o, err := f.Meta(models.Meta{"foo", make(chan bool)})
var exp []byte
assert.Error(t, err)
assert.Equal(t, exp, o)
}
func TestJsonPretty(t *testing.T) {
f := Json{true}
o, err := f.Meta(models.Meta{"foo", 42})
exp := `{
"foo": 42
}`
assert.NoError(t, err)
assert.Equal(t, exp, string(o))
}

View file

@ -10,6 +10,7 @@ type formatMaker func(config.Formatters) (Formatter, error)
var formatterMap = map[string]formatMaker{ var formatterMap = map[string]formatMaker{
"plain": newPlain, "plain": newPlain,
"json": newJson,
} }
func Preferred() (f Formatter, err error) { func Preferred() (f Formatter, err error) {

View file

@ -10,7 +10,7 @@ import (
) )
func TestKinds(t *testing.T) { func TestKinds(t *testing.T) {
assert.Equal(t, []string{"plain"}, Kinds()) assert.ElementsMatch(t, []string{"plain", "json"}, Kinds())
} }
func TestNewUnsupported(t *testing.T) { func TestNewUnsupported(t *testing.T) {

View file

@ -20,6 +20,26 @@ func (pt *PlainText) Name() string {
return "plain" return "plain"
} }
func (pt *PlainText) Logs(logs []models.Log) (out []byte, err error) {
if len(logs) == 0 {
return
}
buff := &bytes.Buffer{}
first := true
for _, log := range logs {
o, _ := pt.Log(log)
if !first {
buff.WriteByte(10)
buff.WriteByte(10)
}
first = false
buff.Write(o)
}
out = buff.Bytes()
return
}
func (pt *PlainText) Log(log models.Log) (out []byte, err error) { func (pt *PlainText) Log(log models.Log) (out []byte, err error) {
if len(log.Entries) == 0 { if len(log.Entries) == 0 {
return return

View file

@ -13,7 +13,7 @@ import (
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
) )
func TestPlainLog(t *testing.T) { func TestPlainLogs(t *testing.T) {
m := []models.Meta{ m := []models.Meta{
{"foo", "bar"}, {"foo", "bar"},
{"baz", 42}, {"baz", 42},
@ -23,11 +23,17 @@ func TestPlainLog(t *testing.T) {
{Title: "small", Date: time.Now()}, {Title: "small", Date: time.Now()},
} }
l := models.Log{"stuff", e} l := models.Log{"stuff", e}
e2 := models.Entry{
Title: "three",
Date: time.Now(),
}
l2 := models.Log{"more-stuff", []models.Entry{e2}}
logs := []models.Log{l, l2}
f, err := New("plain") f, err := New("plain")
require.NoError(t, err) require.NoError(t, err)
out, err := f.Log(l) out, err := f.Logs(logs)
require.NoError(t, err) require.NoError(t, err)
read := bytes.NewReader(out) read := bytes.NewReader(out)
@ -67,6 +73,24 @@ func TestPlainLog(t *testing.T) {
line = scan.Text() line = scan.Text()
assert.Equal(t, "Date: "+e[1].Date.Format(tools.DateFormat), line) assert.Equal(t, "Date: "+e[1].Date.Format(tools.DateFormat), line)
scan.Scan()
scan.Scan()
line = scan.Text()
assert.Equal(t, l2.Name, line)
scan.Scan()
line = scan.Text()
assert.Equal(t, "#######", line)
scan.Scan()
scan.Scan()
line = scan.Text()
assert.Equal(t, "Title: "+e2.Title, line)
scan.Scan()
line = scan.Text()
assert.Equal(t, "Date: "+e2.Date.Format(tools.DateFormat), line)
more := scan.Scan() more := scan.Scan()
assert.False(t, more) assert.False(t, more)
} }
@ -76,6 +100,13 @@ func TestPlainName(t *testing.T) {
assert.Equal(t, "plain", f.Name()) assert.Equal(t, "plain", f.Name())
} }
func TestPlainLogNone(t *testing.T) {
f, _ := New("plain")
out, err := f.Logs([]models.Log{})
assert.NoError(t, err)
assert.Len(t, out, 0)
}
func TestPlainLogNoEntries(t *testing.T) { func TestPlainLogNoEntries(t *testing.T) {
f, _ := New("plain") f, _ := New("plain")
out, err := f.Log(models.Log{Name: "foo"}) out, err := f.Log(models.Log{Name: "foo"})