Merge pull request #15 from n8n-io/integrate-community-linting-ruleset

Integrate community linting ruleset
This commit is contained in:
Omar Ajoue 2022-06-27 15:48:26 +02:00 committed by GitHub
commit 392a2a4064
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 4 deletions

View file

@ -11,6 +11,7 @@ module.exports = {
parserOptions: { parserOptions: {
project: ['./tsconfig.json'], project: ['./tsconfig.json'],
sourceType: 'module', sourceType: 'module',
extraFileExtensions: ['.json'],
}, },
ignorePatterns: [ ignorePatterns: [
'.eslintrc.js', '.eslintrc.js',
@ -25,10 +26,39 @@ module.exports = {
overrides: [ overrides: [
{ {
files: [ './**/*.ts' ], files: ['package.json'],
plugins: ['eslint-plugin-n8n-nodes-base'],
rules: {
'n8n-nodes-base/community-package-json-author-email-still-default': 'error',
'n8n-nodes-base/community-package-json-author-missing': 'error',
'n8n-nodes-base/community-package-json-author-name-missing': 'error',
'n8n-nodes-base/community-package-json-author-name-still-default': 'error',
'n8n-nodes-base/community-package-json-description-missing': 'error',
'n8n-nodes-base/community-package-json-description-still-default': 'error',
'n8n-nodes-base/community-package-json-keywords-missing': 'error',
'n8n-nodes-base/community-package-json-keywords-without-official-tag': 'error',
'n8n-nodes-base/community-package-json-license-missing': 'error',
'n8n-nodes-base/community-package-json-license-not-default': 'error',
'n8n-nodes-base/community-package-json-n8n-missing': 'error',
'n8n-nodes-base/community-package-json-n8n-nodes-empty': 'error',
'n8n-nodes-base/community-package-json-n8n-nodes-missing': 'error',
'n8n-nodes-base/community-package-json-name-missing': 'error',
'n8n-nodes-base/community-package-json-name-still-default': 'error',
'n8n-nodes-base/community-package-json-repository-url-still-default': 'error',
'n8n-nodes-base/community-package-json-version-missing': 'error',
},
},
{
files: ['./credentials/**/*.ts'],
plugins: ['eslint-plugin-n8n-nodes-base'], plugins: ['eslint-plugin-n8n-nodes-base'],
rules: { rules: {
'n8n-nodes-base/filesystem-wrong-cred-filename': 'error', 'n8n-nodes-base/filesystem-wrong-cred-filename': 'error',
},
},
{
files: ['./nodes/**/*.ts'],
plugins: ['eslint-plugin-n8n-nodes-base'],
rules: {
'n8n-nodes-base/filesystem-wrong-node-filename': 'error', 'n8n-nodes-base/filesystem-wrong-node-filename': 'error',
'n8n-nodes-base/node-class-description-empty-string': 'error', 'n8n-nodes-base/node-class-description-empty-string': 'error',
'n8n-nodes-base/node-class-description-icon-not-svg': 'error', 'n8n-nodes-base/node-class-description-icon-not-svg': 'error',

View file

@ -20,8 +20,8 @@
"build": "tsc && gulp build:icons", "build": "tsc && gulp build:icons",
"dev": "tsc --watch", "dev": "tsc --watch",
"format": "prettier nodes credentials --write", "format": "prettier nodes credentials --write",
"lint": "tslint -p tsconfig.json -c tslint.json && node_modules/eslint/bin/eslint.js ./nodes", "lint": "tslint -p tsconfig.json -c tslint.json; eslint nodes credentials package.json",
"lintfix": "tslint --fix -p tsconfig.json -c tslint.json && node_modules/eslint/bin/eslint.js --fix ./nodes" "lintfix": "tslint --fix -p tsconfig.json -c tslint.json; eslint nodes credentials package.json --fix"
}, },
"files": [ "files": [
"dist" "dist"
@ -40,7 +40,7 @@
"@types/express": "^4.17.6", "@types/express": "^4.17.6",
"@types/request-promise-native": "~1.0.15", "@types/request-promise-native": "~1.0.15",
"@typescript-eslint/parser": "^5.29.0", "@typescript-eslint/parser": "^5.29.0",
"eslint-plugin-n8n-nodes-base": "^1.0.43", "eslint-plugin-n8n-nodes-base": "~1.1.1",
"gulp": "^4.0.2", "gulp": "^4.0.2",
"n8n-workflow": "~0.104.0", "n8n-workflow": "~0.104.0",
"prettier": "^2.7.1", "prettier": "^2.7.1",

View file

@ -25,5 +25,6 @@
"credentials/**/*", "credentials/**/*",
"nodes/**/*", "nodes/**/*",
"nodes/**/*.json", "nodes/**/*.json",
"package.json",
], ],
} }