2023-03-12 16:00:57 +01:00
|
|
|
// GoToSocial
|
|
|
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
|
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
|
//
|
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
|
// (at your option) any later version.
|
|
|
|
|
//
|
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
// GNU Affero General Public License for more details.
|
|
|
|
|
//
|
|
|
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
|
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2021-08-25 15:34:33 +02:00
|
|
|
|
|
|
|
|
package bundb
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"context"
|
2022-09-12 13:03:23 +02:00
|
|
|
"errors"
|
2024-01-19 12:57:29 +00:00
|
|
|
"slices"
|
2025-05-26 15:33:42 +02:00
|
|
|
"strings"
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2025-04-26 15:34:10 +02:00
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/db"
|
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtscontext"
|
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtserror"
|
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
|
2025-05-26 15:33:42 +02:00
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/id"
|
2025-04-26 15:34:10 +02:00
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/log"
|
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/state"
|
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/util/xslices"
|
2021-08-25 15:34:33 +02:00
|
|
|
"github.com/uptrace/bun"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
type statusDB struct {
|
2024-02-07 14:43:27 +00:00
|
|
|
db *bun.DB
|
2022-12-08 17:35:14 +00:00
|
|
|
state *state.State
|
2022-11-15 18:45:15 +00:00
|
|
|
}
|
|
|
|
|
|
2023-07-25 09:34:05 +01:00
|
|
|
func (s *statusDB) GetStatusByID(ctx context.Context, id string) (*gtsmodel.Status, error) {
|
2021-09-01 10:08:21 +01:00
|
|
|
return s.getStatus(
|
|
|
|
|
ctx,
|
2022-11-15 18:45:15 +00:00
|
|
|
"ID",
|
2021-09-01 10:08:21 +01:00
|
|
|
func(status *gtsmodel.Status) error {
|
2023-08-10 15:08:41 +01:00
|
|
|
return s.db.NewSelect().Model(status).Where("? = ?", bun.Ident("status.id"), id).Scan(ctx)
|
2021-09-01 10:08:21 +01:00
|
|
|
},
|
2022-11-15 18:45:15 +00:00
|
|
|
id,
|
2021-09-01 10:08:21 +01:00
|
|
|
)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-07-24 13:14:13 +01:00
|
|
|
func (s *statusDB) GetStatusesByIDs(ctx context.Context, ids []string) ([]*gtsmodel.Status, error) {
|
2024-04-02 11:03:40 +01:00
|
|
|
// Load all input status IDs via cache loader callback.
|
2024-07-24 09:41:43 +01:00
|
|
|
statuses, err := s.state.Caches.DB.Status.LoadIDs("ID",
|
2024-04-02 11:03:40 +01:00
|
|
|
ids,
|
|
|
|
|
func(uncached []string) ([]*gtsmodel.Status, error) {
|
2024-01-19 12:57:29 +00:00
|
|
|
// Preallocate expected length of uncached statuses.
|
2024-09-16 16:46:09 +00:00
|
|
|
statuses := make([]*gtsmodel.Status, 0, len(uncached))
|
2024-01-19 12:57:29 +00:00
|
|
|
|
|
|
|
|
// Perform database query scanning
|
|
|
|
|
// the remaining (uncached) status IDs.
|
|
|
|
|
if err := s.db.NewSelect().
|
|
|
|
|
Model(&statuses).
|
|
|
|
|
Where("? IN (?)", bun.Ident("id"), bun.In(uncached)).
|
|
|
|
|
Scan(ctx); err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return statuses, nil
|
|
|
|
|
},
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Reorder the statuses by their
|
|
|
|
|
// IDs to ensure in correct order.
|
|
|
|
|
getID := func(s *gtsmodel.Status) string { return s.ID }
|
2024-11-11 15:45:19 +00:00
|
|
|
xslices.OrderBy(statuses, ids, getID)
|
2023-01-10 15:19:05 +01:00
|
|
|
|
2024-01-19 12:57:29 +00:00
|
|
|
if gtscontext.Barebones(ctx) {
|
|
|
|
|
// no need to fully populate.
|
|
|
|
|
return statuses, nil
|
2023-01-10 15:19:05 +01:00
|
|
|
}
|
|
|
|
|
|
2024-01-19 12:57:29 +00:00
|
|
|
// Populate all loaded statuses, removing those we fail to
|
|
|
|
|
// populate (removes needing so many nil checks everywhere).
|
|
|
|
|
statuses = slices.DeleteFunc(statuses, func(status *gtsmodel.Status) bool {
|
|
|
|
|
if err := s.PopulateStatus(ctx, status); err != nil {
|
|
|
|
|
log.Errorf(ctx, "error populating status %s: %v", status.ID, err)
|
|
|
|
|
return true
|
|
|
|
|
}
|
|
|
|
|
return false
|
|
|
|
|
})
|
|
|
|
|
|
2023-01-10 15:19:05 +01:00
|
|
|
return statuses, nil
|
|
|
|
|
}
|
|
|
|
|
|
2023-07-25 09:34:05 +01:00
|
|
|
func (s *statusDB) GetStatusByURI(ctx context.Context, uri string) (*gtsmodel.Status, error) {
|
2021-09-01 10:08:21 +01:00
|
|
|
return s.getStatus(
|
|
|
|
|
ctx,
|
2022-11-15 18:45:15 +00:00
|
|
|
"URI",
|
2021-09-01 10:08:21 +01:00
|
|
|
func(status *gtsmodel.Status) error {
|
2023-08-10 15:08:41 +01:00
|
|
|
return s.db.NewSelect().Model(status).Where("? = ?", bun.Ident("status.uri"), uri).Scan(ctx)
|
2021-09-01 10:08:21 +01:00
|
|
|
},
|
2022-11-15 18:45:15 +00:00
|
|
|
uri,
|
2021-09-01 10:08:21 +01:00
|
|
|
)
|
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2023-07-25 09:34:05 +01:00
|
|
|
func (s *statusDB) GetStatusByURL(ctx context.Context, url string) (*gtsmodel.Status, error) {
|
2021-09-01 10:08:21 +01:00
|
|
|
return s.getStatus(
|
|
|
|
|
ctx,
|
2022-11-15 18:45:15 +00:00
|
|
|
"URL",
|
2021-09-01 10:08:21 +01:00
|
|
|
func(status *gtsmodel.Status) error {
|
2023-08-10 15:08:41 +01:00
|
|
|
return s.db.NewSelect().Model(status).Where("? = ?", bun.Ident("status.url"), url).Scan(ctx)
|
2021-09-01 10:08:21 +01:00
|
|
|
},
|
2022-11-15 18:45:15 +00:00
|
|
|
url,
|
2021-09-01 10:08:21 +01:00
|
|
|
)
|
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2023-12-15 14:24:39 +00:00
|
|
|
func (s *statusDB) GetStatusByPollID(ctx context.Context, pollID string) (*gtsmodel.Status, error) {
|
|
|
|
|
return s.getStatus(
|
|
|
|
|
ctx,
|
|
|
|
|
"PollID",
|
|
|
|
|
func(status *gtsmodel.Status) error {
|
|
|
|
|
return s.db.NewSelect().Model(status).Where("? = ?", bun.Ident("status.poll_id"), pollID).Scan(ctx)
|
|
|
|
|
},
|
|
|
|
|
pollID,
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) GetStatusBoost(ctx context.Context, boostOfID string, byAccountID string) (*gtsmodel.Status, error) {
|
|
|
|
|
return s.getStatus(
|
|
|
|
|
ctx,
|
2024-01-19 12:57:29 +00:00
|
|
|
"BoostOfID,AccountID",
|
2023-08-04 12:28:33 +01:00
|
|
|
func(status *gtsmodel.Status) error {
|
2023-08-10 15:08:41 +01:00
|
|
|
return s.db.NewSelect().Model(status).
|
2023-08-04 12:28:33 +01:00
|
|
|
Where("status.boost_of_id = ?", boostOfID).
|
|
|
|
|
Where("status.account_id = ?", byAccountID).
|
|
|
|
|
|
|
|
|
|
// Our old code actually allowed a status to
|
|
|
|
|
// be boosted multiple times by the same author,
|
|
|
|
|
// so limit our query + order to fetch latest.
|
|
|
|
|
Order("status.id DESC"). // our IDs are timestamped
|
|
|
|
|
Limit(1).
|
|
|
|
|
Scan(ctx)
|
|
|
|
|
},
|
|
|
|
|
boostOfID, byAccountID,
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
|
2023-07-25 09:34:05 +01:00
|
|
|
func (s *statusDB) getStatus(ctx context.Context, lookup string, dbQuery func(*gtsmodel.Status) error, keyParts ...any) (*gtsmodel.Status, error) {
|
2022-11-15 18:45:15 +00:00
|
|
|
// Fetch status from database cache with loader callback
|
2024-07-24 09:41:43 +01:00
|
|
|
status, err := s.state.Caches.DB.Status.LoadOne(lookup, func() (*gtsmodel.Status, error) {
|
2022-11-15 18:45:15 +00:00
|
|
|
var status gtsmodel.Status
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
// Not cached! Perform database query.
|
2022-11-15 18:45:15 +00:00
|
|
|
if err := dbQuery(&status); err != nil {
|
2023-08-17 17:26:21 +01:00
|
|
|
return nil, err
|
2021-09-01 10:08:21 +01:00
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
return &status, nil
|
|
|
|
|
}, keyParts...)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if gtscontext.Barebones(ctx) {
|
|
|
|
|
// no need to fully populate.
|
|
|
|
|
return status, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Further populate the status fields where applicable.
|
|
|
|
|
if err := s.PopulateStatus(ctx, status); err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return status, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (s *statusDB) PopulateStatus(ctx context.Context, status *gtsmodel.Status) error {
|
2023-05-09 13:25:48 +02:00
|
|
|
var (
|
|
|
|
|
err error
|
2024-12-05 13:35:07 +00:00
|
|
|
errs gtserror.MultiError
|
2023-05-09 13:25:48 +02:00
|
|
|
)
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
|
|
|
|
|
if status.Account == nil {
|
|
|
|
|
// Status author is not set, fetch from database.
|
|
|
|
|
status.Account, err = s.state.DB.GetAccountByID(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
status.AccountID,
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status author: %w", err)
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if status.InReplyToID != "" {
|
|
|
|
|
if status.InReplyTo == nil {
|
|
|
|
|
// Status parent is not set, fetch from database.
|
|
|
|
|
status.InReplyTo, err = s.GetStatusByID(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
status.InReplyToID,
|
|
|
|
|
)
|
2024-07-10 06:38:25 -07:00
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status parent: %w", err)
|
2022-11-18 17:28:33 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
if status.InReplyToAccount == nil {
|
|
|
|
|
// Status parent author is not set, fetch from database.
|
|
|
|
|
status.InReplyToAccount, err = s.state.DB.GetAccountByID(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
status.InReplyToAccountID,
|
|
|
|
|
)
|
2022-11-15 18:45:15 +00:00
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status parent author: %w", err)
|
2021-09-01 10:08:21 +01:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
if status.BoostOfID != "" {
|
|
|
|
|
if status.BoostOf == nil {
|
|
|
|
|
// Status boost is not set, fetch from database.
|
|
|
|
|
status.BoostOf, err = s.GetStatusByID(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
status.BoostOfID,
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status boost: %w", err)
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
}
|
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
if status.BoostOfAccount == nil {
|
|
|
|
|
// Status boost author is not set, fetch from database.
|
|
|
|
|
status.BoostOfAccount, err = s.state.DB.GetAccountByID(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
status.BoostOfAccountID,
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status boost author: %w", err)
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
}
|
2022-11-18 17:28:33 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-11-08 14:32:17 +00:00
|
|
|
if status.PollID != "" && status.Poll == nil {
|
|
|
|
|
// Status poll is not set, fetch from database.
|
|
|
|
|
status.Poll, err = s.state.DB.GetPollByID(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
status.PollID,
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
|
|
|
|
errs.Appendf("error populating status poll: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
if !status.AttachmentsPopulated() {
|
|
|
|
|
// Status attachments are out-of-date with IDs, repopulate.
|
|
|
|
|
status.Attachments, err = s.state.DB.GetAttachmentsByIDs(
|
2024-12-05 13:35:07 +00:00
|
|
|
gtscontext.SetBarebones(ctx),
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
status.AttachmentIDs,
|
|
|
|
|
)
|
2022-11-18 17:28:33 +00:00
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status attachments: %w", err)
|
2022-11-18 17:28:33 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-07-31 15:47:35 +02:00
|
|
|
if !status.TagsPopulated() {
|
|
|
|
|
// Status tags are out-of-date with IDs, repopulate.
|
|
|
|
|
status.Tags, err = s.state.DB.GetTags(
|
2024-12-05 13:35:07 +00:00
|
|
|
gtscontext.SetBarebones(ctx),
|
2023-07-31 15:47:35 +02:00
|
|
|
status.TagIDs,
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status tags: %w", err)
|
2023-07-31 15:47:35 +02:00
|
|
|
}
|
|
|
|
|
}
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
|
|
|
|
|
if !status.MentionsPopulated() {
|
|
|
|
|
// Status mentions are out-of-date with IDs, repopulate.
|
|
|
|
|
status.Mentions, err = s.state.DB.GetMentions(
|
2024-12-05 13:35:07 +00:00
|
|
|
ctx, // TODO: manually populate mentions for places expecting these populated
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
status.MentionIDs,
|
|
|
|
|
)
|
2022-11-18 17:28:33 +00:00
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status mentions: %w", err)
|
2022-11-18 17:28:33 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
if !status.EmojisPopulated() {
|
|
|
|
|
// Status emojis are out-of-date with IDs, repopulate.
|
|
|
|
|
status.Emojis, err = s.state.DB.GetEmojisByIDs(
|
2024-12-05 13:35:07 +00:00
|
|
|
gtscontext.SetBarebones(ctx),
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 14:03:14 +01:00
|
|
|
status.EmojiIDs,
|
|
|
|
|
)
|
2022-11-18 17:28:33 +00:00
|
|
|
if err != nil {
|
2023-08-02 17:21:46 +02:00
|
|
|
errs.Appendf("error populating status emojis: %w", err)
|
2022-11-18 17:28:33 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-08-10 15:08:41 +01:00
|
|
|
if status.CreatedWithApplicationID != "" && status.CreatedWithApplication == nil {
|
|
|
|
|
// Populate the status' expected CreatedWithApplication (not always set).
|
2025-03-17 15:06:17 +01:00
|
|
|
// Don't error on ErrNoEntries, as the application may have been cleaned up.
|
2023-08-10 15:08:41 +01:00
|
|
|
status.CreatedWithApplication, err = s.state.DB.GetApplicationByID(
|
2024-12-05 13:35:07 +00:00
|
|
|
gtscontext.SetBarebones(ctx),
|
2023-08-10 15:08:41 +01:00
|
|
|
status.CreatedWithApplicationID,
|
|
|
|
|
)
|
2025-03-17 15:06:17 +01:00
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
2023-08-10 15:08:41 +01:00
|
|
|
errs.Appendf("error populating status application: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
return errs.Combine()
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2024-12-23 17:54:44 +00:00
|
|
|
func (s *statusDB) PopulateStatusEdits(ctx context.Context, status *gtsmodel.Status) error {
|
|
|
|
|
var err error
|
|
|
|
|
|
|
|
|
|
if !status.EditsPopulated() {
|
|
|
|
|
// Status edits are out-of-date with IDs, repopulate.
|
|
|
|
|
status.Edits, err = s.state.DB.GetStatusEditsByIDs(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
status.EditIDs,
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return gtserror.Newf("error populating status edits: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
2023-07-25 09:34:05 +01:00
|
|
|
func (s *statusDB) PutStatus(ctx context.Context, status *gtsmodel.Status) error {
|
2024-07-24 09:41:43 +01:00
|
|
|
return s.state.Caches.DB.Status.Store(status, func() error {
|
2022-11-15 18:45:15 +00:00
|
|
|
// It is safe to run this database transaction within cache.Store
|
|
|
|
|
// as the cache does not attempt a mutex lock until AFTER hook.
|
|
|
|
|
//
|
2024-02-07 14:43:27 +00:00
|
|
|
return s.db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error {
|
2025-05-26 15:33:42 +02:00
|
|
|
if status.BoostOfID != "" {
|
|
|
|
|
var threadID string
|
|
|
|
|
|
|
|
|
|
// Boost wrappers always inherit thread
|
|
|
|
|
// of the origin status they're boosting.
|
|
|
|
|
if err := tx.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Table("statuses").
|
|
|
|
|
Column("thread_id").
|
|
|
|
|
Where("? = ?", bun.Ident("id"), status.BoostOfID).
|
|
|
|
|
Scan(ctx, &threadID); err != nil {
|
|
|
|
|
return gtserror.Newf("error selecting boosted status: %w", err)
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2025-05-26 15:33:42 +02:00
|
|
|
|
|
|
|
|
// Set the selected thread.
|
|
|
|
|
status.ThreadID = threadID
|
|
|
|
|
|
|
|
|
|
// They also require no further
|
|
|
|
|
// checks! Simply insert status here.
|
|
|
|
|
return insertStatus(ctx, tx, status)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2025-05-26 15:33:42 +02:00
|
|
|
// Gather a list of possible thread IDs
|
|
|
|
|
// of all the possible related statuses
|
|
|
|
|
// to this one. If one exists we can use
|
|
|
|
|
// the end result, and if too many exist
|
|
|
|
|
// we can fix the status threading.
|
|
|
|
|
var threadIDs []string
|
|
|
|
|
|
|
|
|
|
if status.InReplyToID != "" {
|
|
|
|
|
var threadID string
|
|
|
|
|
|
|
|
|
|
// A stored parent status exists,
|
|
|
|
|
// select its thread ID to ideally
|
|
|
|
|
// inherit this for status.
|
|
|
|
|
if err := tx.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Table("statuses").
|
|
|
|
|
Column("thread_id").
|
|
|
|
|
Where("? = ?", bun.Ident("id"), status.InReplyToID).
|
|
|
|
|
Scan(ctx, &threadID); err != nil {
|
|
|
|
|
return gtserror.Newf("error selecting status parent: %w", err)
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2025-05-26 15:33:42 +02:00
|
|
|
|
|
|
|
|
// Append possible ID to threads slice.
|
|
|
|
|
threadIDs = append(threadIDs, threadID)
|
|
|
|
|
|
|
|
|
|
} else if status.InReplyToURI != "" {
|
|
|
|
|
var ids []string
|
|
|
|
|
|
|
|
|
|
// A parent status exists but is not
|
|
|
|
|
// yet stored. See if any siblings for
|
|
|
|
|
// this shared parent exist with their
|
|
|
|
|
// own thread IDs.
|
|
|
|
|
if err := tx.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Table("statuses").
|
|
|
|
|
Column("thread_id").
|
|
|
|
|
Where("? = ?", bun.Ident("in_reply_to_uri"), status.InReplyToURI).
|
|
|
|
|
Scan(ctx, &ids); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return gtserror.Newf("error selecting status siblings: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Append possible IDs to threads slice.
|
|
|
|
|
threadIDs = append(threadIDs, ids...)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2025-05-26 15:33:42 +02:00
|
|
|
if !*status.Local {
|
|
|
|
|
var ids []string
|
|
|
|
|
|
|
|
|
|
// For remote statuses specifically, check to
|
|
|
|
|
// see if any children are stored for this new
|
|
|
|
|
// stored parent with their own thread IDs.
|
|
|
|
|
if err := tx.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Table("statuses").
|
|
|
|
|
Column("thread_id").
|
|
|
|
|
Where("? = ?", bun.Ident("in_reply_to_uri"), status.URI).
|
|
|
|
|
Scan(ctx, &ids); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return gtserror.Newf("error selecting status children: %w", err)
|
2022-10-08 13:50:48 +02:00
|
|
|
}
|
2025-05-26 15:33:42 +02:00
|
|
|
|
|
|
|
|
// Append possible IDs to threads slice.
|
|
|
|
|
threadIDs = append(threadIDs, ids...)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2025-05-26 15:33:42 +02:00
|
|
|
// Ensure only *unique* posssible thread IDs.
|
|
|
|
|
threadIDs = xslices.Deduplicate(threadIDs)
|
|
|
|
|
switch len(threadIDs) {
|
|
|
|
|
|
|
|
|
|
case 0:
|
|
|
|
|
// No related status with thread ID already exists,
|
|
|
|
|
// so create new thread ID from status creation time.
|
|
|
|
|
threadID := id.NewULIDFromTime(status.CreatedAt)
|
|
|
|
|
|
|
|
|
|
// Insert new thread.
|
2023-10-25 16:04:53 +02:00
|
|
|
if _, err := tx.
|
|
|
|
|
NewInsert().
|
2025-05-26 15:33:42 +02:00
|
|
|
Model(>smodel.Thread{ID: threadID}).
|
2023-10-25 16:04:53 +02:00
|
|
|
Exec(ctx); err != nil {
|
2025-05-26 15:33:42 +02:00
|
|
|
return gtserror.Newf("error inserting thread: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Update status thread ID.
|
|
|
|
|
status.ThreadID = threadID
|
|
|
|
|
|
|
|
|
|
case 1:
|
|
|
|
|
// Inherit single known thread.
|
|
|
|
|
status.ThreadID = threadIDs[0]
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
var err error
|
|
|
|
|
log.Infof(ctx, "reconciling status threading for %s: [%s]", status.URI, strings.Join(threadIDs, ","))
|
|
|
|
|
status.ThreadID, err = s.fixStatusThreading(ctx, tx, threadIDs)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return err
|
2023-10-25 16:04:53 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2025-05-26 15:33:42 +02:00
|
|
|
// And after threading, insert status.
|
|
|
|
|
// This will error if ThreadID is unset.
|
|
|
|
|
return insertStatus(ctx, tx, status)
|
2022-11-15 18:45:15 +00:00
|
|
|
})
|
2021-09-01 10:08:21 +01:00
|
|
|
})
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2025-05-26 15:33:42 +02:00
|
|
|
// fixStatusThreading can be called to reconcile statuses in the same thread but known to be using multiple given threads.
|
|
|
|
|
func (s *statusDB) fixStatusThreading(ctx context.Context, tx bun.Tx, threadIDs []string) (string, error) {
|
|
|
|
|
if len(threadIDs) <= 1 {
|
|
|
|
|
panic("invalid call to fixStatusThreading()")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Sort ascending, i.e.
|
|
|
|
|
// oldest thread ID first.
|
|
|
|
|
slices.Sort(threadIDs)
|
|
|
|
|
|
|
|
|
|
// Drop the oldest thread ID
|
|
|
|
|
// from slice, we'll keep this.
|
|
|
|
|
threadID := threadIDs[0]
|
|
|
|
|
threadIDs = threadIDs[1:]
|
|
|
|
|
|
|
|
|
|
// On updates, gather IDs of changed model
|
|
|
|
|
// IDs for later stage of cache invalidation,
|
|
|
|
|
// preallocating slices for worst-case scenarios.
|
|
|
|
|
statusIDs := make([]string, 0, 4*len(threadIDs))
|
|
|
|
|
muteIDs := make([]string, 0, 4*len(threadIDs))
|
|
|
|
|
|
|
|
|
|
// Update all statuses with
|
|
|
|
|
// thread IDs to use oldest.
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewUpdate().
|
|
|
|
|
Table("statuses").
|
|
|
|
|
Where("? IN (?)", bun.Ident("thread_id"), bun.In(threadIDs)).
|
|
|
|
|
Set("? = ?", bun.Ident("thread_id"), threadID).
|
|
|
|
|
Returning("?", bun.Ident("id")).
|
|
|
|
|
Exec(ctx, &statusIDs); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return "", gtserror.Newf("error updating statuses: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Update all thread mutes with
|
|
|
|
|
// thread IDs to use oldest.
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewUpdate().
|
|
|
|
|
Table("thread_mutes").
|
|
|
|
|
Where("? IN (?)", bun.Ident("thread_id"), bun.In(threadIDs)).
|
|
|
|
|
Set("? = ?", bun.Ident("thread_id"), threadID).
|
|
|
|
|
Returning("?", bun.Ident("id")).
|
|
|
|
|
Exec(ctx, &muteIDs); err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return "", gtserror.Newf("error updating thread mutes: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Delete all now
|
|
|
|
|
// unused thread IDs.
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewDelete().
|
|
|
|
|
Table("threads").
|
|
|
|
|
Where("? IN (?)", bun.Ident("id"), bun.In(threadIDs)).
|
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
|
return "", gtserror.Newf("error deleting threads: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Invalidate caches for changed statuses and mutes.
|
|
|
|
|
s.state.Caches.DB.Status.InvalidateIDs("ID", statusIDs)
|
|
|
|
|
s.state.Caches.DB.ThreadMute.InvalidateIDs("ID", muteIDs)
|
|
|
|
|
|
|
|
|
|
return threadID, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// insertStatus handles the base status insert logic, that is the status itself,
|
|
|
|
|
// any intermediary table links, and updating media attachments to point to status.
|
|
|
|
|
func insertStatus(ctx context.Context, tx bun.Tx, status *gtsmodel.Status) error {
|
|
|
|
|
|
|
|
|
|
// create links between this
|
|
|
|
|
// status and any emojis it uses
|
|
|
|
|
for _, id := range status.EmojiIDs {
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewInsert().
|
|
|
|
|
Model(>smodel.StatusToEmoji{
|
|
|
|
|
StatusID: status.ID,
|
|
|
|
|
EmojiID: id,
|
|
|
|
|
}).
|
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
|
return gtserror.Newf("error inserting status_to_emoji: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// create links between this
|
|
|
|
|
// status and any tags it uses
|
|
|
|
|
for _, id := range status.TagIDs {
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewInsert().
|
|
|
|
|
Model(>smodel.StatusToTag{
|
|
|
|
|
StatusID: status.ID,
|
|
|
|
|
TagID: id,
|
|
|
|
|
}).
|
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
|
return gtserror.Newf("error inserting status_to_tag: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// change the status ID of the media
|
|
|
|
|
// attachments to the current status
|
|
|
|
|
for _, a := range status.Attachments {
|
|
|
|
|
a.StatusID = status.ID
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewUpdate().
|
|
|
|
|
Model(a).
|
|
|
|
|
Column("status_id").
|
|
|
|
|
Where("? = ?", bun.Ident("media_attachment.id"), a.ID).
|
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
|
return gtserror.Newf("error updating media: %w", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Finally, insert the status
|
|
|
|
|
if _, err := tx.NewInsert().
|
|
|
|
|
Model(status).
|
|
|
|
|
Exec(ctx); err != nil {
|
|
|
|
|
return gtserror.Newf("error inserting status: %w", err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
2023-07-25 09:34:05 +01:00
|
|
|
func (s *statusDB) UpdateStatus(ctx context.Context, status *gtsmodel.Status, columns ...string) error {
|
2024-07-24 09:41:43 +01:00
|
|
|
return s.state.Caches.DB.Status.Store(status, func() error {
|
2023-05-12 10:15:54 +01:00
|
|
|
// It is safe to run this database transaction within cache.Store
|
|
|
|
|
// as the cache does not attempt a mutex lock until AFTER hook.
|
|
|
|
|
//
|
2024-02-07 14:43:27 +00:00
|
|
|
return s.db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error {
|
2025-05-26 15:33:42 +02:00
|
|
|
|
|
|
|
|
// create links between this
|
|
|
|
|
// status and any emojis it uses
|
|
|
|
|
for _, id := range status.EmojiIDs {
|
2023-05-12 10:15:54 +01:00
|
|
|
if _, err := tx.
|
|
|
|
|
NewInsert().
|
|
|
|
|
Model(>smodel.StatusToEmoji{
|
|
|
|
|
StatusID: status.ID,
|
2025-05-26 15:33:42 +02:00
|
|
|
EmojiID: id,
|
2023-05-12 10:15:54 +01:00
|
|
|
}).
|
|
|
|
|
On("CONFLICT (?, ?) DO NOTHING", bun.Ident("status_id"), bun.Ident("emoji_id")).
|
|
|
|
|
Exec(ctx); err != nil {
|
2025-05-26 15:33:42 +02:00
|
|
|
return err
|
2022-09-12 13:03:23 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2025-05-26 15:33:42 +02:00
|
|
|
// create links between this
|
|
|
|
|
// status and any tags it uses
|
|
|
|
|
for _, id := range status.TagIDs {
|
2023-05-12 10:15:54 +01:00
|
|
|
if _, err := tx.
|
|
|
|
|
NewInsert().
|
|
|
|
|
Model(>smodel.StatusToTag{
|
|
|
|
|
StatusID: status.ID,
|
2025-05-26 15:33:42 +02:00
|
|
|
TagID: id,
|
2023-05-12 10:15:54 +01:00
|
|
|
}).
|
|
|
|
|
On("CONFLICT (?, ?) DO NOTHING", bun.Ident("status_id"), bun.Ident("tag_id")).
|
|
|
|
|
Exec(ctx); err != nil {
|
2025-05-26 15:33:42 +02:00
|
|
|
return err
|
2022-09-12 13:03:23 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2024-12-05 13:35:07 +00:00
|
|
|
// change the status ID of the media
|
|
|
|
|
// attachments to the current status.
|
2023-05-12 10:15:54 +01:00
|
|
|
for _, a := range status.Attachments {
|
|
|
|
|
a.StatusID = status.ID
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewUpdate().
|
|
|
|
|
Model(a).
|
2024-12-05 13:35:07 +00:00
|
|
|
Column("status_id").
|
2023-05-12 10:15:54 +01:00
|
|
|
Where("? = ?", bun.Ident("media_attachment.id"), a.ID).
|
|
|
|
|
Exec(ctx); err != nil {
|
2025-05-26 15:33:42 +02:00
|
|
|
return err
|
2023-10-25 16:04:53 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2023-05-12 10:15:54 +01:00
|
|
|
// Finally, update the status
|
2024-12-05 13:35:07 +00:00
|
|
|
_, err := tx.NewUpdate().
|
2023-05-12 10:15:54 +01:00
|
|
|
Model(status).
|
|
|
|
|
Column(columns...).
|
|
|
|
|
Where("? = ?", bun.Ident("status.id"), status.ID).
|
|
|
|
|
Exec(ctx)
|
|
|
|
|
return err
|
|
|
|
|
})
|
|
|
|
|
})
|
|
|
|
|
}
|
2022-09-12 13:03:23 +02:00
|
|
|
|
2023-07-25 09:34:05 +01:00
|
|
|
func (s *statusDB) DeleteStatusByID(ctx context.Context, id string) error {
|
2024-09-16 16:46:09 +00:00
|
|
|
// Gather necessary fields from
|
|
|
|
|
// deleted for cache invaliation.
|
|
|
|
|
var deleted gtsmodel.Status
|
|
|
|
|
deleted.ID = id
|
2023-03-03 23:02:23 +00:00
|
|
|
|
2024-09-16 16:46:09 +00:00
|
|
|
// Delete status from database and any related links in a transaction.
|
|
|
|
|
if err := s.db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error {
|
2025-05-26 15:33:42 +02:00
|
|
|
|
|
|
|
|
// delete links between this
|
|
|
|
|
// status and any emojis it uses
|
2022-09-21 19:55:52 +02:00
|
|
|
if _, err := tx.
|
|
|
|
|
NewDelete().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("status_to_emojis"), bun.Ident("status_to_emoji")).
|
|
|
|
|
Where("? = ?", bun.Ident("status_to_emoji.status_id"), id).
|
2022-09-21 19:55:52 +02:00
|
|
|
Exec(ctx); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
2025-05-26 15:33:42 +02:00
|
|
|
// delete links between this
|
|
|
|
|
// status and any tags it uses
|
2022-09-21 19:55:52 +02:00
|
|
|
if _, err := tx.
|
|
|
|
|
NewDelete().
|
2022-10-08 13:50:48 +02:00
|
|
|
TableExpr("? AS ?", bun.Ident("status_to_tags"), bun.Ident("status_to_tag")).
|
|
|
|
|
Where("? = ?", bun.Ident("status_to_tag.status_id"), id).
|
2022-09-21 19:55:52 +02:00
|
|
|
Exec(ctx); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// delete the status itself
|
|
|
|
|
if _, err := tx.
|
|
|
|
|
NewDelete().
|
2024-09-16 16:46:09 +00:00
|
|
|
Model(&deleted).
|
|
|
|
|
Where("? = ?", bun.Ident("id"), id).
|
|
|
|
|
Returning("?, ?, ?, ?, ?",
|
|
|
|
|
bun.Ident("account_id"),
|
|
|
|
|
bun.Ident("boost_of_id"),
|
|
|
|
|
bun.Ident("in_reply_to_id"),
|
|
|
|
|
bun.Ident("attachments"),
|
|
|
|
|
bun.Ident("poll_id"),
|
|
|
|
|
).
|
|
|
|
|
Exec(ctx); err != nil &&
|
|
|
|
|
!errors.Is(err, db.ErrNoEntries) {
|
2022-09-21 19:55:52 +02:00
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return nil
|
2024-09-16 16:46:09 +00:00
|
|
|
}); err != nil {
|
|
|
|
|
return err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Invalidate cached status by its ID, manually
|
|
|
|
|
// call the invalidate hook in case not cached.
|
|
|
|
|
s.state.Caches.DB.Status.Invalidate("ID", id)
|
|
|
|
|
s.state.Caches.OnInvalidateStatus(&deleted)
|
|
|
|
|
|
|
|
|
|
return nil
|
2022-09-21 19:55:52 +02:00
|
|
|
}
|
|
|
|
|
|
2023-07-24 13:14:13 +01:00
|
|
|
func (s *statusDB) GetStatusesUsingEmoji(ctx context.Context, emojiID string) ([]*gtsmodel.Status, error) {
|
|
|
|
|
var statusIDs []string
|
|
|
|
|
|
2023-08-02 15:11:23 +01:00
|
|
|
// SELECT all statuses using this emoji,
|
|
|
|
|
// using a relational table for improved perf.
|
|
|
|
|
if _, err := s.db.NewSelect().
|
|
|
|
|
Table("status_to_emojis").
|
|
|
|
|
Column("status_id").
|
|
|
|
|
Where("? = ?", bun.Ident("emoji_id"), emojiID).
|
|
|
|
|
Exec(ctx, &statusIDs); err != nil {
|
2023-08-17 17:26:21 +01:00
|
|
|
return nil, err
|
2023-07-24 13:14:13 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Convert status IDs into status objects.
|
|
|
|
|
return s.GetStatusesByIDs(ctx, statusIDs)
|
|
|
|
|
}
|
|
|
|
|
|
2023-11-20 12:22:28 +00:00
|
|
|
func (s *statusDB) GetStatusParents(ctx context.Context, status *gtsmodel.Status) ([]*gtsmodel.Status, error) {
|
2022-11-15 18:45:15 +00:00
|
|
|
var parents []*gtsmodel.Status
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2022-11-15 18:45:15 +00:00
|
|
|
for id := status.InReplyToID; id != ""; {
|
|
|
|
|
parent, err := s.GetStatusByID(ctx, id)
|
2024-07-10 06:38:25 -07:00
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
2022-11-15 18:45:15 +00:00
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
2024-07-10 06:38:25 -07:00
|
|
|
if parent == nil {
|
|
|
|
|
// Parent status not found (e.g. deleted)
|
|
|
|
|
break
|
|
|
|
|
}
|
|
|
|
|
|
2023-11-20 12:22:28 +00:00
|
|
|
// Append parent status to slice
|
2022-11-15 18:45:15 +00:00
|
|
|
parents = append(parents, parent)
|
|
|
|
|
|
|
|
|
|
// Set the next parent ID
|
|
|
|
|
id = parent.InReplyToID
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2022-11-15 18:45:15 +00:00
|
|
|
return parents, nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-11-20 12:22:28 +00:00
|
|
|
func (s *statusDB) GetStatusChildren(ctx context.Context, statusID string) ([]*gtsmodel.Status, error) {
|
|
|
|
|
// Get all replies for the currently set status.
|
|
|
|
|
replies, err := s.GetStatusReplies(ctx, statusID)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-11-20 12:22:28 +00:00
|
|
|
// Make estimated preallocation based on direct replies.
|
|
|
|
|
children := make([]*gtsmodel.Status, 0, len(replies)*2)
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2023-11-20 12:22:28 +00:00
|
|
|
for _, status := range replies {
|
|
|
|
|
// Append status to children.
|
|
|
|
|
children = append(children, status)
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2023-11-20 12:22:28 +00:00
|
|
|
// Further, recursively get all children for this reply.
|
|
|
|
|
grandChildren, err := s.GetStatusChildren(ctx, status.ID)
|
2022-07-10 16:18:21 +01:00
|
|
|
if err != nil {
|
2023-11-20 12:22:28 +00:00
|
|
|
return nil, err
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-11-20 12:22:28 +00:00
|
|
|
// Append all sub children after status.
|
|
|
|
|
children = append(children, grandChildren...)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
2023-11-20 12:22:28 +00:00
|
|
|
|
|
|
|
|
return children, nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) GetStatusReplies(ctx context.Context, statusID string) ([]*gtsmodel.Status, error) {
|
|
|
|
|
statusIDs, err := s.getStatusReplyIDs(ctx, statusID)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
return s.GetStatusesByIDs(ctx, statusIDs)
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) CountStatusReplies(ctx context.Context, statusID string) (int, error) {
|
|
|
|
|
statusIDs, err := s.getStatusReplyIDs(ctx, statusID)
|
|
|
|
|
return len(statusIDs), err
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) getStatusReplyIDs(ctx context.Context, statusID string) ([]string, error) {
|
2024-07-24 09:41:43 +01:00
|
|
|
return s.state.Caches.DB.InReplyToIDs.Load(statusID, func() ([]string, error) {
|
2023-08-04 12:28:33 +01:00
|
|
|
var statusIDs []string
|
|
|
|
|
|
|
|
|
|
// Status reply IDs not in cache, perform DB query!
|
|
|
|
|
if err := s.db.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Table("statuses").
|
|
|
|
|
Column("id").
|
|
|
|
|
Where("? = ?", bun.Ident("in_reply_to_id"), statusID).
|
|
|
|
|
Order("id DESC").
|
|
|
|
|
Scan(ctx, &statusIDs); err != nil {
|
2023-08-17 17:26:21 +01:00
|
|
|
return nil, err
|
2023-08-04 12:28:33 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return statusIDs, nil
|
|
|
|
|
})
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) GetStatusBoosts(ctx context.Context, statusID string) ([]*gtsmodel.Status, error) {
|
|
|
|
|
statusIDs, err := s.getStatusBoostIDs(ctx, statusID)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
return s.GetStatusesByIDs(ctx, statusIDs)
|
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) IsStatusBoostedBy(ctx context.Context, statusID string, accountID string) (bool, error) {
|
|
|
|
|
boost, err := s.GetStatusBoost(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
statusID,
|
|
|
|
|
accountID,
|
|
|
|
|
)
|
|
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return false, err
|
|
|
|
|
}
|
|
|
|
|
return (boost != nil), nil
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
|
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) CountStatusBoosts(ctx context.Context, statusID string) (int, error) {
|
|
|
|
|
statusIDs, err := s.getStatusBoostIDs(ctx, statusID)
|
|
|
|
|
return len(statusIDs), err
|
|
|
|
|
}
|
2021-08-25 15:34:33 +02:00
|
|
|
|
2023-08-04 12:28:33 +01:00
|
|
|
func (s *statusDB) getStatusBoostIDs(ctx context.Context, statusID string) ([]string, error) {
|
2024-07-24 09:41:43 +01:00
|
|
|
return s.state.Caches.DB.BoostOfIDs.Load(statusID, func() ([]string, error) {
|
2023-08-04 12:28:33 +01:00
|
|
|
var statusIDs []string
|
|
|
|
|
|
|
|
|
|
// Status boost IDs not in cache, perform DB query!
|
|
|
|
|
if err := s.db.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Table("statuses").
|
|
|
|
|
Column("id").
|
|
|
|
|
Where("? = ?", bun.Ident("boost_of_id"), statusID).
|
|
|
|
|
Order("id DESC").
|
|
|
|
|
Scan(ctx, &statusIDs); err != nil {
|
2023-08-17 17:26:21 +01:00
|
|
|
return nil, err
|
2023-08-04 12:28:33 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return statusIDs, nil
|
|
|
|
|
})
|
2021-08-25 15:34:33 +02:00
|
|
|
}
|
2024-07-23 12:44:31 -07:00
|
|
|
|
|
|
|
|
func (s *statusDB) MaxDirectStatusID(ctx context.Context) (string, error) {
|
|
|
|
|
maxID := ""
|
|
|
|
|
if err := s.db.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Model((*gtsmodel.Status)(nil)).
|
|
|
|
|
ColumnExpr("COALESCE(MAX(?), '')", bun.Ident("id")).
|
|
|
|
|
Where("? = ?", bun.Ident("visibility"), gtsmodel.VisibilityDirect).
|
|
|
|
|
Scan(ctx, &maxID); // nocollapse
|
|
|
|
|
err != nil {
|
|
|
|
|
return "", err
|
|
|
|
|
}
|
|
|
|
|
return maxID, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (s *statusDB) GetDirectStatusIDsBatch(ctx context.Context, minID string, maxIDInclusive string, count int) ([]string, error) {
|
|
|
|
|
var statusIDs []string
|
|
|
|
|
if err := s.db.
|
|
|
|
|
NewSelect().
|
|
|
|
|
Model((*gtsmodel.Status)(nil)).
|
|
|
|
|
Column("id").
|
|
|
|
|
Where("? = ?", bun.Ident("visibility"), gtsmodel.VisibilityDirect).
|
|
|
|
|
Where("? > ?", bun.Ident("id"), minID).
|
|
|
|
|
Where("? <= ?", bun.Ident("id"), maxIDInclusive).
|
|
|
|
|
Order("id ASC").
|
|
|
|
|
Limit(count).
|
|
|
|
|
Scan(ctx, &statusIDs); // nocollapse
|
|
|
|
|
err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
return statusIDs, nil
|
|
|
|
|
}
|
2025-05-11 13:38:13 +00:00
|
|
|
|
|
|
|
|
func (s *statusDB) GetStatusInteractions(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
statusID string,
|
|
|
|
|
localOnly bool,
|
|
|
|
|
) ([]gtsmodel.Interaction, error) {
|
|
|
|
|
// Prepare to get interactions.
|
|
|
|
|
interactions := []gtsmodel.Interaction{}
|
|
|
|
|
|
|
|
|
|
// Gather faves.
|
|
|
|
|
faves, err := s.state.DB.GetStatusFaves(ctx, statusID)
|
|
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for _, fave := range faves {
|
|
|
|
|
// Get account at least.
|
|
|
|
|
if fave.Account == nil {
|
|
|
|
|
fave.Account, err = s.state.DB.GetAccountByID(ctx, fave.AccountID)
|
|
|
|
|
if err != nil {
|
|
|
|
|
log.Errorf(ctx, "error getting account for fave: %v", err)
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if localOnly && !fave.Account.IsLocal() {
|
|
|
|
|
// Skip not local.
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
interactions = append(interactions, fave)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Gather replies.
|
|
|
|
|
replies, err := s.state.DB.GetStatusReplies(ctx, statusID)
|
|
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for _, reply := range replies {
|
|
|
|
|
// Get account at least.
|
|
|
|
|
if reply.Account == nil {
|
|
|
|
|
reply.Account, err = s.state.DB.GetAccountByID(ctx, reply.AccountID)
|
|
|
|
|
if err != nil {
|
|
|
|
|
log.Errorf(ctx, "error getting account for reply: %v", err)
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if localOnly && !reply.Account.IsLocal() {
|
|
|
|
|
// Skip not local.
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
interactions = append(interactions, reply)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Gather boosts.
|
|
|
|
|
boosts, err := s.state.DB.GetStatusBoosts(ctx, statusID)
|
|
|
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for _, boost := range boosts {
|
|
|
|
|
// Get account at least.
|
|
|
|
|
if boost.Account == nil {
|
|
|
|
|
boost.Account, err = s.state.DB.GetAccountByID(ctx, boost.AccountID)
|
|
|
|
|
if err != nil {
|
|
|
|
|
log.Errorf(ctx, "error getting account for boost: %v", err)
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if localOnly && !boost.Account.IsLocal() {
|
|
|
|
|
// Skip not local.
|
|
|
|
|
continue
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
interactions = append(interactions, boost)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if len(interactions) == 0 {
|
|
|
|
|
return nil, db.ErrNoEntries
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return interactions, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (s *statusDB) GetStatusByEditID(
|
|
|
|
|
ctx context.Context,
|
|
|
|
|
editID string,
|
|
|
|
|
) (*gtsmodel.Status, error) {
|
|
|
|
|
edit, err := s.state.DB.GetStatusEditByID(
|
|
|
|
|
gtscontext.SetBarebones(ctx),
|
|
|
|
|
editID,
|
|
|
|
|
)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return nil, err
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return s.GetStatusByID(ctx, edit.StatusID)
|
|
|
|
|
}
|