mirrors/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-12-29 16:06:16 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix catching wrong error... add code comments

Browse source 
Signed-off-by: kim (grufwub) <grufwub@gmail.com>
This commit is contained in:
kim (grufwub) 2021-08-26 16:08:40 +01:00
commit 1a828727c2
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/db/bundb/conn.go
View file

@ -8,11 +8,14 @@ import (
"github.com/uptrace/bun"
)
// dbConn wrapps a bun.DB conn to provide SQL-type specific additional functionality
type dbConn struct {
errProc func(error) db.Error // errProc is the SQL-type specific error processor
*bun.DB // DB is the underlying bun.DB connection
}
// ProcessError processes an error to replace any known values with our own db.Error types,
// making it easier to catch specific situations (e.g. no rows, already exists, etc)
func (conn *dbConn) ProcessError(err error) db.Error {
switch {
case err == nil:
@ -24,19 +27,21 @@ func (conn *dbConn) ProcessError(err error) db.Error {
}
}
// Exists checks the results of a SelectQuery for the existence of the data in question, masking ErrNoEntries errors
func (conn *dbConn) Exists(ctx context.Context, query *bun.SelectQuery) (bool, db.Error) {
// Get the select query result
count, err := query.Count(ctx)
// Process error as our own and check if it exists
switch err := conn.ProcessError(err); err {
case nil, db.ErrAlreadyExists:
case nil, db.ErrNoEntries:
return (count != 0), nil
default:
return false, err
}
}
// NotExists is the functional opposite of conn.Exists()
func (conn *dbConn) NotExists(ctx context.Context, query *bun.SelectQuery) (bool, db.Error) {
// Simply inverse of conn.exists()
exists, err := conn.Exists(ctx, query)