[chore/performance] Avoid unnecessary "uncached" queries (#3265)

* [chore/performance] Avoid unnecessary "uncached" queries

* go fmt
This commit is contained in:
tobi 2024-09-02 14:00:17 +02:00 committed by GitHub
commit 25a815a8a4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 149 additions and 21 deletions

View file

@ -133,8 +133,15 @@ func (s *statusFaveDB) GetStatusFaves(ctx context.Context, statusID string) ([]*
faves, err := s.state.Caches.DB.StatusFave.LoadIDs("ID",
faveIDs,
func(uncached []string) ([]*gtsmodel.StatusFave, error) {
// Avoid querying
// if none uncached.
count := len(uncached)
if count == 0 {
return nil, nil
}
// Preallocate expected length of uncached faves.
faves := make([]*gtsmodel.StatusFave, 0, len(uncached))
faves := make([]*gtsmodel.StatusFave, 0, count)
// Perform database query scanning
// the remaining (uncached) fave IDs.