mirrors/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-10-29 12:52:27 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[chore] various federatingdb tweaks (#4178)

Browse source 
after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller

frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
This commit is contained in:
kim 2025-05-15 09:40:48 +00:00 • committed by kim
commit 3cff4b2d7d
31 changed files with 156 additions and 160 deletions
Download patch file Download diff file Expand all files Collapse all files

15
internal/federation/federatingdb/undo.go
View file

@ -32,7 +32,7 @@ import (
"code.superseriousbusiness.org/gotosocial/internal/messages"
)
func (f *federatingDB) Undo(ctx context.Context, undo vocab.ActivityStreamsUndo) error {
func (f *DB) Undo(ctx context.Context, undo vocab.ActivityStreamsUndo) error {
log.DebugKV(ctx, "undo", serialize{undo})
activityContext := getActivityContext(ctx)
@ -111,7 +111,7 @@ func (f *federatingDB) Undo(ctx context.Context, undo vocab.ActivityStreamsUndo)
return nil
}
func (f *federatingDB) undoFollow(
func (f *DB) undoFollow(
ctx context.Context,
receivingAcct *gtsmodel.Account,
requestingAcct *gtsmodel.Account,
@ -149,11 +149,6 @@ func (f *federatingDB) undoFollow(
return nil
}
// Lock on the Follow URI
// as we may be updating it.
unlock := f.state.FedLocks.Lock(follow.URI)
defer unlock()
// Ensure addressee is follow target.
if follow.TargetAccountID != receivingAcct.ID {
const text = "receivingAcct was not Follow target"
@ -193,7 +188,7 @@ func (f *federatingDB) undoFollow(
return nil
}
func (f *federatingDB) undoLike(
func (f *DB) undoLike(
ctx context.Context,
receivingAcct *gtsmodel.Account,
requestingAcct *gtsmodel.Account,
@ -293,7 +288,7 @@ func (f *federatingDB) undoLike(
return nil
}
func (f *federatingDB) undoBlock(
func (f *DB) undoBlock(
ctx context.Context,
receivingAcct *gtsmodel.Account,
requestingAcct *gtsmodel.Account,
@ -363,7 +358,7 @@ func (f *federatingDB) undoBlock(
return nil
}
func (f *federatingDB) undoAnnounce(
func (f *DB) undoAnnounce(
ctx context.Context,
receivingAcct *gtsmodel.Account,
requestingAcct *gtsmodel.Account,