From 4632678636038fa34e5f88d6ebf95cf6816df1c4 Mon Sep 17 00:00:00 2001 From: tobi Date: Mon, 9 Dec 2024 12:46:23 +0100 Subject: [PATCH] [chore] Log during potentially long migrations --- .../migrations/20241113151042_remove_mention_updated_at.go | 2 ++ .../db/bundb/migrations/20241113152126_add_status_edits.go | 2 ++ .../migrations/20241121121623_enum_strings_to_ints.go | 7 +++++++ .../20241203124608_remove_media_attachment_updated_at.go | 2 ++ 4 files changed, 13 insertions(+) diff --git a/internal/db/bundb/migrations/20241113151042_remove_mention_updated_at.go b/internal/db/bundb/migrations/20241113151042_remove_mention_updated_at.go index bd72dc109..ba6e0bd3a 100644 --- a/internal/db/bundb/migrations/20241113151042_remove_mention_updated_at.go +++ b/internal/db/bundb/migrations/20241113151042_remove_mention_updated_at.go @@ -21,6 +21,7 @@ import ( "context" "github.com/superseriousbusiness/gotosocial/internal/gtsmodel" + "github.com/superseriousbusiness/gotosocial/internal/log" "github.com/uptrace/bun" ) @@ -37,6 +38,7 @@ func init() { } // Remove 'updated_at' column. + log.Info(ctx, "removing unused updated_at column from mentions to save space, please wait...") _, err = tx.NewDropColumn(). Model((*gtsmodel.Mention)(nil)). Column("updated_at"). diff --git a/internal/db/bundb/migrations/20241113152126_add_status_edits.go b/internal/db/bundb/migrations/20241113152126_add_status_edits.go index aa0b0d4b9..5d4fb7b3e 100644 --- a/internal/db/bundb/migrations/20241113152126_add_status_edits.go +++ b/internal/db/bundb/migrations/20241113152126_add_status_edits.go @@ -22,6 +22,7 @@ import ( "reflect" gtsmodel "github.com/superseriousbusiness/gotosocial/internal/db/bundb/migrations/20241113152126_add_status_edits" + "github.com/superseriousbusiness/gotosocial/internal/log" "github.com/uptrace/bun" ) @@ -38,6 +39,7 @@ func init() { } // Add EditIDs column to Status table. + log.Info(ctx, "adding edits column to statuses table...") _, err = tx.NewAddColumn(). Model((*gtsmodel.Status)(nil)). ColumnExpr(colDef). diff --git a/internal/db/bundb/migrations/20241121121623_enum_strings_to_ints.go b/internal/db/bundb/migrations/20241121121623_enum_strings_to_ints.go index 7621ddc6c..9ddbd77cd 100644 --- a/internal/db/bundb/migrations/20241121121623_enum_strings_to_ints.go +++ b/internal/db/bundb/migrations/20241121121623_enum_strings_to_ints.go @@ -22,6 +22,7 @@ import ( old_gtsmodel "github.com/superseriousbusiness/gotosocial/internal/db/bundb/migrations/20241121121623_enum_strings_to_ints" new_gtsmodel "github.com/superseriousbusiness/gotosocial/internal/gtsmodel" + "github.com/superseriousbusiness/gotosocial/internal/log" "github.com/superseriousbusiness/gotosocial/internal/util" "github.com/uptrace/bun" @@ -68,7 +69,9 @@ func init() { // Before making changes to the visibility col // we must drop all indices that rely on it. + log.Info(ctx, "dropping old visibility indexes...") for _, index := range visIndices { + log.Info(ctx, "dropping old index %s...", index.name) if _, err := tx.NewDropIndex(). Index(index.name). Exec(ctx); err != nil { @@ -81,6 +84,7 @@ func init() { // Convert all visibility tables. for _, table := range visTables { + log.Info(ctx, "remapping %s.%s to save space, please wait...", table.Table, table.Column) if err := convertEnums(ctx, tx, table.Table, table.Column, visibilityMapping, table.Default); err != nil { return err @@ -88,7 +92,9 @@ func init() { } // Recreate the visibility indices. + log.Info(ctx, "creating new visibility indexes...") for _, index := range visIndices { + log.Info(ctx, "creating new index %s...", index.name) q := tx.NewCreateIndex(). Table("statuses"). Index(index.name). @@ -105,6 +111,7 @@ func init() { notificationMapping := notificationEnumMapping[old_gtsmodel.NotificationType]() // Migrate over old notifications table column over to new column type. + log.Info(ctx, "remapping notifications.notification_type to save space, please wait...") if err := convertEnums(ctx, tx, "notifications", "notification_type", //nolint:revive notificationMapping, nil); err != nil { return err diff --git a/internal/db/bundb/migrations/20241203124608_remove_media_attachment_updated_at.go b/internal/db/bundb/migrations/20241203124608_remove_media_attachment_updated_at.go index 344168b38..63e5d5f90 100644 --- a/internal/db/bundb/migrations/20241203124608_remove_media_attachment_updated_at.go +++ b/internal/db/bundb/migrations/20241203124608_remove_media_attachment_updated_at.go @@ -21,6 +21,7 @@ import ( "context" "github.com/superseriousbusiness/gotosocial/internal/gtsmodel" + "github.com/superseriousbusiness/gotosocial/internal/log" "github.com/uptrace/bun" ) @@ -37,6 +38,7 @@ func init() { } // Remove 'updated_at' column. + log.Info(ctx, "removing unused updated_at column from media attachments to save space, please wait...") _, err = tx.NewDropColumn(). Model((*gtsmodel.MediaAttachment)(nil)). Column("updated_at").