start refactoring return codes from fedi endpoints, remove some cruft

internal/api/activitypub/publickey/publickey.go

@@ -20,17 +20,14 @@ package publickey
 import (
 	"net/http"
 
+	apiutil "code.superseriousbusiness.org/gotosocial/internal/api/util"
+
 	"code.superseriousbusiness.org/gotosocial/internal/processing"
 	"code.superseriousbusiness.org/gotosocial/internal/uris"
 	"github.com/gin-gonic/gin"
 )
 
-const (
-	// UsernameKey is for account usernames.
-	UsernameKey = "username"
-	// PublicKeyPath is a path to a user's public key, for serving bare minimum AP representations.
-	PublicKeyPath = "users/:" + UsernameKey + "/" + uris.PublicKeyPath
-)
+const PublicKeyPath = "users/:" + apiutil.UsernameKey + "/" + uris.PublicKeyPath
 
 type Module struct {
 	processor *processing.Processor

internal/api/activitypub/publickey/publickeyget.go

@@ -34,7 +34,7 @@ import (
 // public key, username, and type of the account.
 func (m *Module) PublicKeyGETHandler(c *gin.Context) {
 	// usernames on our instance are always lowercase
-	requestedUsername := strings.ToLower(c.Param(UsernameKey))
+	requestedUsername := strings.ToLower(c.Param(apiutil.UsernameKey))
 	if requestedUsername == "" {
 		err := errors.New("no username specified in request")
 		apiutil.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGetV1)
@@ -47,13 +47,17 @@ func (m *Module) PublicKeyGETHandler(c *gin.Context) {
 		return
 	}
 
+	// If HTML is requested, redirect
+	// to user's profile instead.
 	if contentType == string(apiutil.TextHTML) {
-		// redirect to the user's profile
 		c.Redirect(http.StatusSeeOther, "/@"+requestedUsername)
 		return
 	}
 
-	resp, errWithCode := m.processor.Fedi().UserGet(c.Request.Context(), requestedUsername, c.Request.URL)
+	resp, errWithCode := m.processor.Fedi().UserGetMinimal(
+		c.Request.Context(),
+		requestedUsername,
+	)
 	if errWithCode != nil {
 		apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1)
 		return