mirrors/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-11-02 03:32:24 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

[bugfix] rename include_types[] to types[] (#3023)

Browse source
This commit is contained in:
tobi 2024-06-18 18:18:35 +02:00 • committed by GitHub
commit 4ce5c37df5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
internal/api/client/notifications/notifications.go
View file

@ -34,8 +34,8 @@ const (
BasePathWithID = BasePath + "/:" + IDKey
BasePathWithClear = BasePath + "/clear"
// IncludeTypesKey names an array param specifying notification types to include.
IncludeTypesKey = "include_types[]"
// TypesKey names an array param specifying notification types to include.
TypesKey = "types[]"
// ExcludeTypesKey names an array param specifying notification types to exclude.
ExcludeTypesKey = "exclude_types[]"
MaxIDKey = "max_id"

2
internal/api/client/notifications/notificationsget.go
View file

@ -171,7 +171,7 @@ func (m *Module) NotificationsGETHandler(c *gin.Context) {
c.Query(SinceIDKey),
c.Query(MinIDKey),
limit,
c.QueryArray(IncludeTypesKey),
c.QueryArray(TypesKey),
c.QueryArray(ExcludeTypesKey),
)
if errWithCode != nil {

18
internal/api/client/notifications/notificationsget_test.go
View file

@ -45,7 +45,7 @@ func (suite *NotificationsTestSuite) getNotifications(
maxID string,
minID string,
limit int,
includeTypes []string,
types []string,
excludeTypes []string,
expectedHTTPStatus int,
expectedBody string,
@ -71,8 +71,8 @@ func (suite *NotificationsTestSuite) getNotifications(
if limit != 0 {
query.Set(notifications.LimitKey, strconv.Itoa(limit))
}
if len(includeTypes) > 0 {
query[notifications.IncludeTypesKey] = includeTypes
if len(types) > 0 {
query[notifications.TypesKey] = types
}
if len(excludeTypes) > 0 {
query[notifications.ExcludeTypesKey] = excludeTypes
@ -123,7 +123,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsSingle() {
maxID := ""
minID := ""
limit := 10
includeTypes := []string(nil)
types := []string(nil)
excludeTypes := []string(nil)
expectedHTTPStatus := http.StatusOK
expectedBody := ""
@ -135,7 +135,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsSingle() {
maxID,
minID,
limit,
includeTypes,
types,
excludeTypes,
expectedHTTPStatus,
expectedBody,
@ -181,7 +181,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsExcludeOneType() {
maxID := ""
minID := ""
limit := 10
includeTypes := []string(nil)
types := []string(nil)
excludeTypes := []string{"follow_request"}
expectedHTTPStatus := http.StatusOK
expectedBody := ""
@ -193,7 +193,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsExcludeOneType() {
maxID,
minID,
limit,
includeTypes,
types,
excludeTypes,
expectedHTTPStatus,
expectedBody,
@ -220,7 +220,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsIncludeOneType() {
maxID := ""
minID := ""
limit := 10
includeTypes := []string{"favourite"}
types := []string{"favourite"}
excludeTypes := []string(nil)
expectedHTTPStatus := http.StatusOK
expectedBody := ""
@ -232,7 +232,7 @@ func (suite *NotificationsTestSuite) TestGetNotificationsIncludeOneType() {
maxID,
minID,
limit,
includeTypes,
types,
excludeTypes,
expectedHTTPStatus,
expectedBody,