mirrors/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-10-30 17:32:24 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[chore/performance] use only 1 sqlite db connection regardless of multiplier (#1408)

Browse source
This commit is contained in:
tobi 2023-02-01 11:55:34 +01:00 • committed by GitHub
commit 4ee4cd2da1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/configuration/database.md
View file

@ -128,6 +128,10 @@ db-tls-ca-cert: ""
# #
# If you set the multiplier to less than 1, only one open connection will be used regardless of cpu count. # If you set the multiplier to less than 1, only one open connection will be used regardless of cpu count.
# #
# PLEASE NOTE!!: This setting currently only applies for Postgres. SQLite will always use 1 connection regardless
# of what is set here. This behavior will change in future when we implement better SQLITE_BUSY handling.
# See https://github.com/superseriousbusiness/gotosocial/issues/1407 for more details.
#
# Examples: [16, 8, 10, 2] # Examples: [16, 8, 10, 2]
# Default: 8 # Default: 8
db-max-open-conns-multiplier: 8 db-max-open-conns-multiplier: 8

4
example/config.yaml
View file

@ -184,6 +184,10 @@ db-tls-ca-cert: ""
# #
# If you set the multiplier to less than 1, only one open connection will be used regardless of cpu count. # If you set the multiplier to less than 1, only one open connection will be used regardless of cpu count.
# #
# PLEASE NOTE!!: This setting currently only applies for Postgres. SQLite will always use 1 connection regardless
# of what is set here. This behavior will change in future when we implement better SQLITE_BUSY handling.
# See https://github.com/superseriousbusiness/gotosocial/issues/1407 for more details.
#
# Examples: [16, 8, 10, 2] # Examples: [16, 8, 10, 2]
# Default: 8 # Default: 8
db-max-open-conns-multiplier: 8 db-max-open-conns-multiplier: 8

2
internal/db/bundb/bundb.go
View file

@ -304,7 +304,7 @@ func sqliteConn(ctx context.Context) (*DBConn, error) {
// Tune db connections for sqlite, see: // Tune db connections for sqlite, see:
// - https://bun.uptrace.dev/guide/running-bun-in-production.html#database-sql // - https://bun.uptrace.dev/guide/running-bun-in-production.html#database-sql
// - https://www.alexedwards.net/blog/configuring-sqldb // - https://www.alexedwards.net/blog/configuring-sqldb
sqldb.SetMaxOpenConns(maxOpenConns()) // x number of conns per cpu sqldb.SetMaxOpenConns(1) // only 1 connection regardless of multiplier, see https://github.com/superseriousbusiness/gotosocial/issues/1407
sqldb.SetMaxIdleConns(1) // only keep max 1 idle connection around sqldb.SetMaxIdleConns(1) // only keep max 1 idle connection around
sqldb.SetConnMaxLifetime(0) // don't kill connections due to age sqldb.SetConnMaxLifetime(0) // don't kill connections due to age