mirrors/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-11-02 13:52:24 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

[chore] chore rationalise http return codes for activitypub handlers (#2540)

Browse source 
* some small code fixups and changes

* add check in ResolveIncomingActivity for transient activity types (i.e. activity ID is nil)

* update test to handle new transient behaviour
This commit is contained in:
kim 2024-01-18 16:11:13 +00:00 • committed by GitHub
commit 67e11a1a61
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 29 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

6
internal/federation/federatingactor.go
View file

@ -143,10 +143,12 @@ func (f *federatingActor) PostInboxScheme(ctx context.Context, w http.ResponseWr
have not yet applied authorization (ie., blocks).
*/
// Obtain the activity; reject unknown activities.
activity, errWithCode := ap.ResolveIncomingActivity(r)
// Resolve the activity, rejecting badly formatted / transient.
activity, ok, errWithCode := ap.ResolveIncomingActivity(r)
if errWithCode != nil {
return false, errWithCode
} else if !ok { // transient
return false, nil
}
// Set additional context data. Primarily this means