From 6b4f12283f50e194ba2aa1107c9115f7e12b4165 Mon Sep 17 00:00:00 2001 From: kim Date: Tue, 3 Dec 2024 13:53:00 +0000 Subject: [PATCH] more test fixing, ensure the edit.status_id field is actually set :facepalm: --- internal/federation/dereferencing/status.go | 1 + internal/federation/dereferencing/status_test.go | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/federation/dereferencing/status.go b/internal/federation/dereferencing/status.go index cf80f1ef6..066a65dea 100644 --- a/internal/federation/dereferencing/status.go +++ b/internal/federation/dereferencing/status.go @@ -937,6 +937,7 @@ func (d *Dereferencer) updateStatus( edit.Sensitive = existing.Sensitive edit.AttachmentIDs = existing.AttachmentIDs edit.Attachments = existing.Attachments + edit.StatusID = status.ID // Edit creation is last update time. edit.CreatedAt = existing.UpdatedAt diff --git a/internal/federation/dereferencing/status_test.go b/internal/federation/dereferencing/status_test.go index 99a7e119f..e1370635b 100644 --- a/internal/federation/dereferencing/status_test.go +++ b/internal/federation/dereferencing/status_test.go @@ -254,7 +254,7 @@ func (suite *StatusTestSuite) TestDereferencerRefreshStatusUpdated() { fetchingAccount.Username, testURI, ) - suite.Equal(testStatusable, statusable) + suite.NotNil(statusable) suite.NoError(err) // Run through multiple possible edits. @@ -302,7 +302,7 @@ func (suite *StatusTestSuite) TestDereferencerRefreshStatusUpdated() { nil, instantFreshness, ) - suite.Equal(testStatusable, statusable) + suite.NotNil(statusable) suite.NoError(err) // verify updated status details. @@ -360,7 +360,7 @@ func (suite *StatusTestSuite) TestDereferencerRefreshStatusReceivedUpdate() { fetchingAccount.Username, testURI, ) - suite.Equal(testStatusable, statusable) + suite.NotNil(statusable) suite.NoError(err) // Run through multiple possible edits. @@ -408,7 +408,7 @@ func (suite *StatusTestSuite) TestDereferencerRefreshStatusReceivedUpdate() { testStatusable, instantFreshness, ) - suite.Equal(testStatusable, statusable) + suite.NotNil(statusable) suite.NoError(err) // verify updated status details.