mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2026-01-04 12:53:16 -06:00
add seperate PunifyValidate() function for properly validating domain names when converting to punycode
This commit is contained in:
parent
8cfae010a9
commit
6c9a3e4a56
9 changed files with 198 additions and 185 deletions
123
internal/util/domain.go
Normal file
123
internal/util/domain.go
Normal file
|
|
@ -0,0 +1,123 @@
|
|||
// GoToSocial
|
||||
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
||||
// SPDX-License-Identifier: AGPL-3.0-or-later
|
||||
//
|
||||
// This program is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU Affero General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// This program is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU Affero General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU Affero General Public License
|
||||
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package util
|
||||
|
||||
import (
|
||||
"net/url"
|
||||
"strings"
|
||||
|
||||
"golang.org/x/net/idna"
|
||||
)
|
||||
|
||||
var (
|
||||
// IDNA (Internationalized Domain Names for Applications)
|
||||
// profiles for fast punycode conv and full verification.
|
||||
punifyProfile = *idna.Punycode
|
||||
verifyProfile = *idna.Lookup
|
||||
)
|
||||
|
||||
// PunifyValidate validates the provided domain name,
|
||||
// and converts unicode chars to ASCII, i.e. punified form.
|
||||
func PunifyValidate(domain string) (string, error) {
|
||||
domain, err := verifyProfile.ToASCII(domain)
|
||||
return strings.ToLower(domain), err
|
||||
}
|
||||
|
||||
// Punify is a faster form of ValidatePunify() without validation.
|
||||
func Punify_(domain string) (string, error) {
|
||||
domain, err := punifyProfile.ToASCII(domain)
|
||||
return strings.ToLower(domain), err
|
||||
}
|
||||
|
||||
// DePunify converts any punycode-encoded unicode characters
|
||||
// in domain name back to their origin unicode. Please note
|
||||
// that this performs minimal validation of domain name.
|
||||
func DePunify(domain string) (string, error) {
|
||||
domain = strings.ToLower(domain)
|
||||
return punifyProfile.ToUnicode(domain)
|
||||
}
|
||||
|
||||
// URIMatches returns true if the expected URI matches
|
||||
// any of the given URIs, taking account of punycode.
|
||||
func URIMatches(expect *url.URL, uris ...*url.URL) (ok bool, err error) {
|
||||
|
||||
// Create new URL to hold
|
||||
// punified URI information.
|
||||
punyURI := new(url.URL)
|
||||
*punyURI = *expect
|
||||
|
||||
// Set punified expected URL host.
|
||||
punyURI.Host, err = Punify_(expect.Host)
|
||||
if err != nil {
|
||||
return false, err
|
||||
}
|
||||
|
||||
// Calculate expected URI string.
|
||||
expectStr := punyURI.String()
|
||||
|
||||
// Use punyURI to iteratively
|
||||
// store each punified URI info
|
||||
// and generate punified URI
|
||||
// strings to check against.
|
||||
for _, uri := range uris {
|
||||
*punyURI = *uri
|
||||
punyURI.Host, err = Punify_(uri.Host)
|
||||
if err != nil {
|
||||
return false, err
|
||||
}
|
||||
|
||||
// Check for a match against expect.
|
||||
if expectStr == punyURI.String() {
|
||||
return true, nil
|
||||
}
|
||||
}
|
||||
|
||||
// Didn't match.
|
||||
return false, nil
|
||||
}
|
||||
|
||||
// PunifyURIToStr returns a new copy of URI with the
|
||||
// 'host' part converted to punycode with DomainToASCII.
|
||||
// This can potentially be expensive doing extra domain
|
||||
// verification for storage, for simple checks prefer URIMatches().
|
||||
func PunifyURI(in *url.URL) (*url.URL, error) {
|
||||
punyHost, err := PunifyValidate(in.Host)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out := new(url.URL)
|
||||
*out = *in
|
||||
out.Host = punyHost
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// PunifyURIToStr returns given URI serialized with the
|
||||
// 'host' part converted to punycode with DomainToASCII.
|
||||
// This can potentially be expensive doing extra domain
|
||||
// verification for storage, for simple checks prefer URIMatches().
|
||||
func PunifyURIToStr(in *url.URL) (string, error) {
|
||||
punyHost, err := PunifyValidate(in.Host)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
oldHost := in.Host
|
||||
in.Host = punyHost
|
||||
str := in.String()
|
||||
in.Host = oldHost
|
||||
return str, nil
|
||||
}
|
||||
|
|
@ -1,97 +0,0 @@
|
|||
// GoToSocial
|
||||
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
||||
// SPDX-License-Identifier: AGPL-3.0-or-later
|
||||
//
|
||||
// This program is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU Affero General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// This program is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU Affero General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU Affero General Public License
|
||||
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package util
|
||||
|
||||
import (
|
||||
"net/url"
|
||||
"strings"
|
||||
|
||||
"golang.org/x/net/idna"
|
||||
)
|
||||
|
||||
// Punify converts the given domain to lowercase
|
||||
// then to punycode (for international domain names).
|
||||
//
|
||||
// Returns the resulting domain or an error if the
|
||||
// punycode conversion fails.
|
||||
func Punify(domain string) (string, error) {
|
||||
domain = strings.ToLower(domain)
|
||||
return idna.ToASCII(domain)
|
||||
}
|
||||
|
||||
// DePunify converts the given punycode string
|
||||
// to its original unicode representation (lowercased).
|
||||
// Noop if the domain is (already) not puny.
|
||||
//
|
||||
// Returns an error if conversion fails.
|
||||
func DePunify(domain string) (string, error) {
|
||||
out, err := idna.ToUnicode(domain)
|
||||
return strings.ToLower(out), err
|
||||
}
|
||||
|
||||
// URIMatches returns true if the expected URI matches
|
||||
// any of the given URIs, taking account of punycode.
|
||||
func URIMatches(expect *url.URL, uris ...*url.URL) (bool, error) {
|
||||
// Normalize expect to punycode.
|
||||
expectStr, err := PunifyURIToStr(expect)
|
||||
if err != nil {
|
||||
return false, err
|
||||
}
|
||||
|
||||
for _, uri := range uris {
|
||||
uriStr, err := PunifyURIToStr(uri)
|
||||
if err != nil {
|
||||
return false, err
|
||||
}
|
||||
|
||||
if uriStr == expectStr {
|
||||
// Looks good.
|
||||
return true, nil
|
||||
}
|
||||
}
|
||||
|
||||
// Didn't match.
|
||||
return false, nil
|
||||
}
|
||||
|
||||
// PunifyURI returns a copy of the given URI
|
||||
// with the 'host' part converted to punycode.
|
||||
func PunifyURI(in *url.URL) (*url.URL, error) {
|
||||
punyHost, err := Punify(in.Host)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out := new(url.URL)
|
||||
*out = *in
|
||||
out.Host = punyHost
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// PunifyURIToStr returns given URI serialized
|
||||
// with the 'host' part converted to punycode.
|
||||
func PunifyURIToStr(in *url.URL) (string, error) {
|
||||
punyHost, err := Punify(in.Host)
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
oldHost := in.Host
|
||||
in.Host = punyHost
|
||||
str := in.String()
|
||||
in.Host = oldHost
|
||||
return str, nil
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue