[performance] http response encoding / writing improvements (#2374)

internal/api/client/admin/accountaction.go

@@ -124,5 +124,7 @@ func (m *Module) AccountActionPOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, gin.H{"message": "OK"})
+	apiutil.JSON(c, http.StatusOK, map[string]string{
+		"message": "OK",
+	})
 }

internal/api/client/admin/domainkeysexpire.go

@@ -132,7 +132,9 @@ func (m *Module) DomainKeysExpirePOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusAccepted, &apimodel.AdminActionResponse{ActionID: actionID})
+	apiutil.JSON(c, http.StatusOK, &apimodel.AdminActionResponse{
+		ActionID: actionID,
+	})
 }
 
 func validateDomainKeysExpire(form *apimodel.DomainKeysExpireRequest) error {

internal/api/client/admin/domainpermission.go

@@ -122,7 +122,7 @@ func (m *Module) createDomainPermissions(
 			return
 		}
 
-		c.JSON(http.StatusOK, domainBlock)
+		apiutil.JSON(c, http.StatusOK, domainBlock)
 		return
 	}
 
@@ -158,7 +158,7 @@ func (m *Module) createDomainPermissions(
 		domainPerms = append(domainPerms, entry.Resource)
 	}
 
-	c.JSON(http.StatusOK, domainPerms)
+	apiutil.JSON(c, http.StatusOK, domainPerms)
 }
 
 // deleteDomainPermission deletes a single domain permission (block or allow).
@@ -200,7 +200,7 @@ func (m *Module) deleteDomainPermission(
 		return
 	}
 
-	c.JSON(http.StatusOK, domainPerm)
+	apiutil.JSON(c, http.StatusOK, domainPerm)
 }
 
 // getDomainPermission gets a single domain permission (block or allow).
@@ -248,7 +248,7 @@ func (m *Module) getDomainPermission(
 		return
 	}
 
-	c.JSON(http.StatusOK, domainPerm)
+	apiutil.JSON(c, http.StatusOK, domainPerm)
 }
 
 // getDomainPermissions gets all domain permissions of the given type (block, allow).
@@ -290,5 +290,5 @@ func (m *Module) getDomainPermissions(
 		return
 	}
 
-	c.JSON(http.StatusOK, domainPerm)
+	apiutil.JSON(c, http.StatusOK, domainPerm)
 }

internal/api/client/admin/emailtest.go

@@ -116,5 +116,7 @@ func (m *Module) EmailTestPOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusAccepted, gin.H{"status": "test email sent"})
+	apiutil.JSON(c, http.StatusAccepted, map[string]string{
+		"status": "test email sent",
+	})
 }

internal/api/client/admin/emojicategoriesget.go

@@ -89,5 +89,5 @@ func (m *Module) EmojiCategoriesGETHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, categories)
+	apiutil.JSON(c, http.StatusOK, categories)
 }

internal/api/client/admin/emojicreate.go

@@ -131,7 +131,7 @@ func (m *Module) EmojiCreatePOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, apiEmoji)
+	apiutil.JSON(c, http.StatusOK, apiEmoji)
 }
 
 func validateCreateEmoji(form *apimodel.EmojiCreateRequest) error {

internal/api/client/admin/emojidelete.go

@@ -105,5 +105,5 @@ func (m *Module) EmojiDELETEHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, emoji)
+	apiutil.JSON(c, http.StatusOK, emoji)
 }

internal/api/client/admin/emojiget.go

@@ -95,5 +95,5 @@ func (m *Module) EmojiGETHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, emoji)
+	apiutil.JSON(c, http.StatusOK, emoji)
 }

internal/api/client/admin/emojisget.go

@@ -206,5 +206,6 @@ func (m *Module) EmojisGETHandler(c *gin.Context) {
 	if resp.LinkHeader != "" {
 		c.Header("Link", resp.LinkHeader)
 	}
-	c.JSON(http.StatusOK, resp.Items)
+
+	apiutil.JSON(c, http.StatusOK, resp.Items)
 }

internal/api/client/admin/emojiupdate.go

@@ -161,7 +161,7 @@ func (m *Module) EmojiPATCHHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, emoji)
+	apiutil.JSON(c, http.StatusOK, emoji)
 }
 
 // do a first pass on the form here

internal/api/client/admin/mediacleanup.go

@@ -102,5 +102,5 @@ func (m *Module) MediaCleanupPOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, remoteCacheDays)
+	apiutil.JSON(c, http.StatusOK, remoteCacheDays)
 }

internal/api/client/admin/mediarefetch.go

@@ -88,5 +88,5 @@ func (m *Module) MediaRefetchPOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.Status(http.StatusAccepted)
+	apiutil.Data(c, http.StatusOK, apiutil.AppJSON, apiutil.StatusAcceptedJSON)
 }

internal/api/client/admin/reportget.go

@@ -98,5 +98,5 @@ func (m *Module) ReportGETHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, report)
+	apiutil.JSON(c, http.StatusOK, report)
 }

internal/api/client/admin/reportresolve.go

@@ -120,5 +120,5 @@ func (m *Module) ReportResolvePOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, report)
+	apiutil.JSON(c, http.StatusOK, report)
 }

internal/api/client/admin/reportsget.go

@@ -176,5 +176,6 @@ func (m *Module) ReportsGETHandler(c *gin.Context) {
 	if resp.LinkHeader != "" {
 		c.Header("Link", resp.LinkHeader)
 	}
-	c.JSON(http.StatusOK, resp.Items)
+
+	apiutil.JSON(c, http.StatusOK, resp.Items)
 }

internal/api/client/admin/rulecreate.go

@@ -108,7 +108,7 @@ func (m *Module) RulePOSTHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, apiRule)
+	apiutil.JSON(c, http.StatusOK, apiRule)
 }
 
 func validateCreateRule(form *apimodel.InstanceRuleCreateRequest) error {

internal/api/client/admin/ruledelete.go

@@ -103,5 +103,5 @@ func (m *Module) RuleDELETEHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, apiRule)
+	apiutil.JSON(c, http.StatusOK, apiRule)
 }

internal/api/client/admin/ruleget.go

@@ -98,5 +98,5 @@ func (m *Module) RuleGETHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, rule)
+	apiutil.JSON(c, http.StatusOK, rule)
 }

internal/api/client/admin/rulesget.go

@@ -87,5 +87,5 @@ func (m *Module) RulesGETHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, resp)
+	apiutil.JSON(c, http.StatusOK, resp)
 }

internal/api/client/admin/ruleupdate.go

@@ -123,5 +123,5 @@ func (m *Module) RulePATCHHandler(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, apiRule)
+	apiutil.JSON(c, http.StatusOK, apiRule)
 }