mirrors/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-10-31 18:02:25 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

[chore/bugfix] Demote failed inbox forwarding to warn log rather than error return (#1892)

Browse source
This commit is contained in:
tobi 2023-06-14 15:08:31 +02:00 • committed by GitHub
commit 827cc4df56
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
internal/federation/federatingactor.go
View file

@ -231,8 +231,9 @@ func (f *federatingActor) PostInboxScheme(ctx context.Context, w http.ResponseWr
// is updated, and/or federating callbacks are handled // is updated, and/or federating callbacks are handled
// properly. // properly.
if !errors.Is(err, db.ErrAlreadyExists) { if !errors.Is(err, db.ErrAlreadyExists) {
err = fmt.Errorf("PostInboxScheme: error calling sideEffectActor.InboxForwarding: %w", err) // Failed inbox forwarding is not a show-stopper,
return false, gtserror.NewErrorInternalError(err) // and doesn't even necessarily denote a real error.
l.Warnf("error calling sideEffectActor.InboxForwarding: %q", err)
} }
} }