[bugfix] update the default configuration to not set a db type or address, to require explicitly setting it (#4228)

This updates the database defaults to remove a type or address. This is to help ensure we don't have any repeats of https://codeberg.org/superseriousbusiness/gotosocial/issues/4183, it means the user needs to explicitly configure these things core settings instead of relying on defaults.

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4228
Reviewed-by: Daenney <daenney@noreply.codeberg.org>
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>

docs/configuration/database.md

@@ -2,7 +2,7 @@
 
 GoToSocial stores statuses, accounts, etc, in a database. This can be either [SQLite](https://sqlite.org/index.html) or [Postgres](https://www.postgresql.org/).
 
-By default, GoToSocial will use SQLite, but this is easy to change.
+GoToSocial has no default configured database type or address. In most situations, we recommend the use of SQLite.
 
 ## SQLite
 
@@ -71,7 +71,7 @@ db-postgres-connection-string: 'postgres://myUser:myPass@localhost/db?search_pat
 
 # String. Database type.
 # Options: ["postgres","sqlite"]
-# Default: "sqlite"
+# Default: ""
 db-type: "sqlite"
 
 # String. Database address or parameters.

example/config.yaml

@@ -141,7 +141,7 @@ trusted-proxies:
 
 # String. Database type.
 # Options: ["postgres","sqlite"]
-# Default: "sqlite"
+# Default: ""
 db-type: "sqlite"
 
 # String. Database address or parameters.

internal/config/defaults.go

@@ -41,8 +41,8 @@ var Defaults = Configuration{
 	Port:               8080,
 	TrustedProxies:     []string{"127.0.0.1/32", "::1"}, // localhost
 
-	DbType:                   "sqlite",
+	DbType:                   "",
-	DbAddress:                "db.sqlite",
+	DbAddress:                "",
 	DbPort:                   5432,
 	DbUser:                   "",
 	DbPassword:               "",