mirrors/gotosocial
1
0
Fork 0
mirror of https://github.com/superseriousbusiness/gotosocial.git synced 2025-12-29 17:46:15 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix up some tests

Browse source
This commit is contained in:
tsmethurst 2021-08-19 17:00:19 +02:00
commit a2c4c0ec03
3 changed files with 45 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

59
internal/processing/fromcommon.go
View file

@ -102,7 +102,7 @@ func (p *processor) notifyStatus(status *gtsmodel.Status) error {
return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err) return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err)
} }
if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, m.OriginAccount); err != nil { if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, m.TargetAccount); err != nil {
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err) return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
} }
} }
@ -145,9 +145,9 @@ func (p *processor) notifyFollowRequest(followRequest *gtsmodel.FollowRequest, r
return nil return nil
} }
func (p *processor) notifyFollow(follow *gtsmodel.Follow, receivingAccount *gtsmodel.Account) error { func (p *processor) notifyFollow(follow *gtsmodel.Follow, targetAccount *gtsmodel.Account) error {
// return if this isn't a local account // return if this isn't a local account
if receivingAccount.Domain != "" { if targetAccount.Domain != "" {
return nil return nil
} }
@ -170,7 +170,9 @@ func (p *processor) notifyFollow(follow *gtsmodel.Follow, receivingAccount *gtsm
ID: notifID, ID: notifID,
NotificationType: gtsmodel.NotificationFollow, NotificationType: gtsmodel.NotificationFollow,
TargetAccountID: follow.TargetAccountID, TargetAccountID: follow.TargetAccountID,
TargetAccount: follow.TargetAccount,
OriginAccountID: follow.AccountID, OriginAccountID: follow.AccountID,
OriginAccount: follow.Account,
} }
if err := p.db.Put(notif); err != nil { if err := p.db.Put(notif); err != nil {
return fmt.Errorf("notifyFollow: error putting notification in database: %s", err) return fmt.Errorf("notifyFollow: error putting notification in database: %s", err)
@ -182,16 +184,16 @@ func (p *processor) notifyFollow(follow *gtsmodel.Follow, receivingAccount *gtsm
return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err) return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err)
} }
if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, receivingAccount); err != nil { if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, targetAccount); err != nil {
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err) return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
} }
return nil return nil
} }
func (p *processor) notifyFave(fave *gtsmodel.StatusFave, receivingAccount *gtsmodel.Account) error { func (p *processor) notifyFave(fave *gtsmodel.StatusFave, targetAccount *gtsmodel.Account) error {
// return if this isn't a local account // return if this isn't a local account
if receivingAccount.Domain != "" { if targetAccount.Domain != "" {
return nil return nil
} }
@ -204,8 +206,11 @@ func (p *processor) notifyFave(fave *gtsmodel.StatusFave, receivingAccount *gtsm
ID: notifID, ID: notifID,
NotificationType: gtsmodel.NotificationFave, NotificationType: gtsmodel.NotificationFave,
TargetAccountID: fave.TargetAccountID, TargetAccountID: fave.TargetAccountID,
TargetAccount: fave.TargetAccount,
OriginAccountID: fave.AccountID, OriginAccountID: fave.AccountID,
OriginAccount: fave.Account,
StatusID: fave.StatusID, StatusID: fave.StatusID,
Status: fave.Status,
} }
if err := p.db.Put(notif); err != nil { if err := p.db.Put(notif); err != nil {
@ -218,7 +223,7 @@ func (p *processor) notifyFave(fave *gtsmodel.StatusFave, receivingAccount *gtsm
return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err) return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err)
} }
if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, receivingAccount); err != nil { if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, targetAccount); err != nil {
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err) return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
} }
@ -231,22 +236,29 @@ func (p *processor) notifyAnnounce(status *gtsmodel.Status) error {
return nil return nil
} }
boostedStatus := &gtsmodel.Status{} if status.BoostOf == nil {
if err := p.db.GetByID(status.BoostOfID, boostedStatus); err != nil { boostedStatus, err := p.db.GetStatusByID(status.BoostOfID)
return fmt.Errorf("notifyAnnounce: error getting status with id %s: %s", status.BoostOfID, err) if err != nil {
return fmt.Errorf("notifyAnnounce: error getting status with id %s: %s", status.BoostOfID, err)
}
status.BoostOf = boostedStatus
} }
boostedAcct := &gtsmodel.Account{} if status.BoostOfAccount == nil {
if err := p.db.GetByID(boostedStatus.AccountID, boostedAcct); err != nil { boostedAcct, err := p.db.GetAccountByID(status.BoostOfAccountID)
return fmt.Errorf("notifyAnnounce: error getting account with id %s: %s", boostedStatus.AccountID, err) if err != nil {
return fmt.Errorf("notifyAnnounce: error getting account with id %s: %s", status.BoostOfAccountID, err)
}
status.BoostOf.Account = boostedAcct
status.BoostOfAccount = boostedAcct
} }
if boostedAcct.Domain != "" { if status.BoostOfAccount.Domain == "" {
// remote account, nothing to do // remote account, nothing to do
return nil return nil
} }
if boostedStatus.AccountID == status.AccountID { if status.BoostOfAccountID == status.AccountID {
// it's a self boost, nothing to do // it's a self boost, nothing to do
return nil return nil
} }
@ -254,7 +266,7 @@ func (p *processor) notifyAnnounce(status *gtsmodel.Status) error {
// make sure a notif doesn't already exist for this announce // make sure a notif doesn't already exist for this announce
err := p.db.GetWhere([]db.Where{ err := p.db.GetWhere([]db.Where{
{Key: "notification_type", Value: gtsmodel.NotificationReblog}, {Key: "notification_type", Value: gtsmodel.NotificationReblog},
{Key: "target_account_id", Value: boostedAcct.ID}, {Key: "target_account_id", Value: status.BoostOfAccountID},
{Key: "origin_account_id", Value: status.AccountID}, {Key: "origin_account_id", Value: status.AccountID},
{Key: "status_id", Value: status.ID}, {Key: "status_id", Value: status.ID},
}, &gtsmodel.Notification{}) }, &gtsmodel.Notification{})
@ -272,9 +284,12 @@ func (p *processor) notifyAnnounce(status *gtsmodel.Status) error {
notif := &gtsmodel.Notification{ notif := &gtsmodel.Notification{
ID: notifID, ID: notifID,
NotificationType: gtsmodel.NotificationReblog, NotificationType: gtsmodel.NotificationReblog,
TargetAccountID: boostedAcct.ID, TargetAccountID: status.BoostOfAccountID,
TargetAccount: status.BoostOfAccount,
OriginAccountID: status.AccountID, OriginAccountID: status.AccountID,
OriginAccount: status.Account,
StatusID: status.ID, StatusID: status.ID,
Status: status,
} }
if err := p.db.Put(notif); err != nil { if err := p.db.Put(notif); err != nil {
@ -287,7 +302,7 @@ func (p *processor) notifyAnnounce(status *gtsmodel.Status) error {
return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err) return fmt.Errorf("notifyStatus: error converting notification to masto representation: %s", err)
} }
if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, boostedAcct); err != nil { if err := p.streamingProcessor.StreamNotificationToAccount(mastoNotif, status.BoostOfAccount); err != nil {
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err) return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
} }
@ -297,8 +312,8 @@ func (p *processor) notifyAnnounce(status *gtsmodel.Status) error {
func (p *processor) timelineStatus(status *gtsmodel.Status) error { func (p *processor) timelineStatus(status *gtsmodel.Status) error {
// make sure the author account is pinned onto the status // make sure the author account is pinned onto the status
if status.Account == nil { if status.Account == nil {
a := &gtsmodel.Account{} a, err := p.db.GetAccountByID(status.AccountID)
if err := p.db.GetByID(status.AccountID, a); err != nil { if err != nil {
return fmt.Errorf("timelineStatus: error getting author account with id %s: %s", status.AccountID, err) return fmt.Errorf("timelineStatus: error getting author account with id %s: %s", status.AccountID, err)
} }
status.Account = a status.Account = a
@ -353,8 +368,8 @@ func (p *processor) timelineStatusForAccount(status *gtsmodel.Status, accountID
defer wg.Done() defer wg.Done()
// get the timeline owner account // get the timeline owner account
timelineAccount := &gtsmodel.Account{} timelineAccount, err := p.db.GetAccountByID(accountID)
if err := p.db.GetByID(accountID, timelineAccount); err != nil { if err != nil {
errors <- fmt.Errorf("timelineStatusForAccount: error getting account for timeline with id %s: %s", accountID, err) errors <- fmt.Errorf("timelineStatusForAccount: error getting account for timeline with id %s: %s", accountID, err)
return return
} }

7
internal/timeline/index_test.go
View file

@ -67,9 +67,8 @@ func (suite *IndexTestSuite) TestIndexBeforeLowID() {
suite.NoError(err) suite.NoError(err)
suite.Equal("01F8MHAAY43M6RJ473VQFCVH37", postID) suite.Equal("01F8MHAAY43M6RJ473VQFCVH37", postID)
// indexLength should only be 9 because that's all this user has hometimelineable
indexLength := suite.timeline.PostIndexLength() indexLength := suite.timeline.PostIndexLength()
suite.Equal(9, indexLength) suite.Equal(10, indexLength)
} }
func (suite *IndexTestSuite) TestIndexBeforeHighID() { func (suite *IndexTestSuite) TestIndexBeforeHighID() {
@ -97,9 +96,9 @@ func (suite *IndexTestSuite) TestIndexBehindHighID() {
suite.NoError(err) suite.NoError(err)
suite.Equal("01FCTA44PW9H1TB328S9AQXKDS", postID) suite.Equal("01FCTA44PW9H1TB328S9AQXKDS", postID)
// indexLength should only be 11 because that's all this user has hometimelineable // indexLength should be 10 because that's all this user has hometimelineable
indexLength := suite.timeline.PostIndexLength() indexLength := suite.timeline.PostIndexLength()
suite.Equal(11, indexLength) suite.Equal(10, indexLength)
} }
func (suite *IndexTestSuite) TestIndexBehindLowID() { func (suite *IndexTestSuite) TestIndexBehindLowID() {

10
internal/timeline/manager_test.go
View file

@ -66,9 +66,9 @@ func (suite *ManagerTestSuite) TestManagerIntegration() {
err = suite.manager.PrepareXFromTop(testAccount.ID, 20) err = suite.manager.PrepareXFromTop(testAccount.ID, 20)
suite.NoError(err) suite.NoError(err)
// local_account_1 can see 11 statuses out of the testrig statuses in its home timeline // local_account_1 can see 12 statuses out of the testrig statuses in its home timeline
indexedLen = suite.manager.GetIndexedLength(testAccount.ID) indexedLen = suite.manager.GetIndexedLength(testAccount.ID)
suite.Equal(11, indexedLen) suite.Equal(12, indexedLen)
// oldest should now be set // oldest should now be set
oldestIndexed, err = suite.manager.GetOldestIndexedID(testAccount.ID) oldestIndexed, err = suite.manager.GetOldestIndexedID(testAccount.ID)
@ -78,7 +78,7 @@ func (suite *ManagerTestSuite) TestManagerIntegration() {
// get hometimeline // get hometimeline
statuses, err := suite.manager.HomeTimeline(testAccount.ID, "", "", "", 20, false) statuses, err := suite.manager.HomeTimeline(testAccount.ID, "", "", "", 20, false)
suite.NoError(err) suite.NoError(err)
suite.Len(statuses, 11) suite.Len(statuses, 12)
// now wipe the last status from all timelines, as though it had been deleted by the owner // now wipe the last status from all timelines, as though it had been deleted by the owner
err = suite.manager.WipeStatusFromAllTimelines("01F8MH75CBF9JFX4ZAD54N0W0R") err = suite.manager.WipeStatusFromAllTimelines("01F8MH75CBF9JFX4ZAD54N0W0R")
@ -86,7 +86,7 @@ func (suite *ManagerTestSuite) TestManagerIntegration() {
// timeline should be shorter // timeline should be shorter
indexedLen = suite.manager.GetIndexedLength(testAccount.ID) indexedLen = suite.manager.GetIndexedLength(testAccount.ID)
suite.Equal(10, indexedLen) suite.Equal(11, indexedLen)
// oldest should now be different // oldest should now be different
oldestIndexed, err = suite.manager.GetOldestIndexedID(testAccount.ID) oldestIndexed, err = suite.manager.GetOldestIndexedID(testAccount.ID)
@ -100,7 +100,7 @@ func (suite *ManagerTestSuite) TestManagerIntegration() {
// timeline should be shorter // timeline should be shorter
indexedLen = suite.manager.GetIndexedLength(testAccount.ID) indexedLen = suite.manager.GetIndexedLength(testAccount.ID)
suite.Equal(9, indexedLen) suite.Equal(10, indexedLen)
// oldest should now be different // oldest should now be different
oldestIndexed, err = suite.manager.GetOldestIndexedID(testAccount.ID) oldestIndexed, err = suite.manager.GetOldestIndexedID(testAccount.ID)