add remote status published / updated field validation checks, handle appropriately in handleStatusEdit()

This commit is contained in:
kim 2024-12-24 15:14:30 +00:00
commit a66f3e2f89
2 changed files with 31 additions and 22 deletions

View file

@ -22,6 +22,7 @@ import (
"context"
"errors"
"net/url"
"time"
"github.com/miekg/dns"
"github.com/superseriousbusiness/gotosocial/internal/ap"
@ -357,15 +358,21 @@ func (c *Converter) ASStatusToStatus(ctx context.Context, statusable ap.Statusab
status.CreatedAt = pub
} else {
log.Warnf(ctx, "unusable published property on %s", uri)
status.CreatedAt = time.Now()
}
// status.Updated
//
// Extract updated time for status, defaults to Published.
if upd := ap.GetUpdated(statusable); !upd.IsZero() {
// Extract and validate update time for status. Defaults to published.
if upd := ap.GetUpdated(statusable); upd.After(status.CreatedAt) {
status.UpdatedAt = upd
} else {
} else if upd.IsZero() {
status.UpdatedAt = status.CreatedAt
} else {
// This is a malformed status that will likely break our systems.
err := gtserror.Newf("status %s 'updated' predates 'published'", uri)
return nil, gtserror.SetMalformed(err)
}
// status.AccountURI