[performance] cache media attachments (#1525)

* replace concurrency worker pools with base models in State.Workers, update code and tests accordingly

* add media attachment caching, slightly tweak default cache config

* further tweak default cache config values

* replace other media attachment db calls to go through cache

* update envparsing test

* fix delete media attachment sql

* fix media sql query

* invalidate cached media entries during status create / update

* fix envparsing test

* fix typo in panic log message...

* add 'updated_at' column during UpdateAttachment

* remove unused func

---------

Signed-off-by: kim <grufwub@gmail.com>

internal/db/bundb/media.go

@@ -34,39 +34,69 @@ type mediaDB struct {
 	state *state.State
 }
 
-func (m *mediaDB) newMediaQ(i *gtsmodel.MediaAttachment) *bun.SelectQuery {
-	return m.conn.
-		NewSelect().
-		Model(i)
-}
-
 func (m *mediaDB) GetAttachmentByID(ctx context.Context, id string) (*gtsmodel.MediaAttachment, db.Error) {
 	return m.getAttachment(
 		ctx,
 		"ID",
 		func(attachment *gtsmodel.MediaAttachment) error {
-			return m.newMediaQ(attachment).Where("? = ?", bun.Ident("media_attachment.id"), id).Scan(ctx)
+			return m.conn.NewSelect().
+				Model(attachment).
+				Where("? = ?", bun.Ident("media_attachment.id"), id).
+				Scan(ctx)
 		},
 		id,
 	)
 }
 
-func (m *mediaDB) getAttachments(ctx context.Context, ids []string) ([]*gtsmodel.MediaAttachment, db.Error) {
-	attachments := make([]*gtsmodel.MediaAttachment, 0, len(ids))
+func (m *mediaDB) getAttachment(ctx context.Context, lookup string, dbQuery func(*gtsmodel.MediaAttachment) error, keyParts ...any) (*gtsmodel.MediaAttachment, db.Error) {
+	return m.state.Caches.GTS.Media().Load(lookup, func() (*gtsmodel.MediaAttachment, error) {
+		var attachment gtsmodel.MediaAttachment
 
-	for _, id := range ids {
-		// Attempt fetch from DB
-		attachment, err := m.GetAttachmentByID(ctx, id)
-		if err != nil {
-			log.Errorf(ctx, "error getting attachment %q: %v", id, err)
-			continue
+		// Not cached! Perform database query
+		if err := dbQuery(&attachment); err != nil {
+			return nil, m.conn.ProcessError(err)
 		}
 
-		// Append attachment
-		attachments = append(attachments, attachment)
+		return &attachment, nil
+	}, keyParts...)
+}
+
+func (m *mediaDB) PutAttachment(ctx context.Context, media *gtsmodel.MediaAttachment) error {
+	return m.state.Caches.GTS.Media().Store(media, func() error {
+		_, err := m.conn.NewInsert().Model(media).Exec(ctx)
+		return m.conn.ProcessError(err)
+	})
+}
+
+func (m *mediaDB) UpdateAttachment(ctx context.Context, media *gtsmodel.MediaAttachment, columns ...string) error {
+	media.UpdatedAt = time.Now()
+	if len(columns) > 0 {
+		// If we're updating by column, ensure "updated_at" is included.
+		columns = append(columns, "updated_at")
 	}
 
-	return attachments, nil
+	return m.state.Caches.GTS.Media().Store(media, func() error {
+		_, err := m.conn.NewUpdate().
+			Model(media).
+			Where("? = ?", bun.Ident("media_attachment.id"), media.ID).
+			Column(columns...).
+			Exec(ctx)
+		return m.conn.ProcessError(err)
+	})
+}
+
+func (m *mediaDB) DeleteAttachment(ctx context.Context, id string) error {
+	// Attempt to delete from database.
+	if _, err := m.conn.NewDelete().
+		TableExpr("? AS ?", bun.Ident("media_attachments"), bun.Ident("media_attachment")).
+		Where("? = ?", bun.Ident("media_attachment.id"), id).
+		Exec(ctx); err != nil {
+		return m.conn.ProcessError(err)
+	}
+
+	// Invalidate this media item from the cache.
+	m.state.Caches.GTS.Media().Invalidate("ID", id)
+	return nil
 }
 
 func (m *mediaDB) GetRemoteOlderThan(ctx context.Context, olderThan time.Time, limit int) ([]*gtsmodel.MediaAttachment, db.Error) {
@@ -183,14 +213,20 @@ func (m *mediaDB) CountLocalUnattachedOlderThan(ctx context.Context, olderThan t
 	return count, nil
 }
 
-func (m *mediaDB) getAttachment(ctx context.Context, lookup string, dbQuery func(*gtsmodel.MediaAttachment) error, keyParts ...any) (*gtsmodel.MediaAttachment, db.Error) {
-	// Fetch attachment from database
-	// todo: cache this lookup
-	attachment := new(gtsmodel.MediaAttachment)
+func (m *mediaDB) getAttachments(ctx context.Context, ids []string) ([]*gtsmodel.MediaAttachment, db.Error) {
+	attachments := make([]*gtsmodel.MediaAttachment, 0, len(ids))
 
-	if err := dbQuery(attachment); err != nil {
-		return nil, m.conn.ProcessError(err)
+	for _, id := range ids {
+		// Attempt fetch from DB
+		attachment, err := m.GetAttachmentByID(ctx, id)
+		if err != nil {
+			log.Errorf(ctx, "error getting attachment %q: %v", id, err)
+			continue
+		}
+
+		// Append attachment
+		attachments = append(attachments, attachment)
 	}
 
-	return attachment, nil
+	return attachments, nil
 }