mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-10-31 00:52:26 -05:00 
			
		
		
		
	[performance] update remaining worker pools to use queues (#2865)
* start replacing client + federator + media workers with new worker + queue types
* refactor federatingDB.Delete(), drop queued messages when deleting account / status
* move all queue purging to the processor workers
* undo toolchain updates
* code comments, ensure dereferencer worker pool gets started
* update gruf libraries in readme
* start the job scheduler separately to the worker pools
* reshuffle ordering or server.go + remove duplicate worker start / stop
* update go-list version
* fix vendoring
* move queue invalidation to before wipeing / deletion, to ensure queued work not dropped
* add logging to worker processing functions in testrig, don't start workers in unexpected places
* update go-structr to add (+then rely on) QueueCtx{} type
* ensure more worker pools get started properly in tests
* fix remaining broken tests relying on worker queue logic
* fix account test suite queue popping logic, ensure noop workers do not pull from queue
* move back accidentally shuffled account deletion order
* ensure error (non nil!!) gets passed in refactored federatingDB{}.Delete()
* silently drop deletes from accounts not permitted to
* don't warn log on forwarded deletes
* make if else clauses easier to parse
* use getFederatorMsg()
* improved code comment
* improved code comment re: requesting account delete checks
* remove boolean result from worker start / stop since false = already running or already stopped
* remove optional passed-in http.client
* remove worker starting from the admin CLI commands (we don't need to handle side-effects)
* update prune cli to start scheduler but not all of the workers
* fix rebase issues
* remove redundant return statements
* i'm sorry sir linter
	
	
This commit is contained in:
		
					parent
					
						
							
								ba4f51ce2f
							
						
					
				
			
			
				commit
				
					
						c9c0773f2c
					
				
			
		
					 79 changed files with 1892 additions and 834 deletions
				
			
		|  | @ -197,11 +197,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusWithNotification() { | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ObjectNote, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -291,11 +291,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusReply() { | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ObjectNote, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -355,11 +355,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusReplyMuted() { | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ObjectNote, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -409,11 +409,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusBoostMuted() { | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ActivityAnnounce, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -467,11 +467,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusListRepliesPolicyLis | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ObjectNote, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -540,11 +540,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusListRepliesPolicyLis | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ObjectNote, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -608,11 +608,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusReplyListRepliesPoli | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ObjectNote, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -664,11 +664,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusBoost() { | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ActivityAnnounce, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -729,11 +729,11 @@ func (suite *FromClientAPITestSuite) TestProcessCreateStatusBoostNoReblogs() { | |||
| 	// Process the new status. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ActivityAnnounce, | ||||
| 			APActivityType: ap.ActivityCreate, | ||||
| 			GTSModel:       status, | ||||
| 			OriginAccount:  postingAccount, | ||||
| 			Origin:         postingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  | @ -776,11 +776,11 @@ func (suite *FromClientAPITestSuite) TestProcessStatusDelete() { | |||
| 	// Process the status delete. | ||||
| 	if err := suite.processor.Workers().ProcessFromClientAPI( | ||||
| 		ctx, | ||||
| 		messages.FromClientAPI{ | ||||
| 		&messages.FromClientAPI{ | ||||
| 			APObjectType:   ap.ObjectNote, | ||||
| 			APActivityType: ap.ActivityDelete, | ||||
| 			GTSModel:       deletedStatus, | ||||
| 			OriginAccount:  deletingAccount, | ||||
| 			Origin:         deletingAccount, | ||||
| 		}, | ||||
| 	); err != nil { | ||||
| 		suite.FailNow(err.Error()) | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue