uncomment + fix list database tests

This commit is contained in:
kim 2024-09-13 21:28:58 +01:00
commit d277705e6c

View file

@ -18,307 +18,287 @@
package bundb_test
import (
"context"
"slices"
"testing"
"github.com/stretchr/testify/suite"
"github.com/superseriousbusiness/gotosocial/internal/db"
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
)
type ListTestSuite struct {
BunDBStandardTestSuite
}
// func (suite *ListTestSuite) testStructs() (*gtsmodel.List, []*gtsmodel.ListEntry, *gtsmodel.Account) {
// testList := &gtsmodel.List{}
// *testList = *suite.testLists["local_account_1_list_1"]
func (suite *ListTestSuite) testStructs() (*gtsmodel.List, []*gtsmodel.ListEntry, *gtsmodel.Account) {
testList := &gtsmodel.List{}
*testList = *suite.testLists["local_account_1_list_1"]
// // Populate entries on this list as we'd expect them back from the db.
// entries := make([]*gtsmodel.ListEntry, 0, len(suite.testListEntries))
// for _, entry := range suite.testListEntries {
// entries = append(entries, entry)
// }
// Populate entries on this list as we'd expect them back from the db.
entries := make([]*gtsmodel.ListEntry, 0, len(suite.testListEntries))
for _, entry := range suite.testListEntries {
entries = append(entries, entry)
}
// // Sort by ID descending (again, as we'd expect from the db).
// slices.SortFunc(entries, func(a, b *gtsmodel.ListEntry) int {
// const k = -1
// switch {
// case a.ID > b.ID:
// return +k
// case a.ID < b.ID:
// return -k
// default:
// return 0
// }
// })
// Sort by ID descending (again, as we'd expect from the db).
slices.SortFunc(entries, func(a, b *gtsmodel.ListEntry) int {
const k = -1
switch {
case a.ID > b.ID:
return +k
case a.ID < b.ID:
return -k
default:
return 0
}
})
// testAccount := &gtsmodel.Account{}
// *testAccount = *suite.testAccounts["local_account_1"]
testAccount := &gtsmodel.Account{}
*testAccount = *suite.testAccounts["local_account_1"]
// return testList, entries, testAccount
// }
return testList, entries, testAccount
}
// func (suite *ListTestSuite) checkList(expected *gtsmodel.List, actual *gtsmodel.List) {
// suite.Equal(expected.ID, actual.ID)
// suite.Equal(expected.Title, actual.Title)
// suite.Equal(expected.AccountID, actual.AccountID)
// suite.Equal(expected.RepliesPolicy, actual.RepliesPolicy)
// suite.NotNil(actual.Account)
// }
func (suite *ListTestSuite) checkList(expected *gtsmodel.List, actual *gtsmodel.List) {
suite.Equal(expected.ID, actual.ID)
suite.Equal(expected.Title, actual.Title)
suite.Equal(expected.AccountID, actual.AccountID)
suite.Equal(expected.RepliesPolicy, actual.RepliesPolicy)
suite.NotNil(actual.Account)
}
// func (suite *ListTestSuite) checkListEntry(expected *gtsmodel.ListEntry, actual *gtsmodel.ListEntry) {
// suite.Equal(expected.ID, actual.ID)
// suite.Equal(expected.ListID, actual.ListID)
// suite.Equal(expected.FollowID, actual.FollowID)
// }
func (suite *ListTestSuite) checkListEntry(expected *gtsmodel.ListEntry, actual *gtsmodel.ListEntry) {
suite.Equal(expected.ID, actual.ID)
suite.Equal(expected.ListID, actual.ListID)
suite.Equal(expected.FollowID, actual.FollowID)
}
// func (suite *ListTestSuite) checkListEntries(expected []*gtsmodel.ListEntry, actual []*gtsmodel.ListEntry) {
// var (
// lExpected = len(expected)
// lActual = len(actual)
// )
func (suite *ListTestSuite) checkListEntries(expected []*gtsmodel.ListEntry, actual []*gtsmodel.ListEntry) {
var (
lExpected = len(expected)
lActual = len(actual)
)
// if lExpected != lActual {
// suite.FailNow("", "expected %d list entries, got %d", lExpected, lActual)
// }
if lExpected != lActual {
suite.FailNow("", "expected %d list entries, got %d", lExpected, lActual)
}
// var topID string
// for i, expectedEntry := range expected {
// actualEntry := actual[i]
var topID string
for i, expectedEntry := range expected {
actualEntry := actual[i]
// // Ensure ID descending.
// if topID == "" {
// topID = actualEntry.ID
// } else {
// suite.Less(actualEntry.ID, topID)
// }
// Ensure ID descending.
if topID == "" {
topID = actualEntry.ID
} else {
suite.Less(actualEntry.ID, topID)
}
// suite.checkListEntry(expectedEntry, actualEntry)
// }
// }
suite.checkListEntry(expectedEntry, actualEntry)
}
}
// func (suite *ListTestSuite) TestGetListByID() {
// testList, _, _ := suite.testStructs()
func (suite *ListTestSuite) TestGetListByID() {
testList, _, _ := suite.testStructs()
// dbList, err := suite.db.GetListByID(context.Background(), testList.ID)
// if err != nil {
// suite.FailNow(err.Error())
// }
dbList, err := suite.db.GetListByID(context.Background(), testList.ID)
if err != nil {
suite.FailNow(err.Error())
}
// suite.checkList(testList, dbList)
// }
suite.checkList(testList, dbList)
}
// func (suite *ListTestSuite) TestGetListsForAccountID() {
// testList, _, testAccount := suite.testStructs()
func (suite *ListTestSuite) TestGetListsForAccountID() {
testList, _, testAccount := suite.testStructs()
// dbLists, err := suite.db.GetListsByAccountID(context.Background(), testAccount.ID)
// if err != nil {
// suite.FailNow(err.Error())
// }
dbLists, err := suite.db.GetListsByAccountID(context.Background(), testAccount.ID)
if err != nil {
suite.FailNow(err.Error())
}
// if l := len(dbLists); l != 1 {
// suite.FailNow("", "expected %d lists, got %d", 1, l)
// }
if l := len(dbLists); l != 1 {
suite.FailNow("", "expected %d lists, got %d", 1, l)
}
// suite.checkList(testList, dbLists[0])
// }
suite.checkList(testList, dbLists[0])
}
// func (suite *ListTestSuite) TestPutList() {
// ctx := context.Background()
// _, _, testAccount := suite.testStructs()
func (suite *ListTestSuite) TestPutList() {
ctx := context.Background()
_, _, testAccount := suite.testStructs()
// testList := &gtsmodel.List{
// ID: "01H0J2PMYM54618VCV8Y8QYAT4",
// Title: "Test List!",
// AccountID: testAccount.ID,
// }
testList := &gtsmodel.List{
ID: "01H0J2PMYM54618VCV8Y8QYAT4",
Title: "Test List!",
AccountID: testAccount.ID,
}
// if err := suite.db.PutList(ctx, testList); err != nil {
// suite.FailNow(err.Error())
// }
if err := suite.db.PutList(ctx, testList); err != nil {
suite.FailNow(err.Error())
}
// dbList, err := suite.db.GetListByID(ctx, testList.ID)
// if err != nil {
// suite.FailNow(err.Error())
// }
dbList, err := suite.db.GetListByID(ctx, testList.ID)
if err != nil {
suite.FailNow(err.Error())
}
// // Bodge testlist as though default had been set.
// testList.RepliesPolicy = gtsmodel.RepliesPolicyFollowed
// suite.checkList(testList, dbList)
// }
// Bodge testlist as though default had been set.
testList.RepliesPolicy = gtsmodel.RepliesPolicyFollowed
suite.checkList(testList, dbList)
}
// func (suite *ListTestSuite) TestUpdateList() {
// ctx := context.Background()
// testList, _, _ := suite.testStructs()
func (suite *ListTestSuite) TestUpdateList() {
ctx := context.Background()
testList, _, _ := suite.testStructs()
// // Get List in the cache first.
// dbList, err := suite.db.GetListByID(ctx, testList.ID)
// if err != nil {
// suite.FailNow(err.Error())
// }
// Get List in the cache first.
dbList, err := suite.db.GetListByID(ctx, testList.ID)
if err != nil {
suite.FailNow(err.Error())
}
// // Now do the update.
// testList.Title = "New Title!"
// if err := suite.db.UpdateList(ctx, testList, "title"); err != nil {
// suite.FailNow(err.Error())
// }
// Now do the update.
testList.Title = "New Title!"
if err := suite.db.UpdateList(ctx, testList, "title"); err != nil {
suite.FailNow(err.Error())
}
// // Cache should be invalidated
// // + we should have updated list.
// dbList, err = suite.db.GetListByID(ctx, testList.ID)
// if err != nil {
// suite.FailNow(err.Error())
// }
// Cache should be invalidated
// + we should have updated list.
dbList, err = suite.db.GetListByID(ctx, testList.ID)
if err != nil {
suite.FailNow(err.Error())
}
// suite.checkList(testList, dbList)
// }
suite.checkList(testList, dbList)
}
// func (suite *ListTestSuite) TestDeleteList() {
// ctx := context.Background()
// testList, _, _ := suite.testStructs()
func (suite *ListTestSuite) TestDeleteList() {
ctx := context.Background()
testList, _, _ := suite.testStructs()
// // Get List in the cache first.
// if _, err := suite.db.GetListByID(ctx, testList.ID); err != nil {
// suite.FailNow(err.Error())
// }
// Get List in the cache first.
if _, err := suite.db.GetListByID(ctx, testList.ID); err != nil {
suite.FailNow(err.Error())
}
// // Now do the delete.
// if err := suite.db.DeleteListByID(ctx, testList.ID); err != nil {
// suite.FailNow(err.Error())
// }
// Now do the delete.
if err := suite.db.DeleteListByID(ctx, testList.ID); err != nil {
suite.FailNow(err.Error())
}
// // Cache should be invalidated
// // + we should have no list.
// _, err := suite.db.GetListByID(ctx, testList.ID)
// suite.ErrorIs(err, db.ErrNoEntries)
// Cache should be invalidated
// + we should have no list.
_, err := suite.db.GetListByID(ctx, testList.ID)
suite.ErrorIs(err, db.ErrNoEntries)
// // All accounts / follows attached to this
// // list should now be return empty values.
// listAccounts, err1 := suite.db.GetAccountsInList(ctx, testList.ID, nil)
// listFollows, err2 := suite.db.GetFollowsInList(ctx, testList.ID, nil)
// suite.NoError(err1)
// suite.NoError(err2)
// suite.Empty(listAccounts)
// suite.Empty(listFollows)
// }
// All accounts / follows attached to this
// list should now be return empty values.
listAccounts, err1 := suite.db.GetAccountsInList(ctx, testList.ID, nil)
listFollows, err2 := suite.db.GetFollowsInList(ctx, testList.ID, nil)
suite.NoError(err1)
suite.NoError(err2)
suite.Empty(listAccounts)
suite.Empty(listFollows)
}
// func (suite *ListTestSuite) TestPutListEntries() {
// ctx := context.Background()
// testList, testEntries, _ := suite.testStructs()
func (suite *ListTestSuite) TestPutListEntries() {
ctx := context.Background()
testList, testEntries, _ := suite.testStructs()
// listEntries := []*gtsmodel.ListEntry{
// {
// ID: "01H0MKMQY69HWDSDR2SWGA17R4",
// ListID: testList.ID,
// FollowID: "01H0MKNFRFZS8R9WV6DBX31Y03", // random id, doesn't exist
// },
// {
// ID: "01H0MKPGQF0E7QAVW5BKTHZ630",
// ListID: testList.ID,
// FollowID: "01H0MKP6RR8VEHN3GVWFBP2H30", // random id, doesn't exist
// },
// {
// ID: "01H0MKPPP2DT68FRBMR1FJM32T",
// ListID: testList.ID,
// FollowID: "01H0MKQ0KA29C6NFJ27GTZD16J", // random id, doesn't exist
// },
// }
listEntries := []*gtsmodel.ListEntry{
{
ID: "01H0MKMQY69HWDSDR2SWGA17R4",
ListID: testList.ID,
FollowID: "01H0MKNFRFZS8R9WV6DBX31Y03", // random id, doesn't exist
},
{
ID: "01H0MKPGQF0E7QAVW5BKTHZ630",
ListID: testList.ID,
FollowID: "01H0MKP6RR8VEHN3GVWFBP2H30", // random id, doesn't exist
},
{
ID: "01H0MKPPP2DT68FRBMR1FJM32T",
ListID: testList.ID,
FollowID: "01H0MKQ0KA29C6NFJ27GTZD16J", // random id, doesn't exist
},
}
// if err := suite.db.PutListEntries(ctx, listEntries); err != nil {
// suite.FailNow(err.Error())
// }
if err := suite.db.PutListEntries(ctx, listEntries); err != nil {
suite.FailNow(err.Error())
}
// // Add these entries to the test list.
// testEntries = append(testEntries, listEntries...)
// Get all follows stored under this list ID, to ensure
// the newly added list entry follows are among these.
followIDs, err := suite.db.GetFollowIDsInList(ctx, testList.ID, nil)
suite.NoError(err)
suite.Len(followIDs, len(testEntries)+len(listEntries))
suite.Contains(followIDs, "01H0MKNFRFZS8R9WV6DBX31Y03")
suite.Contains(followIDs, "01H0MKP6RR8VEHN3GVWFBP2H30")
suite.Contains(followIDs, "01H0MKQ0KA29C6NFJ27GTZD16J")
}
// // Now get all list entries from the db.
// // Use barebones for this because the ones
// // we just added will fail if we try to get
// // the nonexistent follows.
// dbListEntries, err := suite.db.GetListEntries(
// gtscontext.SetBarebones(ctx),
// testList.ID,
// "", "", "", 0)
// if err != nil {
// suite.FailNow(err.Error())
// }
func (suite *ListTestSuite) TestDeleteListEntry() {
ctx := context.Background()
testList, testEntries, _ := suite.testStructs()
// suite.checkListEntries(testList.ListEntries, dbListEntries)
// }
// Delete the first entry.
if err := suite.db.DeleteListEntry(ctx,
testEntries[0].ListID,
testEntries[0].FollowID,
); err != nil {
suite.FailNow(err.Error())
}
// func (suite *ListTestSuite) TestDeleteListEntry() {
// ctx := context.Background()
// testList, testEntries, _ := suite.testStructs()
// Get all follows stored under this list ID, to ensure
// the newly removed list entry follow is now missing.
followIDs, err := suite.db.GetFollowIDsInList(ctx, testList.ID, nil)
suite.NoError(err)
suite.Len(followIDs, len(testEntries)-1)
suite.NotContains(followIDs, testEntries[0].FollowID)
}
// // Get List in the cache first.
// if _, err := suite.db.GetListByID(ctx, testList.ID); err != nil {
// suite.FailNow(err.Error())
// }
func (suite *ListTestSuite) TestDeleteAllListEntriesByFollows() {
ctx := context.Background()
testList, testEntries, _ := suite.testStructs()
// // Delete the first entry.
// if err := suite.db.DeleteListEntry(ctx,
// testEntries[0].ListID,
// testEntries[0].FollowID,
// ); err != nil {
// suite.FailNow(err.Error())
// }
// Delete the first entry.
if err := suite.db.DeleteAllListEntriesByFollows(ctx,
testEntries[0].FollowID,
); err != nil {
suite.FailNow(err.Error())
}
// // Get list from the db again.
// dbList, err := suite.db.GetListByID(ctx, testList.ID)
// if err != nil {
// suite.FailNow(err.Error())
// }
// Get all follows stored under this list ID, to ensure
// the newly removed list entry follow is now missing.
followIDs, err := suite.db.GetFollowIDsInList(ctx, testList.ID, nil)
suite.NoError(err)
suite.Len(followIDs, len(testEntries)-1)
suite.NotContains(followIDs, testEntries[0].FollowID)
}
// // Bodge the testlist as though
// // we'd removed the first entry.
// testList.ListEntries = testList.ListEntries[1:]
// suite.checkList(testList, dbList)
// }
func (suite *ListTestSuite) TestListIncludesAccount() {
ctx := context.Background()
testList, _, _ := suite.testStructs()
// func (suite *ListTestSuite) TestDeleteAllListEntriesByFollowID() {
// ctx := context.Background()
// testList, testEntries, _ := suite.testStructs()
for accountID, expected := range map[string]bool{
suite.testAccounts["admin_account"].ID: true,
suite.testAccounts["local_account_1"].ID: false,
suite.testAccounts["local_account_2"].ID: true,
"01H7074GEZJ56J5C86PFB0V2CT": false,
} {
includes, err := suite.db.IsAccountInList(ctx, testList.ID, accountID)
if err != nil {
suite.FailNow(err.Error())
}
// // Get List in the cache first.
// if _, err := suite.db.GetListByID(ctx, testList.ID); err != nil {
// suite.FailNow(err.Error())
// }
// // Delete the first entry.
// if err := suite.db.DeleteAllListEntriesByFollowIDs(ctx, testEntries[0].FollowID); err != nil {
// suite.FailNow(err.Error())
// }
// // Get list from the db again.
// dbList, err := suite.db.GetListByID(ctx, testList.ID)
// if err != nil {
// suite.FailNow(err.Error())
// }
// // Bodge the testlist as though
// // we'd removed the first entry.
// testList.ListEntries = testList.ListEntries[1:]
// suite.checkList(testList, dbList)
// }
// func (suite *ListTestSuite) TestListIncludesAccount() {
// ctx := context.Background()
// testList, _, _ := suite.testStructs()
// for accountID, expected := range map[string]bool{
// suite.testAccounts["admin_account"].ID: true,
// suite.testAccounts["local_account_1"].ID: false,
// suite.testAccounts["local_account_2"].ID: true,
// "01H7074GEZJ56J5C86PFB0V2CT": false,
// } {
// includes, err := suite.db.IsAccountInList(ctx, testList.ID, accountID)
// if err != nil {
// suite.FailNow(err.Error())
// }
// if includes != expected {
// suite.FailNow("", "expected %t for accountID %s got %t", expected, accountID, includes)
// }
// }
// }
if includes != expected {
suite.FailNow("", "expected %t for accountID %s got %t", expected, accountID, includes)
}
}
}
func TestListTestSuite(t *testing.T) {
suite.Run(t, new(ListTestSuite))