[performance] bump codeberg.org/gruf/go-kv to v2 (#4341)

updates our codeberg.org/gruf/go-kv log key-value formatting library to latest version, which comes with some maaaaaaajor speed boosts in the form of:
- very minimal reflect.Value{} usage
- caching prepared formatting functions per type

~~still a work-in-progress until i make a release tag on the go-kv repository, which itself is waiting on published benchmark results in the README and finishing writing some code comments~~

benchmarks so far show this to be ~3x faster than the "fmt" stdlib package on average, when run across a wide variety (106 different types) of test cases, while still creating more visually friendly log output and actually recursing down nested struct ptrs

Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4341
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>

internal/admin/domainperms.go

@@ -22,7 +22,7 @@ import (
 	"errors"
 	"time"
 
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 
 	"code.superseriousbusiness.org/gotosocial/internal/ap"
 	"code.superseriousbusiness.org/gotosocial/internal/config"

internal/api/util/errorhandling.go

@@ -26,7 +26,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtscontext"
 	"code.superseriousbusiness.org/gotosocial/internal/gtserror"
 	"code.superseriousbusiness.org/gotosocial/internal/log"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 	"github.com/gin-gonic/gin"
 )
 

internal/cache/timeline/status_test.go

@@ -29,8 +29,8 @@ import (
 	apimodel "code.superseriousbusiness.org/gotosocial/internal/api/model"
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 	"code.superseriousbusiness.org/gotosocial/internal/id"
-	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/paging"
+	"codeberg.org/gruf/go-kv/v2"
 	"codeberg.org/gruf/go-structr"
 	"github.com/stretchr/testify/assert"
 )
@@ -440,7 +440,8 @@ func loadStatusIDsFrom(data []*StatusMeta) func(ids []string) ([]*gtsmodel.Statu
 				return s.ID == id
 			})
 			if i < 0 || i >= len(data) {
-				panic(fmt.Sprintf("could not find %s in %v", id, log.VarDump(data)))
+				kv := kv.Field{K: "data", V: data} // use kv.Field for formatting
+				panic(fmt.Sprintf("could not find %s in %v", id, kv))
 			}
 			statuses = append(statuses, &gtsmodel.Status{
 				ID:               data[i].ID,

internal/config/config_test.go

@@ -24,7 +24,7 @@ import (
 	"testing"
 
 	"code.superseriousbusiness.org/gotosocial/internal/config"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"github.com/stretchr/testify/assert"

internal/db/bundb/hook.go

@@ -22,7 +22,7 @@ import (
 	"time"
 
 	"code.superseriousbusiness.org/gotosocial/internal/log"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 	"github.com/uptrace/bun"
 )
 

internal/federation/authenticate.go

@@ -38,7 +38,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/httpsig"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 var (

internal/federation/dereferencing/thread.go

@@ -28,7 +28,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtserror"
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 	"code.superseriousbusiness.org/gotosocial/internal/log"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 // maxIter defines how many iterations of descendants or

internal/federation/federatingactor.go

@@ -35,7 +35,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/uris"
 	errorsv2 "codeberg.org/gruf/go-errors/v2"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 // federatingActor wraps the pub.FederatingActor

internal/federation/federatingprotocol.go

@@ -35,7 +35,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/uris"
 	"code.superseriousbusiness.org/gotosocial/internal/util/xslices"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 type errOtherIRIBlocked struct {

internal/gtscontext/log_hooks.go

@@ -21,7 +21,7 @@ import (
 	"context"
 
 	"code.superseriousbusiness.org/gotosocial/internal/log"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 func init() {

internal/id/ulid.go

@@ -23,7 +23,7 @@ import (
 	"time"
 
 	"code.superseriousbusiness.org/gotosocial/internal/log"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 	"github.com/oklog/ulid"
 )
 

internal/log/entry.go

@@ -21,7 +21,7 @@ import (
 	"context"
 	"fmt"
 
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 type Entry struct {

internal/log/format.go

@@ -1,29 +0,0 @@
-// GoToSocial
-// Copyright (C) GoToSocial Authors admin@gotosocial.org
-// SPDX-License-Identifier: AGPL-3.0-or-later
-//
-// This program is free software: you can redistribute it and/or modify
-// it under the terms of the GNU Affero General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// This program is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU Affero General Public License for more details.
-//
-// You should have received a copy of the GNU Affero General Public License
-// along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-package log
-
-import "codeberg.org/gruf/go-kv/format"
-
-// VarDump returns a serialized, useful log / error output of given variable.
-func VarDump(a any) string {
-	buf := getBuf()
-	format.Appendf(buf, "{:v}", a)
-	s := string(buf.B)
-	putBuf(buf)
-	return s
-}

internal/log/log.go

@@ -26,7 +26,7 @@ import (
 	"time"
 
 	"code.superseriousbusiness.org/gotosocial/internal/util/xslices"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 var (

internal/media/processingmedia.go

@@ -22,7 +22,7 @@ import (
 	"os"
 
 	errorsv2 "codeberg.org/gruf/go-errors/v2"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 	"codeberg.org/gruf/go-runners"
 
 	"code.superseriousbusiness.org/gotosocial/internal/config"

internal/middleware/logger.go

@@ -28,7 +28,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/util"
 	"codeberg.org/gruf/go-bytesize"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 	"github.com/gin-gonic/gin"
 )
 

internal/observability/tracing.go

@@ -26,7 +26,7 @@ import (
 	"net/http"
 	"strconv"
 
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 
 	"github.com/gin-gonic/gin"
 

internal/processing/account/delete.go

@@ -31,7 +31,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/messages"
 	"code.superseriousbusiness.org/gotosocial/internal/util"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 	"github.com/google/uuid"
 	"golang.org/x/crypto/bcrypt"
 )

internal/processing/search/accounts.go

@@ -29,7 +29,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/id"
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/util"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 // Accounts does a partial search for accounts that

internal/processing/search/get.go

@@ -34,7 +34,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/text"
 	"code.superseriousbusiness.org/gotosocial/internal/util"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 const (

internal/processing/search/lookup.go

@@ -28,7 +28,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/util"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 // Lookup does a quick, non-resolving search for accounts that

internal/processing/stream/open.go

@@ -24,7 +24,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 	"code.superseriousbusiness.org/gotosocial/internal/log"
 	"code.superseriousbusiness.org/gotosocial/internal/stream"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 // Open returns a new Stream for the given account, which will contain a channel for passing messages back to the caller.

internal/processing/workers/fromclientapi.go

@@ -36,7 +36,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/typeutils"
 	"code.superseriousbusiness.org/gotosocial/internal/uris"
 	"code.superseriousbusiness.org/gotosocial/internal/util"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 )
 
 // clientAPI wraps processing functions

internal/processing/workers/fromfediapi.go

@@ -29,7 +29,7 @@ import (
 	"code.superseriousbusiness.org/gotosocial/internal/gtscontext"
 	"code.superseriousbusiness.org/gotosocial/internal/id"
 	"code.superseriousbusiness.org/gotosocial/internal/uris"
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 
 	"code.superseriousbusiness.org/gotosocial/internal/gtserror"
 	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"

internal/subscriptions/domainperms.go

@@ -30,7 +30,7 @@ import (
 	"strings"
 	"time"
 
-	"codeberg.org/gruf/go-kv"
+	"codeberg.org/gruf/go-kv/v2"
 
 	"code.superseriousbusiness.org/gotosocial/internal/admin"
 	apimodel "code.superseriousbusiness.org/gotosocial/internal/api/model"