Enable stricter linting with golangci-lint (#316)

* update golangci-lint

* add golangci config file w/ more linters

* correct issues flagged by stricter linters

* add more generous timeout for golangci-lint

* add some style + formatting guidelines

* move timeout to config file

* go fmt
This commit is contained in:
tobi 2021-11-22 08:46:19 +01:00 committed by GitHub
commit f8630348b4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
47 changed files with 227 additions and 163 deletions

View file

@ -127,7 +127,7 @@ func (t *timeline) GetXFromTop(ctx context.Context, amount int) ([]*apimodel.Sta
return nil, errors.New("GetXFromTop: could not parse e as a preparedPostsEntry")
}
statuses = append(statuses, entry.prepared)
served = served + 1
served++
if served >= amount {
break
}
@ -145,7 +145,7 @@ func (t *timeline) GetXBehindID(ctx context.Context, amount int, behindID string
})
newAttempts := *attempts
newAttempts = newAttempts + 1
newAttempts++
attempts = &newAttempts
// make a slice of statuses with the length we need to return
@ -161,7 +161,7 @@ func (t *timeline) GetXBehindID(ctx context.Context, amount int, behindID string
findMarkLoop:
for e := t.preparedPosts.data.Front(); e != nil; e = e.Next() {
position = position + 1
position++
entry, ok := e.Value.(*preparedPostsEntry)
if !ok {
return nil, errors.New("GetXBehindID: could not parse e as a preparedPostsEntry")
@ -218,7 +218,7 @@ serveloop:
// serve up to the amount requested
statuses = append(statuses, entry.prepared)
served = served + 1
served++
if served >= amount {
break serveloop
}
@ -272,7 +272,7 @@ findMarkLoop:
// serve up to the amount requested
statuses = append(statuses, entry.prepared)
served = served + 1
served++
if served >= amount {
break serveloopFromTop
}
@ -288,7 +288,7 @@ findMarkLoop:
// serve up to the amount requested
statuses = append(statuses, entry.prepared)
served = served + 1
served++
if served >= amount {
break serveloopFromBottom
}
@ -311,7 +311,7 @@ func (t *timeline) GetXBetweenID(ctx context.Context, amount int, behindID strin
var behindIDMark *list.Element
findMarkLoop:
for e := t.preparedPosts.data.Front(); e != nil; e = e.Next() {
position = position + 1
position++
entry, ok := e.Value.(*preparedPostsEntry)
if !ok {
return nil, errors.New("GetXBetweenID: could not parse e as a preparedPostsEntry")
@ -350,7 +350,7 @@ serveloop:
// serve up to the amount requested
statuses = append(statuses, entry.prepared)
served = served + 1
served++
if served >= amount {
break serveloop
}