[bugfix] Fix Swagger spec and add test script (#2698)

* Add Swagger spec test script

* Fix Swagger spec errors not related to statuses with polls

* Add API tests that post a status with a poll

* Fix creating a status with a poll from form params

* Fix Swagger spec errors related to statuses with polls (this is the last error)

* Fix Swagger spec warnings not related to unused definitions

* Suppress a duplicate list update params definition that was somehow causing wrong param names

* Add Swagger test to CI

- updates Drone config
- vendorizes go-swagger
- fixes a file extension issue that caused the test script to generate JSON instead of YAML with the vendorized version

* Put `Sample: ` on its own line everywhere

* Remove unused id param from emojiCategoriesGet

* Add 5 more pairs of profile fields to account update API Swagger

* Remove Swagger prefix from dummy fields

It makes the generated code look weird

* Manually annotate params for statusCreate operation

* Fix all remaining Swagger spec warnings

- Change some models into operation parameters
- Ignore models that already correspond to manually documented operation parameters but can't be trivially changed (those with file fields)

* Documented that creating a status with scheduled_at isn't implemented yet

* sign drone.yml

* Fix filter API Swagger errors

* fixup! Fix filter API Swagger errors

---------

Co-authored-by: tobi <tobi.smethurst@protonmail.com>

vendor/github.com/go-swagger/go-swagger/codescan/spec.go

@@ -0,0 +1,258 @@
+package codescan
+
+import (
+	"go/ast"
+
+	"github.com/go-openapi/spec"
+)
+
+func newSpecBuilder(input *spec.Swagger, sc *scanCtx, scanModels bool) *specBuilder {
+	if input == nil {
+		input = new(spec.Swagger)
+		input.Swagger = "2.0"
+	}
+
+	if input.Paths == nil {
+		input.Paths = new(spec.Paths)
+	}
+	if input.Definitions == nil {
+		input.Definitions = make(map[string]spec.Schema)
+	}
+	if input.Responses == nil {
+		input.Responses = make(map[string]spec.Response)
+	}
+	if input.Extensions == nil {
+		input.Extensions = make(spec.Extensions)
+	}
+
+	return &specBuilder{
+		ctx:         sc,
+		input:       input,
+		scanModels:  scanModels,
+		operations:  collectOperationsFromInput(input),
+		definitions: input.Definitions,
+		responses:   input.Responses,
+	}
+}
+
+type specBuilder struct {
+	scanModels  bool
+	input       *spec.Swagger
+	ctx         *scanCtx
+	discovered  []*entityDecl
+	definitions map[string]spec.Schema
+	responses   map[string]spec.Response
+	operations  map[string]*spec.Operation
+}
+
+func (s *specBuilder) Build() (*spec.Swagger, error) {
+	if err := s.buildModels(); err != nil {
+		return nil, err
+	}
+
+	if err := s.buildParameters(); err != nil {
+		return nil, err
+	}
+
+	if err := s.buildRespones(); err != nil {
+		return nil, err
+	}
+
+	// build definitions dictionary
+	if err := s.buildDiscovered(); err != nil {
+		return nil, err
+	}
+
+	if err := s.buildRoutes(); err != nil {
+		return nil, err
+	}
+
+	if err := s.buildOperations(); err != nil {
+		return nil, err
+	}
+
+	if err := s.buildMeta(); err != nil {
+		return nil, err
+	}
+
+	if s.input.Swagger == "" {
+		s.input.Swagger = "2.0"
+	}
+
+	return s.input, nil
+}
+
+func (s *specBuilder) buildDiscovered() error {
+	// loop over discovered until all the items are in definitions
+	keepGoing := len(s.discovered) > 0
+	for keepGoing {
+		var queue []*entityDecl
+		for _, d := range s.discovered {
+			nm, _ := d.Names()
+			if _, ok := s.definitions[nm]; !ok {
+				queue = append(queue, d)
+			}
+		}
+		s.discovered = nil
+		for _, sd := range queue {
+			if err := s.buildDiscoveredSchema(sd); err != nil {
+				return err
+			}
+		}
+		keepGoing = len(s.discovered) > 0
+	}
+
+	return nil
+}
+
+func (s *specBuilder) buildDiscoveredSchema(decl *entityDecl) error {
+	sb := &schemaBuilder{
+		ctx:        s.ctx,
+		decl:       decl,
+		discovered: s.discovered,
+	}
+	if err := sb.Build(s.definitions); err != nil {
+		return err
+	}
+	s.discovered = append(s.discovered, sb.postDecls...)
+	return nil
+}
+
+func (s *specBuilder) buildMeta() error {
+	// build swagger object
+	for _, decl := range s.ctx.app.Meta {
+		if err := newMetaParser(s.input).Parse(decl.Comments); err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
+func (s *specBuilder) buildOperations() error {
+	for _, pp := range s.ctx.app.Operations {
+		ob := &operationsBuilder{
+			operations: s.operations,
+			ctx:        s.ctx,
+			path:       pp,
+		}
+		if err := ob.Build(s.input.Paths); err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
+func (s *specBuilder) buildRoutes() error {
+	// build paths dictionary
+	for _, pp := range s.ctx.app.Routes {
+		rb := &routesBuilder{
+			ctx:         s.ctx,
+			route:       pp,
+			responses:   s.responses,
+			operations:  s.operations,
+			definitions: s.definitions,
+		}
+		if err := rb.Build(s.input.Paths); err != nil {
+			return err
+		}
+	}
+
+	return nil
+}
+
+func (s *specBuilder) buildRespones() error {
+	// build responses dictionary
+	for _, decl := range s.ctx.app.Responses {
+		rb := &responseBuilder{
+			ctx:  s.ctx,
+			decl: decl,
+		}
+		if err := rb.Build(s.responses); err != nil {
+			return err
+		}
+		s.discovered = append(s.discovered, rb.postDecls...)
+	}
+	return nil
+}
+
+func (s *specBuilder) buildParameters() error {
+	// build parameters dictionary
+	for _, decl := range s.ctx.app.Parameters {
+		pb := &parameterBuilder{
+			ctx:  s.ctx,
+			decl: decl,
+		}
+		if err := pb.Build(s.operations); err != nil {
+			return err
+		}
+		s.discovered = append(s.discovered, pb.postDecls...)
+	}
+	return nil
+}
+
+func (s *specBuilder) buildModels() error {
+	// build models dictionary
+	if !s.scanModels {
+		return nil
+	}
+
+	for _, decl := range s.ctx.app.Models {
+		if err := s.buildDiscoveredSchema(decl); err != nil {
+			return err
+		}
+	}
+
+	return s.joinExtraModels()
+}
+
+func (s *specBuilder) joinExtraModels() error {
+	tmp := make(map[*ast.Ident]*entityDecl, len(s.ctx.app.ExtraModels))
+	for k, v := range s.ctx.app.ExtraModels {
+		tmp[k] = v
+		s.ctx.app.Models[k] = v
+		delete(s.ctx.app.ExtraModels, k)
+	}
+
+	// process extra models and see if there is any reference to a new extra one
+	for _, decl := range tmp {
+		if err := s.buildDiscoveredSchema(decl); err != nil {
+			return err
+		}
+	}
+
+	if len(s.ctx.app.ExtraModels) > 0 {
+		return s.joinExtraModels()
+	}
+
+	return nil
+}
+
+func collectOperationsFromInput(input *spec.Swagger) map[string]*spec.Operation {
+	operations := make(map[string]*spec.Operation)
+	if input != nil && input.Paths != nil {
+		for _, pth := range input.Paths.Paths {
+			if pth.Get != nil {
+				operations[pth.Get.ID] = pth.Get
+			}
+			if pth.Post != nil {
+				operations[pth.Post.ID] = pth.Post
+			}
+			if pth.Put != nil {
+				operations[pth.Put.ID] = pth.Put
+			}
+			if pth.Patch != nil {
+				operations[pth.Patch.ID] = pth.Patch
+			}
+			if pth.Delete != nil {
+				operations[pth.Delete.ID] = pth.Delete
+			}
+			if pth.Head != nil {
+				operations[pth.Head.ID] = pth.Head
+			}
+			if pth.Options != nil {
+				operations[pth.Options.ID] = pth.Options
+			}
+		}
+	}
+	return operations
+}