[bugfix] boost and account recursion (#2982)

* fix possible infinite recursion if moved accounts are self-referential

* adds a defensive check for a boost being a boost of a boost wrapper

* add checks on input for a boost of a boost

* remove unnecessary check

* add protections on account move to prevent move recursion loops

* separate status conversion without boost logic into separate function to remove risk of recursion

* move boost check to boost function itself

* formatting

* use error 422 instead of 500

* use gtserror not standard errors package for error creation
This commit is contained in:
kim 2024-06-10 18:42:41 +00:00 committed by GitHub
commit fd6637df4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 244 additions and 127 deletions

View file

@ -161,7 +161,7 @@ func (suite *MoveTestSuite) TestMoveAccountBadPassword() {
MovedToURI: targetAcct.URI,
},
)
suite.EqualError(err, "invalid password provided in account Move request")
suite.EqualError(err, "invalid password provided in Move request")
}
func TestMoveTestSuite(t *testing.T) {