gotosocial/web/source/settings/views/user/profile/profile.tsx
ptrcnull 0a32fc0980 [bugfix] prevent clicking Enter in description field from deleting the image (#4436)
# Description

Change the type of "Delete header" / "Delete avatar" button to just "button" to prevent them from getting deleted if user presses Enter in the description field.

Closes https://codeberg.org/superseriousbusiness/gotosocial/issues/4363

## Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]`

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

- [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md).
- [ ] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
- [x] I/we have not leveraged AI to create the proposed changes.
- [x] I/we have performed a self-review of added code.
- [x] I/we have written code that is legible and maintainable by others.
- [ ] I/we have commented the added code, particularly in hard-to-understand areas.
- [x] I/we have made any necessary changes to documentation.
- [ ] I/we have added tests that cover new code.
- [ ] I/we have run tests and they pass locally with the changes.
- [x] I/we have run `go fmt ./...` and `golangci-lint run`.

Co-authored-by: ptrcnull <git@ptrcnull.me>
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4436
Co-authored-by: ptrcnull <ptrcnull@noreply.codeberg.org>
Co-committed-by: ptrcnull <ptrcnull@noreply.codeberg.org>
2025-09-16 14:30:00 +02:00

393 lines
11 KiB
TypeScript

/*
GoToSocial
Copyright (C) GoToSocial Authors admin@gotosocial.org
SPDX-License-Identifier: AGPL-3.0-or-later
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Affero General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Affero General Public License for more details.
You should have received a copy of the GNU Affero General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
import React, { useMemo, useState } from "react";
import {
useTextInput,
useFileInput,
useBoolInput,
useFieldArrayInput,
} from "../../../lib/form";
import useFormSubmit from "../../../lib/form/submit";
import { useWithFormContext, FormContext } from "../../../lib/form/context";
import {
TextInput,
TextArea,
FileInput,
Checkbox,
Select
} from "../../../components/form/inputs";
import FormWithData from "../../../lib/form/form-with-data";
import FakeProfile from "../../../components/profile";
import MutationButton from "../../../components/form/mutation-button";
import {
useAccountThemesQuery,
useDeleteAvatarMutation,
useDeleteHeaderMutation,
} from "../../../lib/query/user";
import { useUpdateCredentialsMutation } from "../../../lib/query/user";
import { useVerifyCredentialsQuery } from "../../../lib/query/login";
import { useInstanceV1Query } from "../../../lib/query/gts-api";
import { Account } from "../../../lib/types/account";
export default function Profile() {
return (
<FormWithData
dataQuery={useVerifyCredentialsQuery}
DataForm={ProfileForm}
/>
);
}
interface ProfileFormProps {
data: Account;
}
function ProfileForm({ data: profile }: ProfileFormProps) {
const { data: instance } = useInstanceV1Query();
const instanceConfig = React.useMemo(() => {
return {
allowCustomCSS: instance?.configuration?.accounts?.allow_custom_css === true,
maxPinnedFields: instance?.configuration?.accounts?.max_profile_fields ?? 6
};
}, [instance]);
// Parse out available theme options into nice format.
const { data: themes } = useAccountThemesQuery();
const themeOptions = useMemo(() => {
let themeOptions = [
<option key="" value="">
Default
</option>
];
themes?.forEach((theme) => {
const value = theme.file_name;
let text = theme.title;
if (theme.description) {
text += " - " + theme.description;
}
themeOptions.push(
<option key={value} value={value}>
{text}
</option>
);
});
return themeOptions;
}, [themes]);
const form = {
avatar: useFileInput("avatar", { withPreview: true }),
avatarDescription: useTextInput("avatar_description", { source: profile }),
header: useFileInput("header", { withPreview: true }),
headerDescription: useTextInput("header_description", { source: profile }),
displayName: useTextInput("display_name", { source: profile }),
note: useTextInput("note", { source: profile, valueSelector: (p) => p.source?.note }),
bot: useBoolInput("bot", { source: profile }),
locked: useBoolInput("locked", { source: profile }),
discoverable: useBoolInput("discoverable", { source: profile}),
enableRSS: useBoolInput("enable_rss", { source: profile }),
hideCollections: useBoolInput("hide_collections", { source: profile }),
webVisibility: useTextInput("web_visibility", { source: profile, valueSelector: (p: Account) => p.source?.web_visibility }),
webLayout: useTextInput("web_layout", { source: profile, valueSelector: (p: Account) => p.source?.web_layout }),
fields: useFieldArrayInput("fields_attributes", {
defaultValue: profile?.source?.fields,
length: instanceConfig.maxPinnedFields
}),
customCSS: useTextInput("custom_css", { source: profile, nosubmit: !instanceConfig.allowCustomCSS }),
theme: useTextInput("theme", { source: profile }),
};
const [ noHeader, setNoHeader ] = useState(!profile.header_media_id);
const [ deleteHeader, deleteHeaderRes ] = useDeleteHeaderMutation();
const [ noAvatar, setNoAvatar ] = useState(!profile.avatar_media_id);
const [ deleteAvatar, deleteAvatarRes ] = useDeleteAvatarMutation();
const [submitForm, result] = useFormSubmit(form, useUpdateCredentialsMutation(), {
changedOnly: true,
onFinish: (res) => {
if ('data' in res) {
form.avatar.reset();
form.header.reset();
setNoAvatar(!res.data.avatar_media_id);
setNoHeader(!res.data.header_media_id);
}
}
});
return (
<form className="user-profile" onSubmit={submitForm}>
<div className="form-section-docs">
<h1>Profile</h1>
<p>
On this page you can change various settings relating to the appearance and discoverability of your profile and posts.
<br/>After changing settings and/or uploading a new avatar or header, be sure to scroll to the bottom of this page and click "Save profile info" to confirm your changes.
</p>
<a
href="https://docs.gotosocial.org/en/latest/user_guide/settings/#profile"
target="_blank"
className="docslink"
rel="noreferrer"
>
Learn more about this settings page (opens in a new tab)
</a>
</div>
<div className="overview">
<FakeProfile
avatar={form.avatar.previewValue ?? profile.avatar}
header={form.header.previewValue ?? profile.header}
display_name={form.displayName.value ?? profile.username}
bot={profile.bot}
username={profile.username}
role={profile.role}
/>
<fieldset className="file-input-with-image-description">
<legend>Header</legend>
<FileInput
label="Upload file"
field={form.header}
accept="image/png, image/jpeg, image/webp, image/gif"
/>
<TextInput
field={form.headerDescription}
label="Image description; only settable if not using default header"
placeholder="A green field with pink flowers."
autoCapitalize="sentences"
disabled={noHeader && !form.header.value}
/>
<MutationButton
className="delete-header-button"
label="Delete header"
tabIndex={0}
disabled={noHeader}
result={deleteHeaderRes}
submit={false}
onClick={(e) => {
e.preventDefault();
deleteHeader().then(res => {
if ('data' in res) {
setNoHeader(true);
}
});
}}
/>
</fieldset>
<fieldset className="file-input-with-image-description">
<legend>Avatar</legend>
<FileInput
label="Upload file (1:1 images look best)"
field={form.avatar}
accept="image/png, image/jpeg, image/webp, image/gif"
/>
<TextInput
field={form.avatarDescription}
label="Image description; only settable if not using default avatar"
placeholder="A cute drawing of a smiling sloth."
autoCapitalize="sentences"
disabled={noAvatar && !form.avatar.value}
/>
<MutationButton
className="delete-avatar-button"
label="Delete avatar"
tabIndex={0}
disabled={noAvatar}
result={deleteAvatarRes}
submit={false}
onClick={(e) => {
e.preventDefault();
deleteAvatar().then(res => {
if ('data' in res) {
setNoAvatar(true);
}
});
}}
/>
</fieldset>
<span>After choosing theme or layout and saving, <a href={profile.url} target="_blank">open your profile</a> and refresh to see changes.</span>
<Select
label="Theme for the web view of your profile"
field={form.theme}
options={<>{themeOptions}</>}
/>
<Select
field={form.webLayout}
label="Layout for the web view of your profile"
options={
<>
<option value="microblog">Classic microblog layout (show recent + pinned posts; media shown alongside its parent post)</option>
<option value="gallery">'Gram-style gallery layout (show recent + pinned media; parent posts still accessible by link)</option>
</>
}
/>
</div>
<div className="form-section-docs">
<h3>Basic Information</h3>
<a
href="https://docs.gotosocial.org/en/latest/user_guide/settings/#basic-information"
target="_blank"
className="docslink"
rel="noreferrer"
>
Learn more about these settings (opens in a new tab)
</a>
</div>
<Checkbox
field={form.bot}
label="Mark as bot account; this indicates to other users that this is an automated account"
/>
<TextInput
field={form.displayName}
label="Display name"
placeholder="A GoToSocial User"
autoCapitalize="words"
spellCheck="false"
/>
<TextArea
field={form.note}
label="Bio"
placeholder="Just trying out GoToSocial, my pronouns are they/them and I like sloths."
autoCapitalize="sentences"
rows={8}
/>
<fieldset>
<legend>Profile fields</legend>
<ProfileFields
field={form.fields}
/>
</fieldset>
<div className="form-section-docs">
<h3>Visibility and privacy</h3>
<a
href="https://docs.gotosocial.org/en/latest/user_guide/settings/#visibility-and-privacy"
target="_blank"
className="docslink"
rel="noreferrer"
>
Learn more about these settings (opens in a new tab)
</a>
</div>
<Select
field={form.webVisibility}
label="Visibility level of posts to show on your profile web page, and in your RSS feed (if enabled)."
options={
<>
<option value="public">Show Public posts only (the GoToSocial default)</option>
<option value="unlisted">Show Public and Unlisted posts (the Mastodon default)</option>
<option value="none">Show no posts</option>
</>
}
/>
<Checkbox
field={form.locked}
label="Manually approve follow requests."
/>
<Checkbox
field={form.discoverable}
label="Mark account as discoverable by search engines and directories."
/>
<Checkbox
field={form.enableRSS}
label="Enable RSS feed of posts."
/>
<Checkbox
field={form.hideCollections}
label="Hide who you follow / are followed by."
/>
<div className="form-section-docs">
<h3>Advanced</h3>
<a
href="https://docs.gotosocial.org/en/latest/user_guide/settings/#advanced"
target="_blank"
className="docslink"
rel="noreferrer"
>
Learn more about these settings (opens in a new tab)
</a>
</div>
<TextArea
field={form.customCSS}
label={`Custom CSS` + (!instanceConfig.allowCustomCSS ? ` (not enabled on this instance)` : ``)}
className="monospace"
rows={8}
disabled={!instanceConfig.allowCustomCSS}
autoCapitalize="none"
spellCheck="false"
/>
<MutationButton
disabled={false}
label="Save profile info"
result={result}
/>
</form>
);
}
function ProfileFields({ field: formField }) {
return (
<div className="fields">
<FormContext.Provider value={formField.ctx}>
{formField.value.map((data, i) => (
<Field
key={i}
index={i}
data={data}
/>
))}
</FormContext.Provider>
</div>
);
}
function Field({ index, data }) {
const form = useWithFormContext(index, {
name: useTextInput("name", { defaultValue: data.name }),
value: useTextInput("value", { defaultValue: data.value })
});
return (
<div className="entry">
<TextInput
field={form.name}
placeholder="Name"
autoCapitalize="none"
spellCheck="false"
/>
<TextInput
field={form.value}
placeholder="Value"
autoCapitalize="none"
spellCheck="false"
/>
</div>
);
}