mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2025-10-29 09:42:26 -05:00
# Description This is quite a complex database migration that updates the `statuses.thread_id` column to be notnull, in order that statuses always be threaded, which will be useful in various pieces of upcoming work. This is unfortunately a migration that acts over the entire statuses table, and is quite complex in order to ensure that all existing statuses get correctly threaded together, and where possible fix any issues of statuses in the same thread having incorrect thread_ids. TODO: - ~~update testrig models to all be threaded~~ - ~~update code to ensure thread_id is always set~~ - ~~run on **a copy** of an sqlite production database~~ - ~~run on **a copy** of a postgres production database~~ ## Checklist - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [x] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4160 Co-authored-by: kim <grufwub@gmail.com> Co-committed-by: kim <grufwub@gmail.com> |
||
|---|---|---|
| .. | ||
| 20211113114307_init | ||
| 20220214175650_media_cleanup | ||
| 20220315160814_admin_account_actions | ||
| 20220905150505_custom_emoji_updates | ||
| 20230328203024_migration_fix | ||
| 20230521105850_emoji_empty_domain_fix | ||
| 20231002153327_add_status_polls | ||
| 20231016113235_mute_status_thread | ||
| 20240126064004_add_filters | ||
| 20240318115336_account_settings | ||
| 20240620074530_interaction_policy | ||
| 20240715204203_media_pipeline_improvements | ||
| 20240809134448_interaction_requests_client_api | ||
| 20240904084406_fedi_api_reject_interaction | ||
| 20241022153016_domain_permission_draft_exclude | ||
| 20241022153016_domain_permission_subscriptions | ||
| 20241113152126_add_status_edits | ||
| 20241121121623_enum_strings_to_ints | ||
| 20250106114512_replace_statuses_updatedat_with_editedat | ||
| 20250224105654_token_app_client_refactor | ||
| 20250226013442_add_status_content_type | ||
| 20250305205820_content_warning_fixes | ||
| 20250321131230_relax_account_uri_uniqueness | ||
| 20250324173534_2fa | ||
| 20250415111056_thread_all_statuses | ||
| 20211113114307_init.go | ||
| 20220214175650_media_cleanup.go | ||
| 20220305130328_database_optimizations.go | ||
| 20220315160814_admin_account_actions.go | ||
| 20220502113806_add_missing_indexes.go | ||
| 20220506110822_add_account_raw_note.go | ||
| 20220511165212_add_account_raw_note_fix.go | ||
| 20220518123621_additional_indexing.go | ||
| 20220612091800_duplicated_media_cleanup.go | ||
| 20220710153020_fix_slow_web_profile_queries.go | ||
| 20220804120132_account_default_post_format.go | ||
| 20220823140228_user_custom_css.go | ||
| 20220827085121_assign_missing_in_reply_to_uris.go | ||
| 20220830014732_regenerate_indexes_for_follows.go | ||
| 20220903141016_store_gifs_as_image.go | ||
| 20220905150505_custom_emoji_updates.go | ||
| 20220916122701_emojis_in_accounts.go | ||
| 20220922142408_shared_inbox_delivery.go | ||
| 20220926115233_indexes.go | ||
| 20221006114842_add_rss_functionality.go | ||
| 20221011125732_refetch_updated_emojis.go | ||
| 20221031145649_emoji_categories.go | ||
| 20221103203553_add_external_id.go | ||
| 20221108142419_create_account_tombstones.go | ||
| 20221220134514_mp4_jiggery_pokery.go | ||
| 20230105171144_report_model.go | ||
| 20230126170719_format_to_content_type.go | ||
| 20230202212700_rename_account_webfingered_to_fetched.go | ||
| 20230221150957_status_pin_client_api.go | ||
| 20230328203024_migration_fix.go | ||
| 20230405130021_status_fave_unique_constraints.go | ||
| 20230430105735_fieldwork.go | ||
| 20230511181430_add_status_fetched_at.go | ||
| 20230515173919_lists.go | ||
| 20230521105850_emoji_empty_domain_fix.go | ||
| 20230620103932_search_updates.go | ||
| 20230711214815_account_notes.go | ||
| 20230713025939_markers_api.go | ||
| 20230718161520_hashtaggery.go | ||
| 20230724100000_emoji_cleanup.go | ||
| 20230815164500_rules_model.go | ||
| 20230817174700_add_report_rule_ids.go | ||
| 20230821075342_attachment_cleanup_updates.go | ||
| 20230828101322_admin_action_locking.go | ||
| 20230905133904_remote_pubkey_expiry.go | ||
| 20230908083121_allowlist.go.go | ||
| 20231002153327_add_status_polls.go | ||
| 20231016113235_mute_status_thread.go | ||
| 20231029143819_remove_suspended_at_index.go | ||
| 20231110142330_small_poll_table_tweaks.go | ||
| 20231128140847_remove_duplicate_indices.go | ||
| 20231130103643_fix_index_whoopsie.go | ||
| 20231208152242_sqlite_analyze.go | ||
| 20231212144715_add_header_filters.go | ||
| 20231215115920_add_status_poll_index.go | ||
| 20231227110845_instance_description_updates.go | ||
| 20240103170945_moved_to_also_known_as.go | ||
| 20240114112637_postgres_header_filter_fix.go | ||
| 20240126064004_add_filters.go | ||
| 20240129170725_moved_to_also_known_as.go | ||
| 20240220204526_add_statuses_mentions_is_null_or_empty_idx.go | ||
| 20240228113608_readd_statuses_account_id_id_idx.go | ||
| 20240310120046_fix_empty_move_id.go | ||
| 20240318115336_account_settings.go | ||
| 20240320114447_preset_css_themes.go | ||
| 20240401130338_sign_up.go | ||
| 20240402113305_nil_domain_fix.go | ||
| 20240414122348_account_stats_model.go | ||
| 20240426122821_pageable_admin_accounts.go | ||
| 20240528071620_add_user_mutes.go | ||
| 20240611190733_add_conversations.go | ||
| 20240613091853_drop_unused_media_columns.go | ||
| 20240617134210_add_worker_tasks_table.go | ||
| 20240620074530_interaction_policy.go | ||
| 20240712005536_add_advanced_migrations.go | ||
| 20240715204203_media_pipeline_improvements.go | ||
| 20240716151327_interaction_policy.go | ||
| 20240722222556_remove_boost_content.go | ||
| 20240725211933_add_followed_tags.go | ||
| 20240809134448_interaction_requests_client_api.go | ||
| 20240903212842_add_exclusive_lists.go | ||
| 20240904084406_fedi_api_reject_interaction.go | ||
| 20240906144432_unauthed_visibility.go.go | ||
| 20240924222938_add_instance_custom_css.go | ||
| 20241005100438_interaction_requests_pending_tweak.go | ||
| 20241011115713_pending_approval_fix.go | ||
| 20241018151036_filter_unique_fix.go | ||
| 20241022153016_domain_permission_draft_exclude.go | ||
| 20241113151042_remove_mention_updated_at.go | ||
| 20241113152126_add_status_edits.go | ||
| 20241121121623_enum_strings_to_ints.go | ||
| 20241124012635_add_vapid_key_pairs.go | ||
| 20241124012636_add_web_push_subscriptions.go | ||
| 20241203124608_remove_media_attachment_updated_at.go | ||
| 20250106114512_replace_statuses_updatedat_with_editedat.go | ||
| 20250106165529_cleanup_dropped_edits.go | ||
| 20250119112745_domain_permission_subscriptions.go | ||
| 20250119112746_domain_perm_sub_caching_tweaks.go | ||
| 20250124164400_domain_perm_sub_migration_fix.go | ||
| 20250126162825_top_level_mention_replies_fix.go | ||
| 20250131184755_add_web_push_subscription_policy.go | ||
| 20250224105654_token_app_client_refactor.go | ||
| 20250226013442_add_status_content_type.go | ||
| 20250305205820_content_warning_fixes.go | ||
| 20250310094108_statuses_count_query_optimize.go | ||
| 20250310144102_application_management.go | ||
| 20250314120945_add_gallery_web_layout.go | ||
| 20250318093828_statuses_public_timeline_reindex.go | ||
| 20250321131230_relax_account_uri_uniqueness.go | ||
| 20250324173534_2fa.go | ||
| 20250415111056_thread_all_statuses.go | ||
| main.go | ||
| README.md | ||
| util.go | ||
Migrations
How do I write a migration file?
As a template, take one of the existing migration files and modify it, or use the below code snippet:
// GoToSocial
// Copyright (C) GoToSocial Authors admin@gotosocial.org
// SPDX-License-Identifier: AGPL-3.0-or-later
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
package migrations
import (
"context"
"github.com/uptrace/bun"
)
func init() {
up := func(ctx context.Context, db *bun.DB) error {
return db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error {
// your logic here
return nil
})
}
down := func(ctx context.Context, db *bun.DB) error {
return db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error {
// your logic here
return nil
})
}
if err := Migrations.Register(up, down); err != nil {
panic(err)
}
}
File format
Bun requires a very specific format: 14 digits, then letters or underscores.
You can use the following bash command on your branch to generate a suitable migration filename.
echo "$(date --utc +%Y%m%d%H%M%S | head -c 14)_$(git rev-parse --abbrev-ref HEAD).go"
Rules of thumb
- DON'T DROP TABLES!!!!!!!!
- Don't make something
NOT NULLif it's likely to already containnullfields.