mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-11-01 01:42:25 -05:00 
			
		
		
		
	* start work rewriting timeline cache type
* further work rewriting timeline caching
* more work integration new timeline code
* remove old code
* add local timeline, fix up merge conflicts
* remove old use of go-bytes
* implement new timeline code into more areas of codebase, pull in latest go-mangler, go-mutexes, go-structr
* remove old timeline package, add local timeline cache
* remove references to old timeline types that needed starting up in tests
* start adding page validation
* fix test-identified timeline cache package issues
* fix up more tests, fix missing required changes, etc
* add exclusion for test.out in gitignore
* clarify some things better in code comments
* tweak cache size limits
* fix list timeline cache fetching
* further list timeline fixes
* linter, ssssssssshhhhhhhhhhhh please
* fix linter hints
* reslice the output if it's beyond length of 'lim'
* remove old timeline initialization code, bump go-structr to v0.9.4
* continued from previous commit
* improved code comments
* don't allow multiple entries for BoostOfID values to prevent repeated boosts of same boosts
* finish writing more code comments
* some variable renaming, for ease of following
* change the way we update lo,hi paging values during timeline load
* improved code comments for updated / returned lo , hi paging values
* finish writing code comments for the StatusTimeline{} type itself
* fill in more code comments
* update go-structr version to latest with changed timeline unique indexing logic
* have a local and public timeline *per user*
* rewrite calls to public / local timeline calls
* remove the zero length check, as lo, hi values might still be set
* simplify timeline cache loading, fix lo/hi returns, fix timeline invalidation side-effects missing for some federated actions
* swap the lo, hi values 🤦
* add (now) missing slice reverse of tag timeline statuses when paging ASC
* remove local / public caches (is out of scope for this work), share more timeline code
* remove unnecessary change
* again, remove more unused code
* remove unused function to appease the linter
* move boost checking to prepare function
* fix use of timeline.lastOrder, fix incorrect range functions used
* remove comments for repeat code
* remove the boost logic from prepare function
* do a maximum of 5 loads, not 10
* add repeat boost filtering logic, update go-structr, general improvements
* more code comments
* add important note
* fix timeline tests now that timelines are returned in page order
* remove unused field
* add StatusTimeline{} tests
* add more status timeline tests
* start adding preloading support
* ensure repeat boosts are marked in preloaded entries
* share a bunch of the database load code in timeline cache, don't clear timelines on relationship change
* add logic to allow dynamic clear / preloading of timelines
* comment-out unused functions, but leave in place as we might end-up using them
* fix timeline preload state check
* much improved status timeline code comments
* more code comments, don't bother inserting statuses if timeline not preloaded
* shift around some logic to make sure things aren't accidentally left set
* finish writing code comments
* remove trim-after-insert behaviour
* fix-up some comments referring to old logic
* remove unsetting of lo, hi
* fix preload repeatBoost checking logic
* don't return on status filter errors, these are usually transient
* better concurrency safety in Clear() and Done()
* fix test broken due to addition of preloader
* fix repeatBoost logic that doesn't account for already-hidden repeatBoosts
* ensure edit submodels are dropped on cache insertion
* update code-comment to expand CAS accronym
* use a plus1hULID() instead of 24h
* remove unused functions
* add note that public / local timeline requester can be nil
* fix incorrect visibility filtering of tag timeline statuses
* ensure we filter home timeline statuses on local only
* some small re-orderings to confirm query params in correct places
* fix the local only home timeline filter func
		
	
			
		
			
				
	
	
		
			190 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			190 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // GoToSocial
 | |
| // Copyright (C) GoToSocial Authors admin@gotosocial.org
 | |
| // SPDX-License-Identifier: AGPL-3.0-or-later
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful,
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package timeline_test
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/stretchr/testify/suite"
 | |
| 	apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/id"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/paging"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/util"
 | |
| )
 | |
| 
 | |
| type PublicTestSuite struct {
 | |
| 	TimelineStandardTestSuite
 | |
| }
 | |
| 
 | |
| func (suite *PublicTestSuite) TestPublicTimelineGet() {
 | |
| 	var (
 | |
| 		ctx       = context.Background()
 | |
| 		requester = suite.testAccounts["local_account_1"]
 | |
| 		maxID     = ""
 | |
| 		sinceID   = ""
 | |
| 		minID     = ""
 | |
| 		limit     = 10
 | |
| 		local     = false
 | |
| 	)
 | |
| 
 | |
| 	resp, errWithCode := suite.timeline.PublicTimelineGet(
 | |
| 		ctx,
 | |
| 		requester,
 | |
| 		&paging.Page{
 | |
| 			Min:   paging.EitherMinID(minID, sinceID),
 | |
| 			Max:   paging.MaxID(maxID),
 | |
| 			Limit: limit,
 | |
| 		},
 | |
| 		local,
 | |
| 	)
 | |
| 
 | |
| 	// We should have some statuses,
 | |
| 	// and paging headers should be set.
 | |
| 	suite.NoError(errWithCode)
 | |
| 	suite.NotEmpty(resp.Items)
 | |
| 	suite.NotEmpty(resp.LinkHeader)
 | |
| 	suite.NotEmpty(resp.NextLink)
 | |
| 	suite.NotEmpty(resp.PrevLink)
 | |
| }
 | |
| 
 | |
| func (suite *PublicTestSuite) TestPublicTimelineGetNotEmpty() {
 | |
| 	var (
 | |
| 		ctx       = context.Background()
 | |
| 		requester = suite.testAccounts["local_account_1"]
 | |
| 		// Select 1 *just above* a status we know should
 | |
| 		// not be in the public timeline -- a public
 | |
| 		// reply to one of admin's statuses.
 | |
| 		maxID   = "01HE7XJ1CG84TBKH5V9XKBVGF6"
 | |
| 		sinceID = ""
 | |
| 		minID   = ""
 | |
| 		limit   = 1
 | |
| 		local   = false
 | |
| 	)
 | |
| 
 | |
| 	resp, errWithCode := suite.timeline.PublicTimelineGet(
 | |
| 		ctx,
 | |
| 		requester,
 | |
| 		&paging.Page{
 | |
| 			Min:   paging.EitherMinID(minID, sinceID),
 | |
| 			Max:   paging.MaxID(maxID),
 | |
| 			Limit: limit,
 | |
| 		},
 | |
| 		local,
 | |
| 	)
 | |
| 
 | |
| 	// We should have a status even though
 | |
| 	// some other statuses were filtered out.
 | |
| 	suite.NoError(errWithCode)
 | |
| 	suite.Len(resp.Items, 1)
 | |
| 	suite.Equal(`<http://localhost:8080/api/v1/timelines/public?limit=1&local=false&max_id=01F8MHCP5P2NWYQ416SBA0XSEV>; rel="next", <http://localhost:8080/api/v1/timelines/public?limit=1&local=false&min_id=01HE7XJ1CG84TBKH5V9XKBVGF5>; rel="prev"`, resp.LinkHeader)
 | |
| 	suite.Equal(`http://localhost:8080/api/v1/timelines/public?limit=1&local=false&max_id=01F8MHCP5P2NWYQ416SBA0XSEV`, resp.NextLink)
 | |
| 	suite.Equal(`http://localhost:8080/api/v1/timelines/public?limit=1&local=false&min_id=01HE7XJ1CG84TBKH5V9XKBVGF5`, resp.PrevLink)
 | |
| }
 | |
| 
 | |
| // A timeline containing a status hidden due to filtering should return other statuses with no error.
 | |
| func (suite *PublicTestSuite) TestPublicTimelineGetHideFiltered() {
 | |
| 	var (
 | |
| 		ctx                 = context.Background()
 | |
| 		requester           = suite.testAccounts["local_account_1"]
 | |
| 		maxID               = ""
 | |
| 		sinceID             = ""
 | |
| 		minID               = ""
 | |
| 		limit               = 100
 | |
| 		local               = false
 | |
| 		filteredStatus      = suite.testStatuses["admin_account_status_2"]
 | |
| 		filteredStatusFound = false
 | |
| 		filterID            = id.NewULID()
 | |
| 		filter              = >smodel.Filter{
 | |
| 			ID:        filterID,
 | |
| 			AccountID: requester.ID,
 | |
| 			Title:     "timeline filtering test",
 | |
| 			Action:    gtsmodel.FilterActionHide,
 | |
| 			Statuses: []*gtsmodel.FilterStatus{
 | |
| 				{
 | |
| 					ID:        id.NewULID(),
 | |
| 					AccountID: requester.ID,
 | |
| 					FilterID:  filterID,
 | |
| 					StatusID:  filteredStatus.ID,
 | |
| 				},
 | |
| 			},
 | |
| 			ContextHome:          util.Ptr(false),
 | |
| 			ContextNotifications: util.Ptr(false),
 | |
| 			ContextPublic:        util.Ptr(true),
 | |
| 			ContextThread:        util.Ptr(false),
 | |
| 			ContextAccount:       util.Ptr(false),
 | |
| 		}
 | |
| 	)
 | |
| 
 | |
| 	// Fetch the timeline to make sure the status we're going to filter is in that section of it.
 | |
| 	resp, errWithCode := suite.timeline.PublicTimelineGet(
 | |
| 		ctx,
 | |
| 		requester,
 | |
| 		&paging.Page{
 | |
| 			Min:   paging.EitherMinID(minID, sinceID),
 | |
| 			Max:   paging.MaxID(maxID),
 | |
| 			Limit: limit,
 | |
| 		},
 | |
| 		local,
 | |
| 	)
 | |
| 	suite.NoError(errWithCode)
 | |
| 	for _, item := range resp.Items {
 | |
| 		if item.(*apimodel.Status).ID == filteredStatus.ID {
 | |
| 			filteredStatusFound = true
 | |
| 			break
 | |
| 		}
 | |
| 	}
 | |
| 	if !filteredStatusFound {
 | |
| 		suite.FailNow("precondition failed: status we would filter isn't present in unfiltered timeline")
 | |
| 	}
 | |
| 
 | |
| 	// Create a filter to hide one status on the timeline.
 | |
| 	if err := suite.db.PutFilter(ctx, filter); err != nil {
 | |
| 		suite.FailNow(err.Error())
 | |
| 	}
 | |
| 
 | |
| 	// Fetch the timeline again with the filter in place.
 | |
| 	resp, errWithCode = suite.timeline.PublicTimelineGet(
 | |
| 		ctx,
 | |
| 		requester,
 | |
| 		&paging.Page{
 | |
| 			Min:   paging.EitherMinID(minID, sinceID),
 | |
| 			Max:   paging.MaxID(maxID),
 | |
| 			Limit: limit,
 | |
| 		},
 | |
| 		local,
 | |
| 	)
 | |
| 
 | |
| 	// We should have some statuses even though one status was filtered out.
 | |
| 	suite.NoError(errWithCode)
 | |
| 	suite.NotEmpty(resp.Items)
 | |
| 	// The filtered status should not be there.
 | |
| 	filteredStatusFound = false
 | |
| 	for _, item := range resp.Items {
 | |
| 		if item.(*apimodel.Status).ID == filteredStatus.ID {
 | |
| 			filteredStatusFound = true
 | |
| 			break
 | |
| 		}
 | |
| 	}
 | |
| 	suite.False(filteredStatusFound)
 | |
| }
 | |
| 
 | |
| func TestPublicTestSuite(t *testing.T) {
 | |
| 	suite.Run(t, new(PublicTestSuite))
 | |
| }
 |