mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-11-04 07:12:25 -06:00 
			
		
		
		
	# Description > If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements. > > If this is a documentation change, please briefly describe what you've changed and why. Brings our parsing of unset sub-policies in line with the defaults documented here: https://docs.gotosocial.org/en/v0.19.1/federation/interaction_policy/#defaults-per-sub-policy Closes https://codeberg.org/superseriousbusiness/gotosocial/issues/4146 Part of https://codeberg.org/superseriousbusiness/gotosocial/issues/4026 ## Checklist Please put an x inside each checkbox to indicate that you've read and followed it: `[ ]` -> `[x]` If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want). - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [x] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4229 Co-authored-by: tobi <tobi.smethurst@protonmail.com> Co-committed-by: tobi <tobi.smethurst@protonmail.com>
		
			
				
	
	
		
			304 lines
		
	
	
	
		
			7.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			304 lines
		
	
	
	
		
			7.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// GoToSocial
 | 
						|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
 | 
						|
// SPDX-License-Identifier: AGPL-3.0-or-later
 | 
						|
//
 | 
						|
// This program is free software: you can redistribute it and/or modify
 | 
						|
// it under the terms of the GNU Affero General Public License as published by
 | 
						|
// the Free Software Foundation, either version 3 of the License, or
 | 
						|
// (at your option) any later version.
 | 
						|
//
 | 
						|
// This program is distributed in the hope that it will be useful,
 | 
						|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
// GNU Affero General Public License for more details.
 | 
						|
//
 | 
						|
// You should have received a copy of the GNU Affero General Public License
 | 
						|
// along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 | 
						|
package ap_test
 | 
						|
 | 
						|
import (
 | 
						|
	"bytes"
 | 
						|
	"io"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"code.superseriousbusiness.org/gotosocial/internal/ap"
 | 
						|
	"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
 | 
						|
	"github.com/stretchr/testify/suite"
 | 
						|
)
 | 
						|
 | 
						|
type ExtractPolicyTestSuite struct {
 | 
						|
	APTestSuite
 | 
						|
}
 | 
						|
 | 
						|
func (suite *ExtractPolicyTestSuite) TestExtractPolicy() {
 | 
						|
	rawNote := `{
 | 
						|
  "@context": [
 | 
						|
    "https://gotosocial.org/ns",
 | 
						|
    "https://www.w3.org/ns/activitystreams"
 | 
						|
  ],
 | 
						|
  "content": "hey @f0x and @dumpsterqueer",
 | 
						|
  "contentMap": {
 | 
						|
    "en": "hey @f0x and @dumpsterqueer",
 | 
						|
    "fr": "bonjour @f0x et @dumpsterqueer"
 | 
						|
  },
 | 
						|
  "interactionPolicy": {
 | 
						|
    "canLike": {
 | 
						|
      "automaticApproval": [
 | 
						|
        "https://www.w3.org/ns/activitystreams#Public"
 | 
						|
      ],
 | 
						|
      "manualApproval": []
 | 
						|
    },
 | 
						|
    "canReply": {
 | 
						|
      "automaticApproval": [
 | 
						|
        "http://localhost:8080/users/the_mighty_zork",
 | 
						|
        "http://localhost:8080/users/the_mighty_zork/followers",
 | 
						|
        "https://gts.superseriousbusiness.org/users/dumpsterqueer",
 | 
						|
        "https://gts.superseriousbusiness.org/users/f0x"
 | 
						|
      ],
 | 
						|
      "manualApproval": [
 | 
						|
        "https://www.w3.org/ns/activitystreams#Public"
 | 
						|
      ]
 | 
						|
    },
 | 
						|
    "canAnnounce": {
 | 
						|
      "automaticApproval": [
 | 
						|
        "http://localhost:8080/users/the_mighty_zork"
 | 
						|
      ],
 | 
						|
      "manualApproval": [
 | 
						|
        "https://www.w3.org/ns/activitystreams#Public"
 | 
						|
      ]
 | 
						|
    }
 | 
						|
  },
 | 
						|
  "tag": [
 | 
						|
    {
 | 
						|
      "href": "https://gts.superseriousbusiness.org/users/dumpsterqueer",
 | 
						|
      "name": "@dumpsterqueer@superseriousbusiness.org",
 | 
						|
      "type": "Mention"
 | 
						|
    },
 | 
						|
    {
 | 
						|
      "href": "https://gts.superseriousbusiness.org/users/f0x",
 | 
						|
      "name": "@f0x@superseriousbusiness.org",
 | 
						|
      "type": "Mention"
 | 
						|
    }
 | 
						|
  ],
 | 
						|
  "type": "Note"
 | 
						|
}`
 | 
						|
 | 
						|
	statusable, err := ap.ResolveStatusable(
 | 
						|
		suite.T().Context(),
 | 
						|
		io.NopCloser(
 | 
						|
			bytes.NewBufferString(rawNote),
 | 
						|
		),
 | 
						|
	)
 | 
						|
	if err != nil {
 | 
						|
		suite.FailNow(err.Error())
 | 
						|
	}
 | 
						|
 | 
						|
	policy := ap.ExtractInteractionPolicy(
 | 
						|
		statusable,
 | 
						|
		// Zork didn't actually create
 | 
						|
		// this status but nevermind.
 | 
						|
		suite.testAccounts["local_account_1"],
 | 
						|
	)
 | 
						|
 | 
						|
	expectedPolicy := >smodel.InteractionPolicy{
 | 
						|
		CanLike: >smodel.PolicyRules{
 | 
						|
			AutomaticApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValuePublic,
 | 
						|
			},
 | 
						|
			ManualApproval: gtsmodel.PolicyValues{},
 | 
						|
		},
 | 
						|
		CanReply: >smodel.PolicyRules{
 | 
						|
			AutomaticApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValueAuthor,
 | 
						|
				gtsmodel.PolicyValueFollowers,
 | 
						|
				"https://gts.superseriousbusiness.org/users/dumpsterqueer",
 | 
						|
				"https://gts.superseriousbusiness.org/users/f0x",
 | 
						|
			},
 | 
						|
			ManualApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValuePublic,
 | 
						|
			},
 | 
						|
		},
 | 
						|
		CanAnnounce: >smodel.PolicyRules{
 | 
						|
			AutomaticApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValueAuthor,
 | 
						|
			},
 | 
						|
			ManualApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValuePublic,
 | 
						|
			},
 | 
						|
		},
 | 
						|
	}
 | 
						|
	suite.EqualValues(expectedPolicy, policy)
 | 
						|
}
 | 
						|
 | 
						|
func (suite *ExtractPolicyTestSuite) TestExtractPolicyUnsetProps() {
 | 
						|
	rawNote := `{
 | 
						|
  "@context": [
 | 
						|
    "https://gotosocial.org/ns",
 | 
						|
    "https://www.w3.org/ns/activitystreams"
 | 
						|
  ],
 | 
						|
  "content": "hey @f0x and @dumpsterqueer",
 | 
						|
  "contentMap": {
 | 
						|
    "en": "hey @f0x and @dumpsterqueer",
 | 
						|
    "fr": "bonjour @f0x et @dumpsterqueer"
 | 
						|
  },
 | 
						|
  "interactionPolicy": {
 | 
						|
    "canAnnounce": {
 | 
						|
      "automaticApproval": [
 | 
						|
        "http://localhost:8080/users/the_mighty_zork"
 | 
						|
      ],
 | 
						|
      "manualApproval": [
 | 
						|
        "https://www.w3.org/ns/activitystreams#Public"
 | 
						|
      ]
 | 
						|
    }
 | 
						|
  },
 | 
						|
  "tag": [
 | 
						|
    {
 | 
						|
      "href": "https://gts.superseriousbusiness.org/users/dumpsterqueer",
 | 
						|
      "name": "@dumpsterqueer@superseriousbusiness.org",
 | 
						|
      "type": "Mention"
 | 
						|
    },
 | 
						|
    {
 | 
						|
      "href": "https://gts.superseriousbusiness.org/users/f0x",
 | 
						|
      "name": "@f0x@superseriousbusiness.org",
 | 
						|
      "type": "Mention"
 | 
						|
    }
 | 
						|
  ],
 | 
						|
  "type": "Note"
 | 
						|
}`
 | 
						|
 | 
						|
	statusable, err := ap.ResolveStatusable(
 | 
						|
		suite.T().Context(),
 | 
						|
		io.NopCloser(
 | 
						|
			bytes.NewBufferString(rawNote),
 | 
						|
		),
 | 
						|
	)
 | 
						|
	if err != nil {
 | 
						|
		suite.FailNow(err.Error())
 | 
						|
	}
 | 
						|
 | 
						|
	policy := ap.ExtractInteractionPolicy(
 | 
						|
		statusable,
 | 
						|
		// Zork didn't actually create
 | 
						|
		// this status but nevermind.
 | 
						|
		suite.testAccounts["local_account_1"],
 | 
						|
	)
 | 
						|
 | 
						|
	expectedPolicy := >smodel.InteractionPolicy{
 | 
						|
		CanLike:  nil,
 | 
						|
		CanReply: nil,
 | 
						|
		CanAnnounce: >smodel.PolicyRules{
 | 
						|
			AutomaticApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValueAuthor,
 | 
						|
			},
 | 
						|
			ManualApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValuePublic,
 | 
						|
			},
 | 
						|
		},
 | 
						|
	}
 | 
						|
	suite.EqualValues(expectedPolicy, policy)
 | 
						|
}
 | 
						|
 | 
						|
func (suite *ExtractPolicyTestSuite) TestExtractPolicyDeprecated() {
 | 
						|
	rawNote := `{
 | 
						|
  "@context": [
 | 
						|
    "https://gotosocial.org/ns",
 | 
						|
    "https://www.w3.org/ns/activitystreams"
 | 
						|
  ],
 | 
						|
  "content": "hey @f0x and @dumpsterqueer",
 | 
						|
  "contentMap": {
 | 
						|
    "en": "hey @f0x and @dumpsterqueer",
 | 
						|
    "fr": "bonjour @f0x et @dumpsterqueer"
 | 
						|
  },
 | 
						|
  "interactionPolicy": {
 | 
						|
    "canLike": {
 | 
						|
      "always": [
 | 
						|
        "https://www.w3.org/ns/activitystreams#Public"
 | 
						|
      ],
 | 
						|
      "approvalRequired": []
 | 
						|
    },
 | 
						|
    "canReply": {
 | 
						|
      "always": [
 | 
						|
        "http://localhost:8080/users/the_mighty_zork",
 | 
						|
        "http://localhost:8080/users/the_mighty_zork/followers",
 | 
						|
        "https://gts.superseriousbusiness.org/users/dumpsterqueer",
 | 
						|
        "https://gts.superseriousbusiness.org/users/f0x"
 | 
						|
      ],
 | 
						|
      "approvalRequired": [
 | 
						|
        "https://www.w3.org/ns/activitystreams#Public"
 | 
						|
      ]
 | 
						|
    },
 | 
						|
    "canAnnounce": {
 | 
						|
      "always": [
 | 
						|
        "http://localhost:8080/users/the_mighty_zork"
 | 
						|
      ],
 | 
						|
      "approvalRequired": [
 | 
						|
        "https://www.w3.org/ns/activitystreams#Public"
 | 
						|
      ]
 | 
						|
    }
 | 
						|
  },
 | 
						|
  "tag": [
 | 
						|
    {
 | 
						|
      "href": "https://gts.superseriousbusiness.org/users/dumpsterqueer",
 | 
						|
      "name": "@dumpsterqueer@superseriousbusiness.org",
 | 
						|
      "type": "Mention"
 | 
						|
    },
 | 
						|
    {
 | 
						|
      "href": "https://gts.superseriousbusiness.org/users/f0x",
 | 
						|
      "name": "@f0x@superseriousbusiness.org",
 | 
						|
      "type": "Mention"
 | 
						|
    }
 | 
						|
  ],
 | 
						|
  "type": "Note"
 | 
						|
}`
 | 
						|
 | 
						|
	statusable, err := ap.ResolveStatusable(
 | 
						|
		suite.T().Context(),
 | 
						|
		io.NopCloser(
 | 
						|
			bytes.NewBufferString(rawNote),
 | 
						|
		),
 | 
						|
	)
 | 
						|
	if err != nil {
 | 
						|
		suite.FailNow(err.Error())
 | 
						|
	}
 | 
						|
 | 
						|
	policy := ap.ExtractInteractionPolicy(
 | 
						|
		statusable,
 | 
						|
		// Zork didn't actually create
 | 
						|
		// this status but nevermind.
 | 
						|
		suite.testAccounts["local_account_1"],
 | 
						|
	)
 | 
						|
 | 
						|
	expectedPolicy := >smodel.InteractionPolicy{
 | 
						|
		CanLike: >smodel.PolicyRules{
 | 
						|
			AutomaticApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValuePublic,
 | 
						|
			},
 | 
						|
			ManualApproval: gtsmodel.PolicyValues{},
 | 
						|
		},
 | 
						|
		CanReply: >smodel.PolicyRules{
 | 
						|
			AutomaticApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValueAuthor,
 | 
						|
				gtsmodel.PolicyValueFollowers,
 | 
						|
				"https://gts.superseriousbusiness.org/users/dumpsterqueer",
 | 
						|
				"https://gts.superseriousbusiness.org/users/f0x",
 | 
						|
			},
 | 
						|
			ManualApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValuePublic,
 | 
						|
			},
 | 
						|
		},
 | 
						|
		CanAnnounce: >smodel.PolicyRules{
 | 
						|
			AutomaticApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValueAuthor,
 | 
						|
			},
 | 
						|
			ManualApproval: gtsmodel.PolicyValues{
 | 
						|
				gtsmodel.PolicyValuePublic,
 | 
						|
			},
 | 
						|
		},
 | 
						|
	}
 | 
						|
	suite.EqualValues(expectedPolicy, policy)
 | 
						|
}
 | 
						|
 | 
						|
func TestExtractPolicyTestSuite(t *testing.T) {
 | 
						|
	suite.Run(t, &ExtractPolicyTestSuite{})
 | 
						|
}
 |