mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2025-10-29 02:22:26 -05:00
311d9a1697
# Description This is quite a complex database migration that updates the `statuses.thread_id` column to be notnull, in order that statuses always be threaded, which will be useful in various pieces of upcoming work. This is unfortunately a migration that acts over the entire statuses table, and is quite complex in order to ensure that all existing statuses get correctly threaded together, and where possible fix any issues of statuses in the same thread having incorrect thread_ids. TODO: - ~~update testrig models to all be threaded~~ - ~~update code to ensure thread_id is always set~~ - ~~run on **a copy** of an sqlite production database~~ - ~~run on **a copy** of a postgres production database~~ ## Checklist - [x] I/we have read the [GoToSocial contribution guidelines](https://codeberg.org/superseriousbusiness/gotosocial/src/branch/main/CONTRIBUTING.md). - [x] I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat. - [x] I/we have not leveraged AI to create the proposed changes. - [x] I/we have performed a self-review of added code. - [x] I/we have written code that is legible and maintainable by others. - [x] I/we have commented the added code, particularly in hard-to-understand areas. - [ ] I/we have made any necessary changes to documentation. - [x] I/we have added tests that cover new code. - [x] I/we have run tests and they pass locally with the changes. - [x] I/we have run `go fmt ./...` and `golangci-lint run`. Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4160 Co-authored-by: kim <grufwub@gmail.com> Co-committed-by: kim <grufwub@gmail.com> |
||
|---|---|---|
| .. | ||
| account.go | ||
| accountnote.go | ||
| accountsettings.go | ||
| accountstats.go | ||
| adminaction.go | ||
| advancedmigration.go | ||
| application.go | ||
| block.go | ||
| common.go | ||
| conversation.go | ||
| domainallow.go | ||
| domainblock.go | ||
| domainpermission.go | ||
| domainpermissiondraft.go | ||
| domainpermissionexclude.go | ||
| domainpermissionsubscription.go | ||
| emaildomainblock.go | ||
| emoji.go | ||
| emojicategory.go | ||
| filter.go | ||
| follow.go | ||
| followrequest.go | ||
| headerfilter.go | ||
| instance.go | ||
| interaction.go | ||
| interactionpolicy.go | ||
| list.go | ||
| marker.go | ||
| mediaattachment.go | ||
| mention.go | ||
| move.go | ||
| notification.go | ||
| poll.go | ||
| README.md | ||
| report.go | ||
| routersession.go | ||
| rule.go | ||
| sinbinstatus.go | ||
| status.go | ||
| statusbookmark.go | ||
| statusedit.go | ||
| statusfave.go | ||
| statusmute.go | ||
| tag.go | ||
| thread.go | ||
| threadmute.go | ||
| token.go | ||
| tombstone.go | ||
| user.go | ||
| usermute.go | ||
| vapidkeypair.go | ||
| webpushsubscription.go | ||
| workertask.go | ||
A note on when we should set data structures linked to objects in the database to use the
bun nullzero tag -- this should only be done if the member type is a pointer, or if the
this primitive type is literally invalid with an empty value (e.g. media IDs which when
empty signifies a null database value, compared to say an account note which when empty
could mean either an empty note OR null database value).
Obviously it is a little more complex than this in practice, but keep it in mind!