mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-10-30 23:12:25 -05:00 
			
		
		
		
	Fixes an issue where async processing was not completing correctly. In particular this applies to side effects of domain blocks: while the domain block was being entered and enforced correctly, side effects like deleting accounts and updating the instance entry for the blocked instance were not. This fixes that :)
		
			
				
	
	
		
			179 lines
		
	
	
	
		
			6.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			179 lines
		
	
	
	
		
			6.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
|    GoToSocial
 | |
|    Copyright (C) 2021-2022 GoToSocial Authors admin@gotosocial.org
 | |
| 
 | |
|    This program is free software: you can redistribute it and/or modify
 | |
|    it under the terms of the GNU Affero General Public License as published by
 | |
|    the Free Software Foundation, either version 3 of the License, or
 | |
|    (at your option) any later version.
 | |
| 
 | |
|    This program is distributed in the hope that it will be useful,
 | |
|    but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
|    GNU Affero General Public License for more details.
 | |
| 
 | |
|    You should have received a copy of the GNU Affero General Public License
 | |
|    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| */
 | |
| 
 | |
| package admin
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 	"strings"
 | |
| 	"time"
 | |
| 
 | |
| 	"codeberg.org/gruf/go-kv"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/ap"
 | |
| 	apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/db"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtserror"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/id"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/log"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/messages"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/text"
 | |
| )
 | |
| 
 | |
| func (p *processor) DomainBlockCreate(ctx context.Context, account *gtsmodel.Account, domain string, obfuscate bool, publicComment string, privateComment string, subscriptionID string) (*apimodel.DomainBlock, gtserror.WithCode) {
 | |
| 	// domain blocks will always be lowercase
 | |
| 	domain = strings.ToLower(domain)
 | |
| 
 | |
| 	// first check if we already have a block -- if err == nil we already had a block so we can skip a whole lot of work
 | |
| 	block, err := p.db.GetDomainBlock(ctx, domain)
 | |
| 	if err != nil {
 | |
| 		if !errors.Is(err, db.ErrNoEntries) {
 | |
| 			// something went wrong in the DB
 | |
| 			return nil, gtserror.NewErrorInternalError(fmt.Errorf("db error checking for existence of domain block %s: %s", domain, err))
 | |
| 		}
 | |
| 
 | |
| 		// there's no block for this domain yet so create one
 | |
| 		// note: we take a new ulid from timestamp here in case we need to sort blocks
 | |
| 		blockID, err := id.NewULID()
 | |
| 		if err != nil {
 | |
| 			return nil, gtserror.NewErrorInternalError(fmt.Errorf("error creating id for new domain block %s: %s", domain, err))
 | |
| 		}
 | |
| 
 | |
| 		newBlock := gtsmodel.DomainBlock{
 | |
| 			ID:                 blockID,
 | |
| 			Domain:             domain,
 | |
| 			CreatedByAccountID: account.ID,
 | |
| 			PrivateComment:     text.SanitizePlaintext(privateComment),
 | |
| 			PublicComment:      text.SanitizePlaintext(publicComment),
 | |
| 			Obfuscate:          &obfuscate,
 | |
| 			SubscriptionID:     subscriptionID,
 | |
| 		}
 | |
| 
 | |
| 		// Insert the new block into the database
 | |
| 		if err := p.db.CreateDomainBlock(ctx, newBlock); err != nil {
 | |
| 			return nil, gtserror.NewErrorInternalError(fmt.Errorf("db error putting new domain block %s: %s", domain, err))
 | |
| 		}
 | |
| 
 | |
| 		// Set the newly created block
 | |
| 		block = &newBlock
 | |
| 
 | |
| 		// Process the side effects of the domain block asynchronously since it might take a while
 | |
| 		go func() {
 | |
| 			p.initiateDomainBlockSideEffects(context.Background(), account, block)
 | |
| 		}()
 | |
| 	}
 | |
| 
 | |
| 	// Convert our gts model domain block into an API model
 | |
| 	apiDomainBlock, err := p.tc.DomainBlockToAPIDomainBlock(ctx, block, false)
 | |
| 	if err != nil {
 | |
| 		return nil, gtserror.NewErrorInternalError(fmt.Errorf("error converting domain block to frontend/api representation %s: %s", domain, err))
 | |
| 	}
 | |
| 
 | |
| 	return apiDomainBlock, nil
 | |
| }
 | |
| 
 | |
| // initiateDomainBlockSideEffects should be called asynchronously, to process the side effects of a domain block:
 | |
| //
 | |
| // 1. Strip most info away from the instance entry for the domain.
 | |
| // 2. Delete the instance account for that instance if it exists.
 | |
| // 3. Select all accounts from this instance and pass them through the delete functionality of the processor.
 | |
| func (p *processor) initiateDomainBlockSideEffects(ctx context.Context, account *gtsmodel.Account, block *gtsmodel.DomainBlock) {
 | |
| 	l := log.WithFields(kv.Fields{
 | |
| 		{"domain", block.Domain},
 | |
| 	}...)
 | |
| 
 | |
| 	l.Debug("processing domain block side effects")
 | |
| 
 | |
| 	// if we have an instance entry for this domain, update it with the new block ID and clear all fields
 | |
| 	instance := >smodel.Instance{}
 | |
| 	if err := p.db.GetWhere(ctx, []db.Where{{Key: "domain", Value: block.Domain}}, instance); err == nil {
 | |
| 		updatingColumns := []string{
 | |
| 			"title",
 | |
| 			"updated_at",
 | |
| 			"suspended_at",
 | |
| 			"domain_block_id",
 | |
| 			"short_description",
 | |
| 			"description",
 | |
| 			"terms",
 | |
| 			"contact_email",
 | |
| 			"contact_account_username",
 | |
| 			"contact_account_id",
 | |
| 			"version",
 | |
| 		}
 | |
| 		instance.Title = ""
 | |
| 		instance.UpdatedAt = time.Now()
 | |
| 		instance.SuspendedAt = time.Now()
 | |
| 		instance.DomainBlockID = block.ID
 | |
| 		instance.ShortDescription = ""
 | |
| 		instance.Description = ""
 | |
| 		instance.Terms = ""
 | |
| 		instance.ContactEmail = ""
 | |
| 		instance.ContactAccountUsername = ""
 | |
| 		instance.ContactAccountID = ""
 | |
| 		instance.Version = ""
 | |
| 		if err := p.db.UpdateByPrimaryKey(ctx, instance, updatingColumns...); err != nil {
 | |
| 			l.Errorf("domainBlockProcessSideEffects: db error updating instance: %s", err)
 | |
| 		}
 | |
| 		l.Debug("domainBlockProcessSideEffects: instance entry updated")
 | |
| 	}
 | |
| 
 | |
| 	// if we have an instance account for this instance, delete it
 | |
| 	if err := p.db.DeleteWhere(ctx, []db.Where{{Key: "username", Value: block.Domain, CaseInsensitive: true}}, >smodel.Account{}); err != nil {
 | |
| 		l.Errorf("domainBlockProcessSideEffects: db error removing instance account: %s", err)
 | |
| 	}
 | |
| 
 | |
| 	// delete accounts through the normal account deletion system (which should also delete media + posts + remove posts from timelines)
 | |
| 
 | |
| 	limit := 20      // just select 20 accounts at a time so we don't nuke our DB/mem with one huge query
 | |
| 	var maxID string // this is initially an empty string so we'll start at the top of accounts list (sorted by ID)
 | |
| 
 | |
| selectAccountsLoop:
 | |
| 	for {
 | |
| 		accounts, err := p.db.GetInstanceAccounts(ctx, block.Domain, maxID, limit)
 | |
| 		if err != nil {
 | |
| 			if err == db.ErrNoEntries {
 | |
| 				// no accounts left for this instance so we're done
 | |
| 				l.Infof("domainBlockProcessSideEffects: done iterating through accounts for domain %s", block.Domain)
 | |
| 				break selectAccountsLoop
 | |
| 			}
 | |
| 			// an actual error has occurred
 | |
| 			l.Errorf("domainBlockProcessSideEffects: db error selecting accounts for domain %s: %s", block.Domain, err)
 | |
| 			break selectAccountsLoop
 | |
| 		}
 | |
| 
 | |
| 		for i, a := range accounts {
 | |
| 			l.Debugf("putting delete for account %s in the clientAPI channel", a.Username)
 | |
| 
 | |
| 			// pass the account delete through the client api channel for processing
 | |
| 			p.clientWorker.Queue(messages.FromClientAPI{
 | |
| 				APObjectType:   ap.ActorPerson,
 | |
| 				APActivityType: ap.ActivityDelete,
 | |
| 				GTSModel:       block,
 | |
| 				OriginAccount:  account,
 | |
| 				TargetAccount:  a,
 | |
| 			})
 | |
| 
 | |
| 			// if this is the last account in the slice, set the maxID appropriately for the next query
 | |
| 			if i == len(accounts)-1 {
 | |
| 				maxID = a.ID
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| }
 |