gotosocial/internal/typeutils
ewwwin 424f62dd70
[bugfix] Store and expose status content type (#3870)
* Add ContentType to internal models

* Add ContentType to API models StatusSource and StatusEdit

* Add helpers to convert between API/internal StatusContentType

* Write status content type on create/edit

* Add migration

* Update API docs

go run github.com/go-swagger/go-swagger/cmd/swagger generate spec --scan-models --exclude-deps --output docs/api/swagger.yaml

* ensure ContentType is updated anywhere Text is

* Update docs, take care of TODOs

* Set ContentType in more places where Text is set

* We don't actually use ContentType on the API status model

* Update StatusSource test

* Remove unused helper function I copied

* Revert change to StatusContentType swagger annotation

I'm going to include this in a follow-on PR instead.

* Add test for updating content type in edits

* Return a value from processContentType instead of modifying the existing status

Fixes an issue that was caught by the test I just added - the recorded edit would be marked with the *new* content type instead of the old one, which is obviously bad

* Add test for handling of statuses with no stored content type

* repurpose an existing test status instead of adding a new one to avoid breaking other tests

* Add test to ensure newly created statuses always have content type saved

* Do include content type on status API model actually

This is mostly important when deleting and redrafting.

The comment on `apimodel.Status.Text` implies that it's not sent except in response to status deletion, but actually this doesn't seem to be the case; it also appears to be present in responses to creations and normal fetches and stuff. So I'm treating `ContentType` the same here.

* Update new tests to check content type on API statuses

* Check content type of API statuses in all tests where text is checked

* update other api tests with status content type field

* Add test ensuring text and content type are returned when deleting a status

* Convert processContentType to free function and remove unused parameter

* check for the correct value in the deletion test

* Be explicit about this test status having an empty content type

* Use omitempty consistently on API models

* clean up the final diff a bit

* one more swagger regen for the road

* Handle nil statuses in processContentType

* Don't pass processContentType the entire edit form, it doesn't need it

* Move processContentType to common.go and use for creation as well

* Remove unused parameters to ContentTypeToAPIContentType
2025-03-06 16:31:52 +00:00
..
astointernal.go [bugfix] Allow processing null ID emojis (#3702) 2025-01-28 13:32:37 +01:00
astointernal_test.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
converter.go [feature] Add instance-stats-randomize config option (#3718) 2025-01-31 19:27:18 +01:00
converter_test.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
csv.go [feature] Implement CSV import for mutes (#3696) 2025-03-01 11:37:40 +01:00
defaulticons.go [feature] Add image descriptions for default avatar + header; don't allow editing default desc (#3473) 2024-10-21 14:04:50 +02:00
frontendtointernal.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
internal.go [feature] add support for receiving federated status edits (#3597) 2024-12-05 13:35:07 +00:00
internaltoas.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
internaltoas_test.go [feature] Implement Web Push notification policy (#3721) 2025-02-03 10:25:53 +00:00
internaltofrontend.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
internaltofrontend_test.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
internaltorss.go [chore] replace statuses.updated_at column with statuses.edited_at (#3636) 2025-01-08 11:29:23 +01:00
internaltorss_test.go [chore] replace statuses.updated_at column with statuses.edited_at (#3636) 2025-01-08 11:29:23 +01:00
util.go [feature] Add system message wrappers for pending replies and placeholder attachments (#3713) 2025-01-31 11:40:39 +01:00
util_test.go [bugfix] Use better plaintext representation of status for filtering (#3301) 2024-09-16 14:00:23 +02:00
wrap.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
wrap_test.go [feature] Serve bot accounts over AP as Service instead of Person (#3672) 2025-01-23 18:18:23 +01:00