mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-10-31 08:42:27 -05:00 
			
		
		
		
	after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller
frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
		
	
			
		
			
				
	
	
		
			145 lines
		
	
	
	
		
			5.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			145 lines
		
	
	
	
		
			5.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // GoToSocial
 | |
| // Copyright (C) GoToSocial Authors admin@gotosocial.org
 | |
| // SPDX-License-Identifier: AGPL-3.0-or-later
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful,
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package federatingdb
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"net/url"
 | |
| 
 | |
| 	"code.superseriousbusiness.org/activity/streams"
 | |
| 	"code.superseriousbusiness.org/activity/streams/vocab"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/config"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/db"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/uris"
 | |
| )
 | |
| 
 | |
| // InboxContains returns true if the OrderedCollection at 'inbox'
 | |
| // contains the specified 'id'.
 | |
| //
 | |
| // The library makes this call only after acquiring a lock first.
 | |
| //
 | |
| // Implementation note: we have our own logic for inboxes so always return false here.
 | |
| func (f *DB) InboxContains(c context.Context, inbox, id *url.URL) (contains bool, err error) {
 | |
| 	return false, nil
 | |
| }
 | |
| 
 | |
| // GetInbox returns the first ordered collection page of the outbox at
 | |
| // the specified IRI, for prepending new items.
 | |
| //
 | |
| // The library makes this call only after acquiring a lock first.
 | |
| //
 | |
| // Implementation note: we don't (yet) serve inboxes, so just return empty and nil here.
 | |
| func (f *DB) GetInbox(c context.Context, inboxIRI *url.URL) (inbox vocab.ActivityStreamsOrderedCollectionPage, err error) {
 | |
| 	return streams.NewActivityStreamsOrderedCollectionPage(), nil
 | |
| }
 | |
| 
 | |
| // SetInbox saves the inbox value given from GetInbox, with new items
 | |
| // prepended. Note that the new items must not be added as independent
 | |
| // database entries. Separate calls to Create will do that.
 | |
| //
 | |
| // The library makes this call only after acquiring a lock first.
 | |
| //
 | |
| // Implementation note: we don't allow inbox setting so just return nil here.
 | |
| func (f *DB) SetInbox(c context.Context, inbox vocab.ActivityStreamsOrderedCollectionPage) error {
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| // InboxesForIRI fetches inboxes corresponding to the given iri.
 | |
| // This allows your server to skip remote dereferencing of iris
 | |
| // in order to speed up message delivery, if desired.
 | |
| //
 | |
| // It is acceptable to just return nil or an empty slice for the inboxIRIs,
 | |
| // if you don't know the inbox iri, or you don't wish to use this feature.
 | |
| // In this case, the library will attempt to resolve inboxes of the iri
 | |
| // by remote dereferencing instead.
 | |
| //
 | |
| // If the input iri is the iri of an Actor, then the inbox for the actor
 | |
| // should be returned as a single-entry slice.
 | |
| //
 | |
| // If the input iri is a Collection (such as a Collection of followers),
 | |
| // then each follower inbox IRI should be returned in the inboxIRIs slice.
 | |
| //
 | |
| // The library makes this call only after acquiring a lock first.
 | |
| func (f *DB) InboxesForIRI(c context.Context, iri *url.URL) (inboxIRIs []*url.URL, err error) {
 | |
| 	// check if this is a followers collection iri for a local account...
 | |
| 	if iri.Host == config.GetHost() && uris.IsFollowersPath(iri) {
 | |
| 		localAccountUsername, err := uris.ParseFollowersPath(iri)
 | |
| 		if err != nil {
 | |
| 			return nil, fmt.Errorf("couldn't extract local account username from uri %s: %s", iri, err)
 | |
| 		}
 | |
| 
 | |
| 		account, err := f.state.DB.GetAccountByUsernameDomain(c, localAccountUsername, "")
 | |
| 		if err != nil {
 | |
| 			return nil, fmt.Errorf("couldn't find local account with username %s: %s", localAccountUsername, err)
 | |
| 		}
 | |
| 
 | |
| 		follows, err := f.state.DB.GetAccountFollowers(c, account.ID, nil)
 | |
| 		if err != nil {
 | |
| 			return nil, fmt.Errorf("couldn't get followers of local account %s: %s", localAccountUsername, err)
 | |
| 		}
 | |
| 
 | |
| 		for _, follow := range follows {
 | |
| 			if follow.Account == nil {
 | |
| 				// No account exists for this follow,
 | |
| 				// for some reason. Just skip it.
 | |
| 				continue
 | |
| 			}
 | |
| 
 | |
| 			// deliver to a shared inbox if we have that option
 | |
| 			var inbox string
 | |
| 			if config.GetInstanceDeliverToSharedInboxes() && follow.Account.SharedInboxURI != nil && *follow.Account.SharedInboxURI != "" {
 | |
| 				inbox = *follow.Account.SharedInboxURI
 | |
| 			} else {
 | |
| 				inbox = follow.Account.InboxURI
 | |
| 			}
 | |
| 
 | |
| 			inboxIRI, err := url.Parse(inbox)
 | |
| 			if err != nil {
 | |
| 				return nil, fmt.Errorf("error parsing inbox uri of following account %s: %s", follow.Account.InboxURI, err)
 | |
| 			}
 | |
| 			inboxIRIs = append(inboxIRIs, inboxIRI)
 | |
| 		}
 | |
| 		return inboxIRIs, nil
 | |
| 	}
 | |
| 
 | |
| 	// check if this is just an account IRI...
 | |
| 	if account, err := f.state.DB.GetAccountByURI(c, iri.String()); err == nil {
 | |
| 		// deliver to a shared inbox if we have that option
 | |
| 		var inbox string
 | |
| 		if config.GetInstanceDeliverToSharedInboxes() && account.SharedInboxURI != nil && *account.SharedInboxURI != "" {
 | |
| 			inbox = *account.SharedInboxURI
 | |
| 		} else {
 | |
| 			inbox = account.InboxURI
 | |
| 		}
 | |
| 
 | |
| 		inboxIRI, err := url.Parse(inbox)
 | |
| 		if err != nil {
 | |
| 			return nil, fmt.Errorf("error parsing account inbox uri %s: %s", account.InboxURI, account.InboxURI)
 | |
| 		}
 | |
| 		// we've got it
 | |
| 		inboxIRIs = append(inboxIRIs, inboxIRI)
 | |
| 		return inboxIRIs, nil
 | |
| 	} else if err != db.ErrNoEntries {
 | |
| 		// there's been a real error
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	// no error, we just didn't find anything so let the library handle the rest
 | |
| 	return nil, nil
 | |
| }
 |