mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2025-10-29 10:52:25 -05:00
* start work rewriting timeline cache type
* further work rewriting timeline caching
* more work integration new timeline code
* remove old code
* add local timeline, fix up merge conflicts
* remove old use of go-bytes
* implement new timeline code into more areas of codebase, pull in latest go-mangler, go-mutexes, go-structr
* remove old timeline package, add local timeline cache
* remove references to old timeline types that needed starting up in tests
* start adding page validation
* fix test-identified timeline cache package issues
* fix up more tests, fix missing required changes, etc
* add exclusion for test.out in gitignore
* clarify some things better in code comments
* tweak cache size limits
* fix list timeline cache fetching
* further list timeline fixes
* linter, ssssssssshhhhhhhhhhhh please
* fix linter hints
* reslice the output if it's beyond length of 'lim'
* remove old timeline initialization code, bump go-structr to v0.9.4
* continued from previous commit
* improved code comments
* don't allow multiple entries for BoostOfID values to prevent repeated boosts of same boosts
* finish writing more code comments
* some variable renaming, for ease of following
* change the way we update lo,hi paging values during timeline load
* improved code comments for updated / returned lo , hi paging values
* finish writing code comments for the StatusTimeline{} type itself
* fill in more code comments
* update go-structr version to latest with changed timeline unique indexing logic
* have a local and public timeline *per user*
* rewrite calls to public / local timeline calls
* remove the zero length check, as lo, hi values might still be set
* simplify timeline cache loading, fix lo/hi returns, fix timeline invalidation side-effects missing for some federated actions
* swap the lo, hi values 🤦
* add (now) missing slice reverse of tag timeline statuses when paging ASC
* remove local / public caches (is out of scope for this work), share more timeline code
* remove unnecessary change
* again, remove more unused code
* remove unused function to appease the linter
* move boost checking to prepare function
* fix use of timeline.lastOrder, fix incorrect range functions used
* remove comments for repeat code
* remove the boost logic from prepare function
* do a maximum of 5 loads, not 10
* add repeat boost filtering logic, update go-structr, general improvements
* more code comments
* add important note
* fix timeline tests now that timelines are returned in page order
* remove unused field
* add StatusTimeline{} tests
* add more status timeline tests
* start adding preloading support
* ensure repeat boosts are marked in preloaded entries
* share a bunch of the database load code in timeline cache, don't clear timelines on relationship change
* add logic to allow dynamic clear / preloading of timelines
* comment-out unused functions, but leave in place as we might end-up using them
* fix timeline preload state check
* much improved status timeline code comments
* more code comments, don't bother inserting statuses if timeline not preloaded
* shift around some logic to make sure things aren't accidentally left set
* finish writing code comments
* remove trim-after-insert behaviour
* fix-up some comments referring to old logic
* remove unsetting of lo, hi
* fix preload repeatBoost checking logic
* don't return on status filter errors, these are usually transient
* better concurrency safety in Clear() and Done()
* fix test broken due to addition of preloader
* fix repeatBoost logic that doesn't account for already-hidden repeatBoosts
* ensure edit submodels are dropped on cache insertion
* update code-comment to expand CAS accronym
* use a plus1hULID() instead of 24h
* remove unused functions
* add note that public / local timeline requester can be nil
* fix incorrect visibility filtering of tag timeline statuses
* ensure we filter home timeline statuses on local only
* some small re-orderings to confirm query params in correct places
* fix the local only home timeline filter func
152 lines
3.6 KiB
Go
152 lines
3.6 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package timeline
|
|
|
|
import (
|
|
"sync"
|
|
"sync/atomic"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
)
|
|
|
|
// preloader provides a means of synchronising the
|
|
// initial fill, or "preload", of a timeline cache.
|
|
// it has 4 possible states in the atomic pointer:
|
|
// - preloading = &(interface{}(*sync.WaitGroup))
|
|
// - preloaded = &(interface{}(nil))
|
|
// - needs preload = &(interface{}(false))
|
|
// - brand-new = nil (functionally same as 'needs preload')
|
|
type preloader struct{ p atomic.Pointer[any] }
|
|
|
|
// Check will return the current preload state,
|
|
// waiting if a preload is currently in progress.
|
|
func (p *preloader) Check() bool {
|
|
for {
|
|
// Get state ptr.
|
|
ptr := p.p.Load()
|
|
|
|
// Check if requires preloading.
|
|
if ptr == nil || *ptr == false {
|
|
return false
|
|
}
|
|
|
|
// Check for a preload currently in progress.
|
|
if wg, _ := (*ptr).(*sync.WaitGroup); wg != nil {
|
|
wg.Wait()
|
|
continue
|
|
}
|
|
|
|
// Anything else
|
|
// means success.
|
|
return true
|
|
}
|
|
}
|
|
|
|
// CheckPreload will safely check the preload state,
|
|
// and if needed call the provided function. if a
|
|
// preload is in progress, it will wait until complete.
|
|
func (p *preloader) CheckPreload(preload func(*any)) {
|
|
for {
|
|
// Get state ptr.
|
|
ptr := p.p.Load()
|
|
|
|
if ptr == nil || *ptr == false {
|
|
// Needs preloading, start it.
|
|
ok := p.start(ptr, preload)
|
|
|
|
if !ok {
|
|
// Failed to acquire start,
|
|
// other thread beat us to it.
|
|
continue
|
|
}
|
|
|
|
// Success!
|
|
return
|
|
}
|
|
|
|
// Check for a preload currently in progress.
|
|
if wg, _ := (*ptr).(*sync.WaitGroup); wg != nil {
|
|
wg.Wait()
|
|
continue
|
|
}
|
|
|
|
// Anything else
|
|
// means success.
|
|
return
|
|
}
|
|
}
|
|
|
|
// start attempts to start the given preload function, by performing
|
|
// a compare and swap operation with 'old'. return is success.
|
|
func (p *preloader) start(old *any, preload func(*any)) bool {
|
|
|
|
// Optimistically setup a
|
|
// new waitgroup to set as
|
|
// the preload waiter.
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
defer wg.Done()
|
|
|
|
// Wrap waitgroup in
|
|
// 'any' for pointer.
|
|
new := any(&wg)
|
|
ptr := &new
|
|
|
|
// Attempt CAS operation to claim start.
|
|
started := p.p.CompareAndSwap(old, ptr)
|
|
if !started {
|
|
return false
|
|
}
|
|
|
|
// Start.
|
|
preload(ptr)
|
|
return true
|
|
}
|
|
|
|
// done marks state as preloaded,
|
|
// i.e. no more preload required.
|
|
func (p *preloader) Done(ptr *any) {
|
|
if !p.p.CompareAndSwap(ptr, new(any)) {
|
|
log.Errorf(nil, "BUG: invalid preloader state: %#v", (*p.p.Load()))
|
|
}
|
|
}
|
|
|
|
// clear will clear the state, marking a "preload" as required.
|
|
// i.e. next call to Check() will call provided preload func.
|
|
func (p *preloader) Clear() {
|
|
b := false
|
|
a := any(b)
|
|
for {
|
|
// Load current ptr.
|
|
ptr := p.p.Load()
|
|
if ptr == nil {
|
|
return // was brand-new
|
|
}
|
|
|
|
// Check for a preload currently in progress.
|
|
if wg, _ := (*ptr).(*sync.WaitGroup); wg != nil {
|
|
wg.Wait()
|
|
continue
|
|
}
|
|
|
|
// Try mark as needing preload.
|
|
if p.p.CompareAndSwap(ptr, &a) {
|
|
return
|
|
}
|
|
}
|
|
}
|