mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-10-31 12:22:24 -05:00 
			
		
		
		
	* [bugfix] CSP policy fixes for S3 in non-proxied mode * It should be img-src * In both img-src and media-src we still need to include 'self'
		
			
				
	
	
		
			102 lines
		
	
	
	
		
			3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			102 lines
		
	
	
	
		
			3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // GoToSocial
 | |
| // Copyright (C) GoToSocial Authors admin@gotosocial.org
 | |
| // SPDX-License-Identifier: AGPL-3.0-or-later
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful,
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package middleware_test
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/config"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/middleware"
 | |
| )
 | |
| 
 | |
| func TestBuildContentSecurityPolicy(t *testing.T) {
 | |
| 	type cspTest struct {
 | |
| 		s3Endpoint string
 | |
| 		s3Proxy    bool
 | |
| 		s3Secure   bool
 | |
| 		expected   string
 | |
| 		actual     string
 | |
| 	}
 | |
| 
 | |
| 	for _, test := range []cspTest{
 | |
| 		{
 | |
| 			s3Endpoint: "",
 | |
| 			s3Proxy:    false,
 | |
| 			s3Secure:   false,
 | |
| 			expected:   "default-src 'self'",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "some-bucket-provider.com",
 | |
| 			s3Proxy:    false,
 | |
| 			s3Secure:   true,
 | |
| 			expected:   "default-src 'self'; img-src 'self' https://some-bucket-provider.com; media-src 'self' https://some-bucket-provider.com",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "some-bucket-provider.com:6969",
 | |
| 			s3Proxy:    false,
 | |
| 			s3Secure:   true,
 | |
| 			expected:   "default-src 'self'; img-src 'self' https://some-bucket-provider.com:6969; media-src 'self' https://some-bucket-provider.com:6969",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "some-bucket-provider.com:6969",
 | |
| 			s3Proxy:    false,
 | |
| 			s3Secure:   false,
 | |
| 			expected:   "default-src 'self'; img-src 'self' http://some-bucket-provider.com:6969; media-src 'self' http://some-bucket-provider.com:6969",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "s3.nl-ams.scw.cloud",
 | |
| 			s3Proxy:    false,
 | |
| 			s3Secure:   true,
 | |
| 			expected:   "default-src 'self'; img-src 'self' https://s3.nl-ams.scw.cloud; media-src 'self' https://s3.nl-ams.scw.cloud",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "some-bucket-provider.com",
 | |
| 			s3Proxy:    true,
 | |
| 			s3Secure:   true,
 | |
| 			expected:   "default-src 'self'",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "some-bucket-provider.com:6969",
 | |
| 			s3Proxy:    true,
 | |
| 			s3Secure:   true,
 | |
| 			expected:   "default-src 'self'",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "some-bucket-provider.com:6969",
 | |
| 			s3Proxy:    true,
 | |
| 			s3Secure:   true,
 | |
| 			expected:   "default-src 'self'",
 | |
| 		},
 | |
| 		{
 | |
| 			s3Endpoint: "s3.nl-ams.scw.cloud",
 | |
| 			s3Proxy:    true,
 | |
| 			s3Secure:   true,
 | |
| 			expected:   "default-src 'self'",
 | |
| 		},
 | |
| 	} {
 | |
| 		config.SetStorageS3Endpoint(test.s3Endpoint)
 | |
| 		config.SetStorageS3Proxy(test.s3Proxy)
 | |
| 		config.SetStorageS3UseSSL(test.s3Secure)
 | |
| 
 | |
| 		csp := middleware.BuildContentSecurityPolicy()
 | |
| 		if csp != test.expected {
 | |
| 			t.Logf("expected '%s', got '%s'", test.expected, csp)
 | |
| 			t.Fail()
 | |
| 		}
 | |
| 	}
 | |
| }
 |