mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2025-10-29 16:42:25 -05:00
* start work rewriting timeline cache type
* further work rewriting timeline caching
* more work integration new timeline code
* remove old code
* add local timeline, fix up merge conflicts
* remove old use of go-bytes
* implement new timeline code into more areas of codebase, pull in latest go-mangler, go-mutexes, go-structr
* remove old timeline package, add local timeline cache
* remove references to old timeline types that needed starting up in tests
* start adding page validation
* fix test-identified timeline cache package issues
* fix up more tests, fix missing required changes, etc
* add exclusion for test.out in gitignore
* clarify some things better in code comments
* tweak cache size limits
* fix list timeline cache fetching
* further list timeline fixes
* linter, ssssssssshhhhhhhhhhhh please
* fix linter hints
* reslice the output if it's beyond length of 'lim'
* remove old timeline initialization code, bump go-structr to v0.9.4
* continued from previous commit
* improved code comments
* don't allow multiple entries for BoostOfID values to prevent repeated boosts of same boosts
* finish writing more code comments
* some variable renaming, for ease of following
* change the way we update lo,hi paging values during timeline load
* improved code comments for updated / returned lo , hi paging values
* finish writing code comments for the StatusTimeline{} type itself
* fill in more code comments
* update go-structr version to latest with changed timeline unique indexing logic
* have a local and public timeline *per user*
* rewrite calls to public / local timeline calls
* remove the zero length check, as lo, hi values might still be set
* simplify timeline cache loading, fix lo/hi returns, fix timeline invalidation side-effects missing for some federated actions
* swap the lo, hi values 🤦
* add (now) missing slice reverse of tag timeline statuses when paging ASC
* remove local / public caches (is out of scope for this work), share more timeline code
* remove unnecessary change
* again, remove more unused code
* remove unused function to appease the linter
* move boost checking to prepare function
* fix use of timeline.lastOrder, fix incorrect range functions used
* remove comments for repeat code
* remove the boost logic from prepare function
* do a maximum of 5 loads, not 10
* add repeat boost filtering logic, update go-structr, general improvements
* more code comments
* add important note
* fix timeline tests now that timelines are returned in page order
* remove unused field
* add StatusTimeline{} tests
* add more status timeline tests
* start adding preloading support
* ensure repeat boosts are marked in preloaded entries
* share a bunch of the database load code in timeline cache, don't clear timelines on relationship change
* add logic to allow dynamic clear / preloading of timelines
* comment-out unused functions, but leave in place as we might end-up using them
* fix timeline preload state check
* much improved status timeline code comments
* more code comments, don't bother inserting statuses if timeline not preloaded
* shift around some logic to make sure things aren't accidentally left set
* finish writing code comments
* remove trim-after-insert behaviour
* fix-up some comments referring to old logic
* remove unsetting of lo, hi
* fix preload repeatBoost checking logic
* don't return on status filter errors, these are usually transient
* better concurrency safety in Clear() and Done()
* fix test broken due to addition of preloader
* fix repeatBoost logic that doesn't account for already-hidden repeatBoosts
* ensure edit submodels are dropped on cache insertion
* update code-comment to expand CAS accronym
* use a plus1hULID() instead of 24h
* remove unused functions
* add note that public / local timeline requester can be nil
* fix incorrect visibility filtering of tag timeline statuses
* ensure we filter home timeline statuses on local only
* some small re-orderings to confirm query params in correct places
* fix the local only home timeline filter func
339 lines
12 KiB
Go
339 lines
12 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package bookmarks_test
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strconv"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
"github.com/superseriousbusiness/gotosocial/internal/admin"
|
|
"github.com/superseriousbusiness/gotosocial/internal/api/client/bookmarks"
|
|
"github.com/superseriousbusiness/gotosocial/internal/api/client/statuses"
|
|
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
|
"github.com/superseriousbusiness/gotosocial/internal/config"
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
"github.com/superseriousbusiness/gotosocial/internal/email"
|
|
"github.com/superseriousbusiness/gotosocial/internal/federation"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/media"
|
|
"github.com/superseriousbusiness/gotosocial/internal/oauth"
|
|
"github.com/superseriousbusiness/gotosocial/internal/processing"
|
|
"github.com/superseriousbusiness/gotosocial/internal/state"
|
|
"github.com/superseriousbusiness/gotosocial/internal/storage"
|
|
"github.com/superseriousbusiness/gotosocial/internal/typeutils"
|
|
"github.com/superseriousbusiness/gotosocial/testrig"
|
|
)
|
|
|
|
type BookmarkTestSuite struct {
|
|
// standard suite interfaces
|
|
suite.Suite
|
|
db db.DB
|
|
tc *typeutils.Converter
|
|
mediaManager *media.Manager
|
|
federator *federation.Federator
|
|
emailSender email.Sender
|
|
processor *processing.Processor
|
|
storage *storage.Driver
|
|
state state.State
|
|
|
|
// standard suite models
|
|
testTokens map[string]*gtsmodel.Token
|
|
testApplications map[string]*gtsmodel.Application
|
|
testUsers map[string]*gtsmodel.User
|
|
testAccounts map[string]*gtsmodel.Account
|
|
testAttachments map[string]*gtsmodel.MediaAttachment
|
|
testStatuses map[string]*gtsmodel.Status
|
|
testFollows map[string]*gtsmodel.Follow
|
|
testBookmarks map[string]*gtsmodel.StatusBookmark
|
|
|
|
// module being tested
|
|
statusModule *statuses.Module
|
|
bookmarkModule *bookmarks.Module
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) SetupSuite() {
|
|
suite.testTokens = testrig.NewTestTokens()
|
|
suite.testApplications = testrig.NewTestApplications()
|
|
suite.testUsers = testrig.NewTestUsers()
|
|
suite.testAccounts = testrig.NewTestAccounts()
|
|
suite.testAttachments = testrig.NewTestAttachments()
|
|
suite.testStatuses = testrig.NewTestStatuses()
|
|
suite.testFollows = testrig.NewTestFollows()
|
|
suite.testBookmarks = testrig.NewTestBookmarks()
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) SetupTest() {
|
|
suite.state.Caches.Init()
|
|
testrig.StartNoopWorkers(&suite.state)
|
|
|
|
testrig.InitTestConfig()
|
|
testrig.InitTestLog()
|
|
|
|
suite.db = testrig.NewTestDB(&suite.state)
|
|
suite.state.DB = suite.db
|
|
suite.state.AdminActions = admin.New(suite.state.DB, &suite.state.Workers)
|
|
suite.storage = testrig.NewInMemoryStorage()
|
|
suite.state.Storage = suite.storage
|
|
|
|
suite.tc = typeutils.NewConverter(&suite.state)
|
|
|
|
testrig.StandardDBSetup(suite.db, nil)
|
|
testrig.StandardStorageSetup(suite.storage, "../../../../testrig/media")
|
|
|
|
suite.mediaManager = testrig.NewTestMediaManager(&suite.state)
|
|
suite.federator = testrig.NewTestFederator(&suite.state, testrig.NewTestTransportController(&suite.state, testrig.NewMockHTTPClient(nil, "../../../../testrig/media")), suite.mediaManager)
|
|
suite.emailSender = testrig.NewEmailSender("../../../../web/template/", nil)
|
|
suite.processor = testrig.NewTestProcessor(
|
|
&suite.state,
|
|
suite.federator,
|
|
suite.emailSender,
|
|
testrig.NewNoopWebPushSender(),
|
|
suite.mediaManager,
|
|
)
|
|
suite.statusModule = statuses.New(suite.processor)
|
|
suite.bookmarkModule = bookmarks.New(suite.processor)
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) TearDownTest() {
|
|
testrig.StandardDBTeardown(suite.db)
|
|
testrig.StandardStorageTeardown(suite.storage)
|
|
testrig.StopWorkers(&suite.state)
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) getBookmarks(
|
|
account *gtsmodel.Account,
|
|
token *gtsmodel.Token,
|
|
user *gtsmodel.User,
|
|
expectedHTTPStatus int,
|
|
maxID string,
|
|
minID string,
|
|
limit int,
|
|
) ([]*apimodel.Status, string, error) {
|
|
// instantiate recorder + test context
|
|
recorder := httptest.NewRecorder()
|
|
ctx, _ := testrig.CreateGinTestContext(recorder, nil)
|
|
ctx.Set(oauth.SessionAuthorizedAccount, account)
|
|
ctx.Set(oauth.SessionAuthorizedToken, oauth.DBTokenToToken(token))
|
|
ctx.Set(oauth.SessionAuthorizedApplication, suite.testApplications["application_1"])
|
|
ctx.Set(oauth.SessionAuthorizedUser, user)
|
|
|
|
// create the request URI
|
|
requestPath := bookmarks.BasePath + "?" + bookmarks.LimitKey + "=" + strconv.Itoa(limit)
|
|
if maxID != "" {
|
|
requestPath = requestPath + "&" + bookmarks.MaxIDKey + "=" + maxID
|
|
}
|
|
if minID != "" {
|
|
requestPath = requestPath + "&" + bookmarks.MinIDKey + "=" + minID
|
|
}
|
|
baseURI := config.GetProtocol() + "://" + config.GetHost()
|
|
requestURI := baseURI + "/api/" + requestPath
|
|
|
|
// create the request
|
|
ctx.Request = httptest.NewRequest(http.MethodGet, requestURI, nil)
|
|
ctx.Request.Header.Set("accept", "application/json")
|
|
|
|
// trigger the handler
|
|
suite.bookmarkModule.BookmarksGETHandler(ctx)
|
|
|
|
// read the response
|
|
result := recorder.Result()
|
|
defer result.Body.Close()
|
|
|
|
if resultCode := recorder.Code; expectedHTTPStatus != resultCode {
|
|
return nil, "", fmt.Errorf("expected %d got %d", expectedHTTPStatus, resultCode)
|
|
}
|
|
|
|
b, err := ioutil.ReadAll(result.Body)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
resp := []*apimodel.Status{}
|
|
if err := json.Unmarshal(b, &resp); err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
return resp, result.Header.Get("Link"), nil
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) TestGetBookmarksSingle() {
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
testToken := suite.testTokens["local_account_1"]
|
|
testUser := suite.testUsers["local_account_1"]
|
|
|
|
statuses, linkHeader, err := suite.getBookmarks(testAccount, testToken, testUser, http.StatusOK, "", "", 10)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
suite.Len(statuses, 1)
|
|
suite.Equal(`<http://localhost:8080/api/v1/bookmarks?limit=10&max_id=01F8MHD2QCZSZ6WQS2ATVPEYJ9>; rel="next", <http://localhost:8080/api/v1/bookmarks?limit=10&min_id=01F8MHD2QCZSZ6WQS2ATVPEYJ9>; rel="prev"`, linkHeader)
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) TestGetBookmarksMultiple() {
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
testToken := suite.testTokens["local_account_1"]
|
|
testUser := suite.testUsers["local_account_1"]
|
|
|
|
// Add a few extra bookmarks for this account.
|
|
ctx := context.Background()
|
|
for _, b := range []*gtsmodel.StatusBookmark{
|
|
{
|
|
ID: "01GSZPDQYE9WZ26T501KMM876V", // oldest
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_2"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
{
|
|
ID: "01GSZPGHY3ACEN11D512V6MR0M",
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_3"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
{
|
|
ID: "01GSZPGY4ZSHNV0PR3HSBB1DDV", // newest
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_4"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
} {
|
|
if err := suite.db.Put(ctx, b); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
}
|
|
|
|
statuses, linkHeader, err := suite.getBookmarks(testAccount, testToken, testUser, http.StatusOK, "", "", 10)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
suite.Len(statuses, 4)
|
|
suite.Equal(`<http://localhost:8080/api/v1/bookmarks?limit=10&max_id=01F8MHD2QCZSZ6WQS2ATVPEYJ9>; rel="next", <http://localhost:8080/api/v1/bookmarks?limit=10&min_id=01GSZPGY4ZSHNV0PR3HSBB1DDV>; rel="prev"`, linkHeader)
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) TestGetBookmarksMultiplePaging() {
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
testToken := suite.testTokens["local_account_1"]
|
|
testUser := suite.testUsers["local_account_1"]
|
|
|
|
// Add a few extra bookmarks for this account.
|
|
ctx := context.Background()
|
|
for _, b := range []*gtsmodel.StatusBookmark{
|
|
{
|
|
ID: "01GSZPDQYE9WZ26T501KMM876V", // oldest
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_2"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
{
|
|
ID: "01GSZPGHY3ACEN11D512V6MR0M",
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_3"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
{
|
|
ID: "01GSZPGY4ZSHNV0PR3HSBB1DDV", // newest
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_4"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
} {
|
|
if err := suite.db.Put(ctx, b); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
}
|
|
|
|
statuses, linkHeader, err := suite.getBookmarks(testAccount, testToken, testUser, http.StatusOK, "01GSZPGY4ZSHNV0PR3HSBB1DDV", "", 10)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
suite.Len(statuses, 3)
|
|
suite.Equal(`<http://localhost:8080/api/v1/bookmarks?limit=10&max_id=01F8MHD2QCZSZ6WQS2ATVPEYJ9>; rel="next", <http://localhost:8080/api/v1/bookmarks?limit=10&min_id=01GSZPGHY3ACEN11D512V6MR0M>; rel="prev"`, linkHeader)
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) TestGetBookmarksNone() {
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
testToken := suite.testTokens["local_account_1"]
|
|
testUser := suite.testUsers["local_account_1"]
|
|
|
|
// Remove all bookmarks for this account.
|
|
if err := suite.db.DeleteStatusBookmarks(context.Background(), "", testAccount.ID); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
statuses, linkHeader, err := suite.getBookmarks(testAccount, testToken, testUser, http.StatusOK, "", "", 10)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
suite.Empty(statuses)
|
|
suite.Empty(linkHeader)
|
|
}
|
|
|
|
func (suite *BookmarkTestSuite) TestGetBookmarksNonexistentStatus() {
|
|
testAccount := suite.testAccounts["local_account_1"]
|
|
testToken := suite.testTokens["local_account_1"]
|
|
testUser := suite.testUsers["local_account_1"]
|
|
|
|
// Add a few extra bookmarks for this account.
|
|
ctx := context.Background()
|
|
for _, b := range []*gtsmodel.StatusBookmark{
|
|
{
|
|
ID: "01GSZPDQYE9WZ26T501KMM876V", // oldest
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_2"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
{
|
|
ID: "01GSZPGHY3ACEN11D512V6MR0M",
|
|
AccountID: testAccount.ID,
|
|
StatusID: suite.testStatuses["admin_account_status_3"].ID,
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
{
|
|
ID: "01GSZPGY4ZSHNV0PR3HSBB1DDV", // newest
|
|
AccountID: testAccount.ID,
|
|
StatusID: "01GSZQCRX4CXPECWA5M37QNV9F", // <-- THIS ONE DOESN'T EXIST
|
|
TargetAccountID: suite.testAccounts["admin_account"].ID,
|
|
},
|
|
} {
|
|
if err := suite.db.Put(ctx, b); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
}
|
|
|
|
statuses, linkHeader, err := suite.getBookmarks(testAccount, testToken, testUser, http.StatusOK, "", "", 10)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
suite.Len(statuses, 3)
|
|
suite.Equal(`<http://localhost:8080/api/v1/bookmarks?limit=10&max_id=01F8MHD2QCZSZ6WQS2ATVPEYJ9>; rel="next", <http://localhost:8080/api/v1/bookmarks?limit=10&min_id=01GSZPGHY3ACEN11D512V6MR0M>; rel="prev"`, linkHeader)
|
|
}
|
|
|
|
func TestBookmarkTestSuite(t *testing.T) {
|
|
suite.Run(t, new(BookmarkTestSuite))
|
|
}
|