mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-10-31 09:22:25 -05:00 
			
		
		
		
	* improvements to caching for lists and relationship to accounts / follows * fix nil panic in AddToList() * ensure list related caches are correctly invalidated * ensure returned ID lists are ordered correctly * bump go-structr to v0.8.9 (returns early if zero uncached keys to be loaded) * remove zero checks in uncached key load functions (go-structr now handles this) * fix issues after rebase on upstream/main * update the expected return order of CSV exports (since list entries are now down by entry creation date) * rename some funcs, allow deleting list entries for multiple follow IDs at a time, fix up more tests * use returning statements on delete to get cache invalidation info * fixes to recent database delete changes * fix broken list entries delete sql * remove unused db function * update remainder of delete functions to behave in similar way, some other small tweaks * fix delete user sql, allow returning on err no entries * uncomment + fix list database tests * update remaining list tests * update envparsing test * add comments to each specific key being invalidated * add more cache invalidation explanatory comments * whoops; actually delete poll votes from database in the DeletePollByID() func * remove added but-commented-out field * improved comment regarding paging being disabled * make cache invalidation comments match what's actually happening * fix up delete query comments to match what is happening * rename function to read a bit better * don't use ErrNoEntries on delete when not needed (it's only needed for a RETURNING call) * update function name in test * move list exclusivity check to AFTER eligibility check. use log.Panic() instead of panic() * use the poll_id column in poll_votes for selecting votes in poll ID * fix function name
		
			
				
	
	
		
			88 lines
		
	
	
	
		
			3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			88 lines
		
	
	
	
		
			3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // GoToSocial
 | |
| // Copyright (C) GoToSocial Authors admin@gotosocial.org
 | |
| // SPDX-License-Identifier: AGPL-3.0-or-later
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful,
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package account
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 
 | |
| 	apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/db"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtscontext"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtserror"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/log"
 | |
| )
 | |
| 
 | |
| // ListsGet returns all lists owned by requestingAccount, which contain a follow for targetAccountID.
 | |
| func (p *Processor) ListsGet(ctx context.Context, requestingAccount *gtsmodel.Account, targetAccountID string) ([]*apimodel.List, gtserror.WithCode) {
 | |
| 	targetAccount, err := p.state.DB.GetAccountByID(ctx, targetAccountID)
 | |
| 	if err != nil {
 | |
| 		if errors.Is(err, db.ErrNoEntries) {
 | |
| 			return nil, gtserror.NewErrorNotFound(errors.New("account not found"))
 | |
| 		}
 | |
| 		return nil, gtserror.NewErrorInternalError(fmt.Errorf("db error: %w", err))
 | |
| 	}
 | |
| 
 | |
| 	visible, err := p.visFilter.AccountVisible(ctx, requestingAccount, targetAccount)
 | |
| 	if err != nil {
 | |
| 		return nil, gtserror.NewErrorInternalError(fmt.Errorf("db error: %w", err))
 | |
| 	}
 | |
| 
 | |
| 	if !visible {
 | |
| 		return nil, gtserror.NewErrorNotFound(errors.New("account not found"))
 | |
| 	}
 | |
| 
 | |
| 	// Requester has to follow targetAccount
 | |
| 	// for them to be in any of their lists.
 | |
| 	follow, err := p.state.DB.GetFollow(
 | |
| 
 | |
| 		// Don't populate follow.
 | |
| 		gtscontext.SetBarebones(ctx),
 | |
| 		requestingAccount.ID,
 | |
| 		targetAccountID,
 | |
| 	)
 | |
| 	if err != nil && !errors.Is(err, db.ErrNoEntries) {
 | |
| 		err := gtserror.Newf("error getting follow: %w", err)
 | |
| 		return nil, gtserror.NewErrorInternalError(err)
 | |
| 	}
 | |
| 
 | |
| 	if follow == nil {
 | |
| 		return []*apimodel.List{}, nil
 | |
| 	}
 | |
| 
 | |
| 	// Get all lists that this follow is an entry within.
 | |
| 	lists, err := p.state.DB.GetListsContainingFollowID(ctx, follow.ID)
 | |
| 	if err != nil {
 | |
| 		err := gtserror.Newf("error getting lists for follow: %w", err)
 | |
| 		return nil, gtserror.NewErrorInternalError(err)
 | |
| 	}
 | |
| 
 | |
| 	apiLists := make([]*apimodel.List, 0, len(lists))
 | |
| 	for _, list := range lists {
 | |
| 		apiList, err := p.converter.ListToAPIList(ctx, list)
 | |
| 		if err != nil {
 | |
| 			log.Errorf(ctx, "error converting list: %v", err)
 | |
| 			continue
 | |
| 		}
 | |
| 		apiLists = append(apiLists, apiList)
 | |
| 	}
 | |
| 
 | |
| 	return apiLists, nil
 | |
| }
 |