mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-10-30 19:52:25 -05:00 
			
		
		
		
	* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
		
	
			
		
			
				
	
	
		
			315 lines
		
	
	
	
		
			10 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			315 lines
		
	
	
	
		
			10 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // GoToSocial
 | |
| // Copyright (C) GoToSocial Authors admin@gotosocial.org
 | |
| // SPDX-License-Identifier: AGPL-3.0-or-later
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful,
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package processing
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 
 | |
| 	apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/db"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtserror"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/log"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/oauth"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/timeline"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/typeutils"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/util"
 | |
| 	"github.com/superseriousbusiness/gotosocial/internal/visibility"
 | |
| )
 | |
| 
 | |
| const boostReinsertionDepth = 50
 | |
| 
 | |
| // StatusGrabFunction returns a function that satisfies the GrabFunction interface in internal/timeline.
 | |
| func StatusGrabFunction(database db.DB) timeline.GrabFunction {
 | |
| 	return func(ctx context.Context, timelineAccountID string, maxID string, sinceID string, minID string, limit int) ([]timeline.Timelineable, bool, error) {
 | |
| 		statuses, err := database.GetHomeTimeline(ctx, timelineAccountID, maxID, sinceID, minID, limit, false)
 | |
| 		if err != nil {
 | |
| 			if err == db.ErrNoEntries {
 | |
| 				return nil, true, nil // we just don't have enough statuses left in the db so return stop = true
 | |
| 			}
 | |
| 			return nil, false, fmt.Errorf("statusGrabFunction: error getting statuses from db: %s", err)
 | |
| 		}
 | |
| 
 | |
| 		items := make([]timeline.Timelineable, len(statuses))
 | |
| 		for i, s := range statuses {
 | |
| 			items[i] = s
 | |
| 		}
 | |
| 
 | |
| 		return items, false, nil
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // StatusFilterFunction returns a function that satisfies the FilterFunction interface in internal/timeline.
 | |
| func StatusFilterFunction(database db.DB, filter *visibility.Filter) timeline.FilterFunction {
 | |
| 	return func(ctx context.Context, timelineAccountID string, item timeline.Timelineable) (shouldIndex bool, err error) {
 | |
| 		status, ok := item.(*gtsmodel.Status)
 | |
| 		if !ok {
 | |
| 			return false, errors.New("statusFilterFunction: could not convert item to *gtsmodel.Status")
 | |
| 		}
 | |
| 
 | |
| 		requestingAccount, err := database.GetAccountByID(ctx, timelineAccountID)
 | |
| 		if err != nil {
 | |
| 			return false, fmt.Errorf("statusFilterFunction: error getting account with id %s", timelineAccountID)
 | |
| 		}
 | |
| 
 | |
| 		timelineable, err := filter.StatusHomeTimelineable(ctx, requestingAccount, status)
 | |
| 		if err != nil {
 | |
| 			log.Warnf(ctx, "error checking hometimelineability of status %s for account %s: %s", status.ID, timelineAccountID, err)
 | |
| 		}
 | |
| 
 | |
| 		return timelineable, nil // we don't return the error here because we want to just skip this item if something goes wrong
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // StatusPrepareFunction returns a function that satisfies the PrepareFunction interface in internal/timeline.
 | |
| func StatusPrepareFunction(database db.DB, tc typeutils.TypeConverter) timeline.PrepareFunction {
 | |
| 	return func(ctx context.Context, timelineAccountID string, itemID string) (timeline.Preparable, error) {
 | |
| 		status, err := database.GetStatusByID(ctx, itemID)
 | |
| 		if err != nil {
 | |
| 			return nil, fmt.Errorf("statusPrepareFunction: error getting status with id %s", itemID)
 | |
| 		}
 | |
| 
 | |
| 		requestingAccount, err := database.GetAccountByID(ctx, timelineAccountID)
 | |
| 		if err != nil {
 | |
| 			return nil, fmt.Errorf("statusPrepareFunction: error getting account with id %s", timelineAccountID)
 | |
| 		}
 | |
| 
 | |
| 		return tc.StatusToAPIStatus(ctx, status, requestingAccount)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // StatusSkipInsertFunction returns a function that satisifes the SkipInsertFunction interface in internal/timeline.
 | |
| func StatusSkipInsertFunction() timeline.SkipInsertFunction {
 | |
| 	return func(
 | |
| 		ctx context.Context,
 | |
| 		newItemID string,
 | |
| 		newItemAccountID string,
 | |
| 		newItemBoostOfID string,
 | |
| 		newItemBoostOfAccountID string,
 | |
| 		nextItemID string,
 | |
| 		nextItemAccountID string,
 | |
| 		nextItemBoostOfID string,
 | |
| 		nextItemBoostOfAccountID string,
 | |
| 		depth int,
 | |
| 	) (bool, error) {
 | |
| 		// make sure we don't insert a duplicate
 | |
| 		if newItemID == nextItemID {
 | |
| 			return true, nil
 | |
| 		}
 | |
| 
 | |
| 		// check if it's a boost
 | |
| 		if newItemBoostOfID != "" {
 | |
| 			// skip if we've recently put another boost of this status in the timeline
 | |
| 			if newItemBoostOfID == nextItemBoostOfID {
 | |
| 				if depth < boostReinsertionDepth {
 | |
| 					return true, nil
 | |
| 				}
 | |
| 			}
 | |
| 
 | |
| 			// skip if we've recently put the original status in the timeline
 | |
| 			if newItemBoostOfID == nextItemID {
 | |
| 				if depth < boostReinsertionDepth {
 | |
| 					return true, nil
 | |
| 				}
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		// insert the item
 | |
| 		return false, nil
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func (p *Processor) HomeTimelineGet(ctx context.Context, authed *oauth.Auth, maxID string, sinceID string, minID string, limit int, local bool) (*apimodel.PageableResponse, gtserror.WithCode) {
 | |
| 	preparedItems, err := p.statusTimelines.GetTimeline(ctx, authed.Account.ID, maxID, sinceID, minID, limit, local)
 | |
| 	if err != nil {
 | |
| 		return nil, gtserror.NewErrorInternalError(err)
 | |
| 	}
 | |
| 
 | |
| 	count := len(preparedItems)
 | |
| 
 | |
| 	if count == 0 {
 | |
| 		return util.EmptyPageableResponse(), nil
 | |
| 	}
 | |
| 
 | |
| 	items := []interface{}{}
 | |
| 	nextMaxIDValue := ""
 | |
| 	prevMinIDValue := ""
 | |
| 	for i, item := range preparedItems {
 | |
| 		if i == count-1 {
 | |
| 			nextMaxIDValue = item.GetID()
 | |
| 		}
 | |
| 
 | |
| 		if i == 0 {
 | |
| 			prevMinIDValue = item.GetID()
 | |
| 		}
 | |
| 		items = append(items, item)
 | |
| 	}
 | |
| 
 | |
| 	return util.PackagePageableResponse(util.PageableResponseParams{
 | |
| 		Items:          items,
 | |
| 		Path:           "api/v1/timelines/home",
 | |
| 		NextMaxIDValue: nextMaxIDValue,
 | |
| 		PrevMinIDValue: prevMinIDValue,
 | |
| 		Limit:          limit,
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func (p *Processor) PublicTimelineGet(ctx context.Context, authed *oauth.Auth, maxID string, sinceID string, minID string, limit int, local bool) (*apimodel.PageableResponse, gtserror.WithCode) {
 | |
| 	statuses, err := p.state.DB.GetPublicTimeline(ctx, maxID, sinceID, minID, limit, local)
 | |
| 	if err != nil {
 | |
| 		if err == db.ErrNoEntries {
 | |
| 			// there are just no entries left
 | |
| 			return util.EmptyPageableResponse(), nil
 | |
| 		}
 | |
| 		// there's an actual error
 | |
| 		return nil, gtserror.NewErrorInternalError(err)
 | |
| 	}
 | |
| 
 | |
| 	filtered, err := p.filterPublicStatuses(ctx, authed, statuses)
 | |
| 	if err != nil {
 | |
| 		return nil, gtserror.NewErrorInternalError(err)
 | |
| 	}
 | |
| 
 | |
| 	count := len(filtered)
 | |
| 
 | |
| 	if count == 0 {
 | |
| 		return util.EmptyPageableResponse(), nil
 | |
| 	}
 | |
| 
 | |
| 	items := []interface{}{}
 | |
| 	nextMaxIDValue := ""
 | |
| 	prevMinIDValue := ""
 | |
| 	for i, item := range filtered {
 | |
| 		if i == count-1 {
 | |
| 			nextMaxIDValue = item.GetID()
 | |
| 		}
 | |
| 
 | |
| 		if i == 0 {
 | |
| 			prevMinIDValue = item.GetID()
 | |
| 		}
 | |
| 		items = append(items, item)
 | |
| 	}
 | |
| 
 | |
| 	return util.PackagePageableResponse(util.PageableResponseParams{
 | |
| 		Items:          items,
 | |
| 		Path:           "api/v1/timelines/public",
 | |
| 		NextMaxIDValue: nextMaxIDValue,
 | |
| 		PrevMinIDValue: prevMinIDValue,
 | |
| 		Limit:          limit,
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func (p *Processor) FavedTimelineGet(ctx context.Context, authed *oauth.Auth, maxID string, minID string, limit int) (*apimodel.PageableResponse, gtserror.WithCode) {
 | |
| 	statuses, nextMaxID, prevMinID, err := p.state.DB.GetFavedTimeline(ctx, authed.Account.ID, maxID, minID, limit)
 | |
| 	if err != nil {
 | |
| 		if err == db.ErrNoEntries {
 | |
| 			// there are just no entries left
 | |
| 			return util.EmptyPageableResponse(), nil
 | |
| 		}
 | |
| 		// there's an actual error
 | |
| 		return nil, gtserror.NewErrorInternalError(err)
 | |
| 	}
 | |
| 
 | |
| 	filtered, err := p.filterFavedStatuses(ctx, authed, statuses)
 | |
| 	if err != nil {
 | |
| 		return nil, gtserror.NewErrorInternalError(err)
 | |
| 	}
 | |
| 
 | |
| 	if len(filtered) == 0 {
 | |
| 		return util.EmptyPageableResponse(), nil
 | |
| 	}
 | |
| 
 | |
| 	items := []interface{}{}
 | |
| 	for _, item := range filtered {
 | |
| 		items = append(items, item)
 | |
| 	}
 | |
| 
 | |
| 	return util.PackagePageableResponse(util.PageableResponseParams{
 | |
| 		Items:          items,
 | |
| 		Path:           "api/v1/favourites",
 | |
| 		NextMaxIDValue: nextMaxID,
 | |
| 		PrevMinIDValue: prevMinID,
 | |
| 		Limit:          limit,
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func (p *Processor) filterPublicStatuses(ctx context.Context, authed *oauth.Auth, statuses []*gtsmodel.Status) ([]*apimodel.Status, error) {
 | |
| 	apiStatuses := []*apimodel.Status{}
 | |
| 	for _, s := range statuses {
 | |
| 		if _, err := p.state.DB.GetAccountByID(ctx, s.AccountID); err != nil {
 | |
| 			if err == db.ErrNoEntries {
 | |
| 				log.Debugf(ctx, "skipping status %s because account %s can't be found in the db", s.ID, s.AccountID)
 | |
| 				continue
 | |
| 			}
 | |
| 			return nil, gtserror.NewErrorInternalError(fmt.Errorf("filterPublicStatuses: error getting status author: %s", err))
 | |
| 		}
 | |
| 
 | |
| 		timelineable, err := p.filter.StatusPublicTimelineable(ctx, authed.Account, s)
 | |
| 		if err != nil {
 | |
| 			log.Debugf(ctx, "skipping status %s because of an error checking status visibility: %s", s.ID, err)
 | |
| 			continue
 | |
| 		}
 | |
| 		if !timelineable {
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		apiStatus, err := p.tc.StatusToAPIStatus(ctx, s, authed.Account)
 | |
| 		if err != nil {
 | |
| 			log.Debugf(ctx, "skipping status %s because it couldn't be converted to its api representation: %s", s.ID, err)
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		apiStatuses = append(apiStatuses, apiStatus)
 | |
| 	}
 | |
| 
 | |
| 	return apiStatuses, nil
 | |
| }
 | |
| 
 | |
| func (p *Processor) filterFavedStatuses(ctx context.Context, authed *oauth.Auth, statuses []*gtsmodel.Status) ([]*apimodel.Status, error) {
 | |
| 	apiStatuses := []*apimodel.Status{}
 | |
| 	for _, s := range statuses {
 | |
| 		if _, err := p.state.DB.GetAccountByID(ctx, s.AccountID); err != nil {
 | |
| 			if err == db.ErrNoEntries {
 | |
| 				log.Debugf(ctx, "skipping status %s because account %s can't be found in the db", s.ID, s.AccountID)
 | |
| 				continue
 | |
| 			}
 | |
| 			return nil, gtserror.NewErrorInternalError(fmt.Errorf("filterPublicStatuses: error getting status author: %s", err))
 | |
| 		}
 | |
| 
 | |
| 		timelineable, err := p.filter.StatusVisible(ctx, authed.Account, s)
 | |
| 		if err != nil {
 | |
| 			log.Debugf(ctx, "skipping status %s because of an error checking status visibility: %s", s.ID, err)
 | |
| 			continue
 | |
| 		}
 | |
| 		if !timelineable {
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		apiStatus, err := p.tc.StatusToAPIStatus(ctx, s, authed.Account)
 | |
| 		if err != nil {
 | |
| 			log.Debugf(ctx, "skipping status %s because it couldn't be converted to its api representation: %s", s.ID, err)
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		apiStatuses = append(apiStatuses, apiStatus)
 | |
| 	}
 | |
| 
 | |
| 	return apiStatuses, nil
 | |
| }
 |