mirror of
				https://github.com/superseriousbusiness/gotosocial.git
				synced 2025-10-29 19:52:24 -05:00 
			
		
		
		
	after seeing a potential reported federating worker lockup i decided to start digging into the federatingdb code. this PR encompasses:
- removes one of our last unused interface types `federatingdb.DB{}`, replacing it with a struct type `*federatingdb.DB{}`
- in `transport.dereferenceLocal()` differentiates between an unsupported lookup type and ErrNoEntries to reduce unnecessary calls, and reduce potential lockups that may occur while trying to call our own endpoints that then call `federatingdb.Lock()`
- removes a bunch of the locks on follow state changes since the DB already synchronizes that
- removes the unnecessary `pub.Clock{}` struct field and type passed to the transport controller
frankly it would be great if we could remove the locking in `federatingdb.Lock()` and instead handle it ourselves as it gets very confusing trying to figure out what functions will have locks held. but i guess that's one for when we move further away from the go-fed/activity/pub package usage.
Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4178
Co-authored-by: kim <grufwub@gmail.com>
Co-committed-by: kim <grufwub@gmail.com>
		
	
			
		
			
				
	
	
		
			220 lines
		
	
	
	
		
			6.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			220 lines
		
	
	
	
		
			6.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // GoToSocial
 | |
| // Copyright (C) GoToSocial Authors admin@gotosocial.org
 | |
| // SPDX-License-Identifier: AGPL-3.0-or-later
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful,
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package transport
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"context"
 | |
| 	"crypto/rsa"
 | |
| 	"crypto/x509"
 | |
| 	"encoding/json"
 | |
| 	"errors"
 | |
| 	"fmt"
 | |
| 	"io"
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 	"strconv"
 | |
| 
 | |
| 	"code.superseriousbusiness.org/activity/pub"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/ap"
 | |
| 	apiutil "code.superseriousbusiness.org/gotosocial/internal/api/util"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/config"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/db"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/federation/federatingdb"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/gtserror"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/state"
 | |
| 	"code.superseriousbusiness.org/gotosocial/internal/util"
 | |
| 	"codeberg.org/gruf/go-byteutil"
 | |
| 	"codeberg.org/gruf/go-cache/v3"
 | |
| )
 | |
| 
 | |
| // Controller generates transports for use in making federation requests to other servers.
 | |
| type Controller interface {
 | |
| 	// NewTransport returns an http signature transport with the given public key ID (URL location of pubkey), and the given private key.
 | |
| 	NewTransport(pubKeyID string, privkey *rsa.PrivateKey) (Transport, error)
 | |
| 
 | |
| 	// NewTransportForUsername searches for account with username, and returns result of .NewTransport().
 | |
| 	NewTransportForUsername(ctx context.Context, username string) (Transport, error)
 | |
| }
 | |
| 
 | |
| type controller struct {
 | |
| 	state     *state.State
 | |
| 	fedDB     *federatingdb.DB
 | |
| 	client    pub.HttpClient
 | |
| 	trspCache cache.TTLCache[string, *transport]
 | |
| 	userAgent string
 | |
| }
 | |
| 
 | |
| // NewController returns an implementation of the Controller interface for creating new transports
 | |
| func NewController(state *state.State, federatingDB *federatingdb.DB, client pub.HttpClient) Controller {
 | |
| 	var (
 | |
| 		host    = config.GetHost()
 | |
| 		proto   = config.GetProtocol()
 | |
| 		version = config.GetSoftwareVersion()
 | |
| 	)
 | |
| 
 | |
| 	c := &controller{
 | |
| 		state:     state,
 | |
| 		fedDB:     federatingDB,
 | |
| 		client:    client,
 | |
| 		trspCache: cache.NewTTL[string, *transport](0, 100, 0),
 | |
| 		userAgent: fmt.Sprintf("gotosocial/%s (+%s://%s)", version, proto, host),
 | |
| 	}
 | |
| 
 | |
| 	return c
 | |
| }
 | |
| 
 | |
| func (c *controller) NewTransport(pubKeyID string, privkey *rsa.PrivateKey) (Transport, error) {
 | |
| 	// Generate public key string for cache key
 | |
| 	//
 | |
| 	// NOTE: it is safe to use the public key as the cache
 | |
| 	// key here as we are generating it ourselves from the
 | |
| 	// private key. If we were simply using a public key
 | |
| 	// provided as argument that would absolutely NOT be safe.
 | |
| 	pubStr := privkeyToPublicStr(privkey)
 | |
| 
 | |
| 	// First check for cached transport
 | |
| 	transp, ok := c.trspCache.Get(pubStr)
 | |
| 	if ok {
 | |
| 		return transp, nil
 | |
| 	}
 | |
| 
 | |
| 	// Create the transport
 | |
| 	transp = &transport{
 | |
| 		controller: c,
 | |
| 		pubKeyID:   pubKeyID,
 | |
| 		privkey:    privkey,
 | |
| 	}
 | |
| 
 | |
| 	// Cache this transport under pubkey
 | |
| 	if !c.trspCache.Add(pubStr, transp) {
 | |
| 		var cached *transport
 | |
| 
 | |
| 		cached, ok = c.trspCache.Get(pubStr)
 | |
| 		if !ok {
 | |
| 			// Some ridiculous race cond.
 | |
| 			c.trspCache.Set(pubStr, transp)
 | |
| 		} else {
 | |
| 			// Use already cached
 | |
| 			transp = cached
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	return transp, nil
 | |
| }
 | |
| 
 | |
| func (c *controller) NewTransportForUsername(ctx context.Context, username string) (Transport, error) {
 | |
| 	// We need an account to use to create a transport for dereferecing something.
 | |
| 	// If a username has been given, we can fetch the account with that username and use it.
 | |
| 	// Otherwise, we can take the instance account and use those credentials to make the request.
 | |
| 	var u string
 | |
| 	if username == "" {
 | |
| 		u = config.GetHost()
 | |
| 	} else {
 | |
| 		u = username
 | |
| 	}
 | |
| 
 | |
| 	ourAccount, err := c.state.DB.GetAccountByUsernameDomain(ctx, u, "")
 | |
| 	if err != nil {
 | |
| 		return nil, fmt.Errorf("error getting account %s from db: %s", username, err)
 | |
| 	}
 | |
| 
 | |
| 	transport, err := c.NewTransport(ourAccount.PublicKeyURI, ourAccount.PrivateKey)
 | |
| 	if err != nil {
 | |
| 		return nil, fmt.Errorf("error creating transport for user %s: %s", username, err)
 | |
| 	}
 | |
| 
 | |
| 	return transport, nil
 | |
| }
 | |
| 
 | |
| // dereferenceLocal is a shortcut to try dereferencing
 | |
| // something on this instance without making any http calls.
 | |
| //
 | |
| // Will return an error if nothing could be found, indicating that
 | |
| // the calling transport should continue with an http call anyway.
 | |
| //
 | |
| // It should only be invoked when the iri.Host == this host.
 | |
| func (c *controller) dereferenceLocal(
 | |
| 	ctx context.Context,
 | |
| 	uri *url.URL,
 | |
| ) (*http.Response, error) {
 | |
| 
 | |
| 	// Try fetch via federating DB.
 | |
| 	t, err := c.fedDB.Get(ctx, uri)
 | |
| 
 | |
| 	switch {
 | |
| 	// No problem.
 | |
| 	case err == nil:
 | |
| 
 | |
| 	// Catch and handle objects not found.
 | |
| 	case errors.Is(err, db.ErrNoEntries):
 | |
| 		return &http.Response{
 | |
| 			Request:    &http.Request{URL: uri},
 | |
| 			Status:     http.StatusText(http.StatusNotFound),
 | |
| 			StatusCode: http.StatusNotFound,
 | |
| 			Header: map[string][]string{
 | |
| 				"Content-Type":   {apiutil.AppActivityLDJSON},
 | |
| 				"Content-Length": {"0"},
 | |
| 			},
 | |
| 		}, nil
 | |
| 
 | |
| 	// Any other.
 | |
| 	default:
 | |
| 		return nil, gtserror.Newf("error getting: %w", err)
 | |
| 	}
 | |
| 
 | |
| 	if util.IsNil(t) {
 | |
| 		// Assert this should never happen.
 | |
| 		panic(gtserror.New("nil vocab.Type"))
 | |
| 	}
 | |
| 
 | |
| 	// Serialize type to JSON map.
 | |
| 	m, err := ap.Serialize(t)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	// Marshal JSON to bytes.
 | |
| 	b, err := json.Marshal(m)
 | |
| 	if err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	// Return a response
 | |
| 	// with AS data as body.
 | |
| 	contentLength := len(b)
 | |
| 	rsp := &http.Response{
 | |
| 		Request:       &http.Request{URL: uri},
 | |
| 		Status:        http.StatusText(http.StatusOK),
 | |
| 		StatusCode:    http.StatusOK,
 | |
| 		Body:          io.NopCloser(bytes.NewReader(b)),
 | |
| 		ContentLength: int64(contentLength),
 | |
| 		Header: map[string][]string{
 | |
| 			"Content-Type":   {apiutil.AppActivityLDJSON},
 | |
| 			"Content-Length": {strconv.Itoa(contentLength)},
 | |
| 		},
 | |
| 	}
 | |
| 
 | |
| 	return rsp, nil
 | |
| }
 | |
| 
 | |
| // privkeyToPublicStr will create a string representation of RSA public key from private.
 | |
| func privkeyToPublicStr(privkey *rsa.PrivateKey) string {
 | |
| 	b := x509.MarshalPKCS1PublicKey(&privkey.PublicKey)
 | |
| 	return byteutil.B2S(b)
 | |
| }
 |