mirror of
https://github.com/superseriousbusiness/gotosocial.git
synced 2025-10-29 14:42:24 -05:00
~~Still WIP!~~ This PR allows v0.20.0 of GtS to be forward-compatible with the interaction request / authorization flow that will fully replace the current flow in v0.21.0. Basically, this means we need to recognize LikeRequest, ReplyRequest, and AnnounceRequest, and in response to those requests, deliver either a Reject or an Accept, with the latter pointing towards a LikeAuthorization, ReplyAuthorization, or AnnounceAuthorization, respectively. This can then be used by the remote instance to prove to third parties that the interaction has been accepted by the interactee. These Authorization types need to be dereferencable to third parties, so we need to serve them. As well as recognizing the above "polite" interaction request types, we also need to still serve appropriate responses to "impolite" interaction request types, where an instance that's unaware of interaction policies tries to interact with a post by sending a reply, like, or boost directly, without wrapping it in a WhateverRequest type. Doesn't fully close https://codeberg.org/superseriousbusiness/gotosocial/issues/4026 but gets damn near (just gotta update the federating with GtS documentation). Migrations tested on both Postgres and SQLite. Co-authored-by: kim <grufwub@gmail.com> Reviewed-on: https://codeberg.org/superseriousbusiness/gotosocial/pulls/4394 Co-authored-by: tobi <tobi.smethurst@protonmail.com> Co-committed-by: tobi <tobi.smethurst@protonmail.com>
246 lines
6.5 KiB
Go
246 lines
6.5 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package bundb_test
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
"time"
|
|
|
|
"code.superseriousbusiness.org/gotosocial/internal/db"
|
|
"code.superseriousbusiness.org/gotosocial/internal/gtsmodel"
|
|
"code.superseriousbusiness.org/gotosocial/internal/id"
|
|
"code.superseriousbusiness.org/gotosocial/internal/paging"
|
|
"code.superseriousbusiness.org/gotosocial/internal/typeutils"
|
|
"code.superseriousbusiness.org/gotosocial/internal/util"
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
type InteractionTestSuite struct {
|
|
BunDBStandardTestSuite
|
|
}
|
|
|
|
func (suite *InteractionTestSuite) markInteractionsPending(
|
|
ctx context.Context,
|
|
statusID string,
|
|
) (pendingCount int) {
|
|
// Get replies of given status.
|
|
replies, err := suite.state.DB.GetStatusReplies(ctx, statusID)
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Mark each reply as pending approval.
|
|
for _, reply := range replies {
|
|
reply.PendingApproval = util.Ptr(true)
|
|
if err := suite.state.DB.UpdateStatus(
|
|
ctx,
|
|
reply,
|
|
"pending_approval",
|
|
); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Put an impolite interaction request in the DB for this reply.
|
|
req := typeutils.StatusToImpoliteInteractionRequest(reply)
|
|
if err := suite.state.DB.PutInteractionRequest(ctx, req); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
pendingCount++
|
|
}
|
|
|
|
// Get boosts of given status.
|
|
boosts, err := suite.state.DB.GetStatusBoosts(ctx, statusID)
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Mark each boost as pending approval.
|
|
for _, boost := range boosts {
|
|
boost.PendingApproval = util.Ptr(true)
|
|
if err := suite.state.DB.UpdateStatus(
|
|
ctx,
|
|
boost,
|
|
"pending_approval",
|
|
); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Put an impolite interaction request in the DB for this boost.
|
|
req := typeutils.StatusToImpoliteInteractionRequest(boost)
|
|
if err := suite.state.DB.PutInteractionRequest(ctx, req); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
pendingCount++
|
|
}
|
|
|
|
// Get faves of given status.
|
|
faves, err := suite.state.DB.GetStatusFaves(ctx, statusID)
|
|
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Mark each fave as pending approval.
|
|
for _, fave := range faves {
|
|
fave.PendingApproval = util.Ptr(true)
|
|
if err := suite.state.DB.UpdateStatusFave(
|
|
ctx,
|
|
fave,
|
|
"pending_approval",
|
|
); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Put an impolite interaction request in the DB for this fave.
|
|
req := typeutils.StatusFaveToImpoliteInteractionRequest(fave)
|
|
if err := suite.state.DB.PutInteractionRequest(ctx, req); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
pendingCount++
|
|
}
|
|
|
|
return pendingCount
|
|
}
|
|
|
|
func (suite *InteractionTestSuite) TestGetPending() {
|
|
var (
|
|
testStatus = suite.testStatuses["local_account_1_status_1"]
|
|
ctx = suite.T().Context()
|
|
acctID = suite.testAccounts["local_account_1"].ID
|
|
statusID = ""
|
|
likes = true
|
|
replies = true
|
|
boosts = true
|
|
page = &paging.Page{
|
|
Max: paging.MaxID(id.Highest),
|
|
Limit: 20,
|
|
}
|
|
)
|
|
|
|
// Update target test status to mark
|
|
// all interactions with it pending.
|
|
pendingCount := suite.markInteractionsPending(ctx, testStatus.ID)
|
|
|
|
// Get pendingInts interactions.
|
|
pendingInts, err := suite.state.DB.GetInteractionsRequestsForAcct(
|
|
ctx,
|
|
acctID,
|
|
statusID,
|
|
likes,
|
|
replies,
|
|
boosts,
|
|
page,
|
|
)
|
|
suite.NoError(err)
|
|
suite.Len(pendingInts, pendingCount)
|
|
|
|
// Ensure relevant model populated.
|
|
for _, pendingInt := range pendingInts {
|
|
switch pendingInt.InteractionType {
|
|
|
|
case gtsmodel.InteractionLike:
|
|
suite.NotNil(pendingInt.Like)
|
|
|
|
case gtsmodel.InteractionReply:
|
|
suite.NotNil(pendingInt.Reply)
|
|
|
|
case gtsmodel.InteractionAnnounce:
|
|
suite.NotNil(pendingInt.Announce)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (suite *InteractionTestSuite) TestGetPendingRepliesOnly() {
|
|
var (
|
|
testStatus = suite.testStatuses["local_account_1_status_1"]
|
|
ctx = suite.T().Context()
|
|
acctID = suite.testAccounts["local_account_1"].ID
|
|
statusID = ""
|
|
likes = false
|
|
replies = true
|
|
boosts = false
|
|
page = &paging.Page{
|
|
Max: paging.MaxID(id.Highest),
|
|
Limit: 20,
|
|
}
|
|
)
|
|
|
|
// Update target test status to mark
|
|
// all interactions with it pending.
|
|
suite.markInteractionsPending(ctx, testStatus.ID)
|
|
|
|
// Get pendingInts interactions.
|
|
pendingInts, err := suite.state.DB.GetInteractionsRequestsForAcct(
|
|
ctx,
|
|
acctID,
|
|
statusID,
|
|
likes,
|
|
replies,
|
|
boosts,
|
|
page,
|
|
)
|
|
suite.NoError(err)
|
|
|
|
// Ensure only replies returned.
|
|
for _, pendingInt := range pendingInts {
|
|
suite.Equal(gtsmodel.InteractionReply, pendingInt.InteractionType)
|
|
}
|
|
}
|
|
|
|
func (suite *InteractionTestSuite) TestInteractionRejected() {
|
|
var (
|
|
ctx = suite.T().Context()
|
|
req = new(gtsmodel.InteractionRequest)
|
|
)
|
|
|
|
// Make a copy of the request we'll modify.
|
|
*req = *suite.testInteractionRequests["admin_account_reply_turtle"]
|
|
|
|
// No rejection in the db for this interaction URI so it should be OK.
|
|
rejected, err := suite.state.DB.IsInteractionRejected(ctx, req.InteractionURI)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
if rejected {
|
|
suite.FailNow("wanted rejected = false, got true")
|
|
}
|
|
|
|
// Update the interaction request to mark it rejected.
|
|
req.RejectedAt = time.Now()
|
|
req.ResponseURI = "https://some.reject.uri"
|
|
if err := suite.state.DB.UpdateInteractionRequest(ctx, req, "response_uri", "rejected_at"); err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
|
|
// Rejection in the db for this interaction URI now so it should be très mauvais.
|
|
rejected, err = suite.state.DB.IsInteractionRejected(ctx, req.InteractionURI)
|
|
if err != nil {
|
|
suite.FailNow(err.Error())
|
|
}
|
|
if !rejected {
|
|
suite.FailNow("wanted rejected = true, got false")
|
|
}
|
|
}
|
|
|
|
func TestInteractionTestSuite(t *testing.T) {
|
|
suite.Run(t, new(InteractionTestSuite))
|
|
}
|