Refactor: version, node description and if-else statements

nodes/FriendGrid/FriendGrid.node.ts

@@ -10,6 +10,7 @@ import {
 	INodeExecutionData,
 	INodeType,
 	INodeTypeDescription,
+	NodeOperationError,
 } from 'n8n-workflow';
 
 import {
@@ -53,6 +54,7 @@ export class FriendGrid implements INodeType {
 			{
 				displayName: 'Resource',
 				name: 'resource',
+				required: true,
 				type: 'options',
 				options: [
 					{
@@ -61,11 +63,17 @@ export class FriendGrid implements INodeType {
 					},
 				],
 				default: 'contact',
-				required: true,
 				description: 'Resource to consume',
 			},
 			...contactOperations,
 			...contactFields,
+			{
+				displayName: 'Simplify Output',
+				name: 'simplifyOutput',
+				type: 'boolean',
+				default: false,
+				description: 'Whether to simplify the output data',
+			},
 		],
 	};
 
@@ -113,33 +121,80 @@ export class FriendGrid implements INodeType {
 		const items = this.getInputData();
 		let responseData;
 		const returnData: IDataObject[] = [];
+
+		let method: string;
+		let endpoint: string;
+		const body: IDataObject = {};
+		const qs: IDataObject = {}; // query string
+
 		const resource = this.getNodeParameter('resource', 0) as string;
 		const operation = this.getNodeParameter('operation', 0) as string;
-		let body: IDataObject = {};
+		let additionalFields;
-		const qs: IDataObject = {}; // query string
 
 		for (let i = 0; i < items.length; i++) {
 			try {
-				if (resource === 'contact') {
+				switch (resource) {
-					if (operation === 'create') {
+					case 'contact':
-						// https://docs.sendgrid.com/api-reference/contacts/add-or-update-a-contact
+						switch (operation) {
+							case 'create':
+								// ----------------------------------
+								//        contact:create
+								// ----------------------------------
 
-						const email = this.getNodeParameter('email', i) as string;
+								// https://docs.sendgrid.com/api-reference/contacts/add-or-update-a-contact
-						const additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject;
+								endpoint = '';
+								method = 'POST';
+								const email = this.getNodeParameter('email', i) as string;
+								additionalFields = this.getNodeParameter('additionalFields', i) as IDataObject;
+								const data: IDataObject = { email };
+								Object.assign(data, additionalFields);
+								body.contacts = [ data ];
+								break;
 
-						const data: IDataObject = { email };
+							case 'directContractInsert':
-						Object.assign(data, additionalFields);
+								// ----------------------------------
+								//        contract:directContractInsert
+								// ----------------------------------
 
-						body = {
+								// .........
-							contacts: [
+								break;
-								data,
-							],
-						};
 
-						responseData = await friendGridApiRequest.call(this, 'POST', '/marketing/contact', body);
+							default: {
+								throw new NodeOperationError(this.getNode(), `The operation "${operation}" is not supported for resource "${resource}"!`);
+							}
+						}
+						break;
+
+					case 'contractProducts':
+						switch (operation) {
+							case 'createDirectInvoice':
+								// ----------------------------------
+								//        contractProducts:createDirectInvoice
+								// ----------------------------------
+
+								// .........
+								break;
+							case 'getDirectInvoice':
+								// ----------------------------------
+								//        contractProducts:getDirectInvoice
+								// ----------------------------------
+
+								// .........
+								break;
+
+							default: {
+								throw new NodeOperationError(this.getNode(), `The operation "${operation}" is not supported for resource "${resource}"!`);
+							}
+						}
+						break;
+
+					default: {
+						throw new NodeOperationError(this.getNode(), `The resource "${resource}" is not supported!`);
 					}
 				}
 
+				responseData = await friendGridApiRequest.call(this, method, endpoint, body, qs);
+
 				if (Array.isArray(responseData)) {
 					returnData.push.apply(returnData, responseData as IDataObject[]);
 				} else if (responseData !== undefined) {

nodes/FriendGrid/descriptions/ContactDescription.ts

@@ -9,9 +9,7 @@ export const contactOperations: INodeProperties[] = [
 		type: 'options',
 		displayOptions: {
 			show: {
-				resource: [
+				resource: ['contact'],
-					'contact',
-				],
 			},
 		},
 		options: [
@@ -33,20 +31,16 @@ export const contactFields: INodeProperties[] = [
 	{
 		displayName: 'Email',
 		name: 'email',
-		type: 'string',
 		required: true,
+		type: 'string',
 		displayOptions: {
 			show: {
-				operation: [
+				resource: ['contact'],
-					'create',
+				operation: ['create'],
-				],
-				resource: [
-					'contact',
-				],
 			},
 		},
-		default:'',
+		default: '',
-		description:'Primary email for the contact',
+		description: 'Primary email for the contact',
 	},
 	{
 		displayName: 'Additional Fields',
@@ -56,12 +50,8 @@ export const contactFields: INodeProperties[] = [
 		default: {},
 		displayOptions: {
 			show: {
-				resource: [
+				resource: ['contact'],
-					'contact',
+				operation: ['create'],
-				],
-				operation: [
-					'create',
-				],
 			},
 		},
 		options: [

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@digital-boss/n8n-nodes-starter",
-  "version": "0.1.1",
+  "version": "0.1.0",
   "description": "FriendGrid support for n8n.",
   "license": "SEE LICENSE IN LICENSE.md",
   "homepage": "https://n8n.io",