dan/combluotion
dan/combluotion
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

♻️ Rename constancts to not be uppercase

Browse source
This commit is contained in:
Dan Jones 2024-10-28 11:50:18 -05:00
commit 8a069859ea
4 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app_test.go
View file

@ -22,7 +22,7 @@ func TestDefaultEnvironment(t *testing.T) {
a, er := NewApp("0.0.0", c, testmocks.GetStore()) a, er := NewApp("0.0.0", c, testmocks.GetStore())
assert.NoError(t, er) assert.NoError(t, er)
if assert.NotNil(t, a) { if assert.NotNil(t, a) {
assert.Equal(t, config.DEV, a.Environment()) assert.Equal(t, config.Dev, a.Environment())
} }
} }
@ -31,11 +31,11 @@ func TestGivenEnvironment(t *testing.T) {
given config.Env given config.Env
exp config.Env exp config.Env
}{ }{
{config.DEV, config.DEV}, {config.Dev, config.Dev},
{config.PROD, config.PROD}, {config.Prod, config.Prod},
{config.QA, config.QA}, {config.Qa, config.Qa},
{config.Env("foo"), config.DEV}, {config.Env("foo"), config.Dev},
{config.Env("✨"), config.DEV}, {config.Env("✨"), config.Dev},
} }
for _, c := range cases { for _, c := range cases {

4
config/config_test.go
View file

@ -8,12 +8,12 @@ import (
func TestEnvDefaultsToDev(t *testing.T) { func TestEnvDefaultsToDev(t *testing.T) {
c := Config{} c := Config{}
assert.Equal(t, DEV, c.Environment()) assert.Equal(t, Dev, c.Environment())
} }
func TestInvalidEnvReturnsDev(t *testing.T) { func TestInvalidEnvReturnsDev(t *testing.T) {
c := Config{Env: Env("foobar")} c := Config{Env: Env("foobar")}
assert.Equal(t, DEV, c.Environment()) assert.Equal(t, Dev, c.Environment())
} }
func TestValidEnvReturnsCorrect(t *testing.T) { func TestValidEnvReturnsCorrect(t *testing.T) {

18
config/env.go
View file

@ -3,24 +3,24 @@ package config
type Env string type Env string
const ( const (
DEV Env = "dev" Dev Env = "dev"
PROD Env = "prod" Prod Env = "prod"
QA Env = "qa" Qa Env = "qa"
TEST Env = "test" Test Env = "test"
) )
var Envs = [...]Env{ var Envs = [...]Env{
DEV, Dev,
PROD, Prod,
QA, Qa,
TEST, Test,
} }
func ValidEnvOrDev(e Env) Env { func ValidEnvOrDev(e Env) Env {
if ValidEnv(e) { if ValidEnv(e) {
return e return e
} }
return DEV return Dev
} }
func ValidEnv(env Env) bool { func ValidEnv(env Env) bool {

22
config/env_test.go
View file

@ -21,10 +21,10 @@ func TestValidEnv(t *testing.T) {
e Env e Env
exp bool exp bool
}{ }{
{DEV, true}, {Dev, true},
{PROD, true}, {Prod, true},
{QA, true}, {Qa, true},
{TEST, true}, {Test, true},
{Env("foobar"), false}, {Env("foobar"), false},
{Env(""), false}, {Env(""), false},
{Env("✨"), false}, {Env("✨"), false},
@ -42,13 +42,13 @@ func TestValidEnvOrDev(t *testing.T) {
give Env give Env
exp Env exp Env
}{ }{
{DEV, DEV}, {Dev, Dev},
{PROD, PROD}, {Prod, Prod},
{QA, QA}, {Qa, Qa},
{TEST, TEST}, {Test, Test},
{Env("foobar"), DEV}, {Env("foobar"), Dev},
{Env(""), DEV}, {Env(""), Dev},
{Env("✨"), DEV}, {Env("✨"), Dev},
} }
for _, c := range cases { for _, c := range cases {