dan/ffmpeg-mappable-media
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix documentation and add a todo comment

Browse source 
fixes #529
This commit is contained in:
Jens Hausdorf 2018-05-10 14:29:24 +02:00 • committed by GitHub
commit fc55cf51d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/FFMpeg/Media/Concat.php
View file

@ -72,7 +72,7 @@ class Concat extends AbstractMediaType
/** /**
* Saves the concatenated video in the given array, considering that the sources videos are all encoded with the same codec. * Saves the concatenated video in the given array, considering that the sources videos are all encoded with the same codec.
* *
* @param array $outputPathfile * @param string $outputPathfile
* @param string $streamCopy * @param string $streamCopy
* *
* @return Concat * @return Concat
@ -144,6 +144,7 @@ class Concat extends AbstractMediaType
$this->driver->command($commands); $this->driver->command($commands);
} catch (ExecutionFailureException $e) { } catch (ExecutionFailureException $e) {
$this->cleanupTemporaryFile($outputPathfile); $this->cleanupTemporaryFile($outputPathfile);
// TODO@v1: paste this line into an `finally` block.
$this->cleanupTemporaryFile($sourcesFile); $this->cleanupTemporaryFile($sourcesFile);
throw new RuntimeException('Unable to save concatenated video', $e->getCode(), $e); throw new RuntimeException('Unable to save concatenated video', $e->getCode(), $e);
} }