fix documentation and add a todo comment

fixes #529
This commit is contained in:
Jens Hausdorf 2018-05-10 14:29:24 +02:00 committed by GitHub
commit fc55cf51d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -72,7 +72,7 @@ class Concat extends AbstractMediaType
/**
* Saves the concatenated video in the given array, considering that the sources videos are all encoded with the same codec.
*
* @param array $outputPathfile
* @param string $outputPathfile
* @param string $streamCopy
*
* @return Concat
@ -144,6 +144,7 @@ class Concat extends AbstractMediaType
$this->driver->command($commands);
} catch (ExecutionFailureException $e) {
$this->cleanupTemporaryFile($outputPathfile);
// TODO@v1: paste this line into an `finally` block.
$this->cleanupTemporaryFile($sourcesFile);
throw new RuntimeException('Unable to save concatenated video', $e->getCode(), $e);
}